From 275d87f302be7885c192529acb39fecc5f6cd919 Mon Sep 17 00:00:00 2001 From: Harshavardhana Date: Mon, 25 Apr 2022 07:47:56 -0700 Subject: [PATCH] config set should always use on/off not true/false (#1899) fixes https://github.com/minio/minio/issues/14516 --- .../Console/NotificationEndpoints/ConfTargetGeneric.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/portal-ui/src/screens/Console/NotificationEndpoints/ConfTargetGeneric.tsx b/portal-ui/src/screens/Console/NotificationEndpoints/ConfTargetGeneric.tsx index dc0b858a0..06910e561 100644 --- a/portal-ui/src/screens/Console/NotificationEndpoints/ConfTargetGeneric.tsx +++ b/portal-ui/src/screens/Console/NotificationEndpoints/ConfTargetGeneric.tsx @@ -52,7 +52,7 @@ export const valueDef = ( type: string, defaults: IElementValue[] ) => { - let defValue = type === "on|off" ? "false" : ""; + let defValue = type === "on|off" ? "off" : ""; if (defaults.length > 0) { const storedConfig = defaults.find((element) => element.key === key); @@ -105,12 +105,12 @@ const ConfTargetGeneric = ({ const fieldDefinition = (field: KVField, item: number) => { switch (field.type) { case "on|off": - const value = valueHolder[item] ? valueHolder[item].value : "false"; + const value = valueHolder[item] ? valueHolder[item].value : "off"; return ( ) => { - const value = e.target.checked ? "true" : "false"; + const value = e.target.checked ? "on" : "off"; setValueElement(field.name, value, item); }} id={field.name} @@ -118,7 +118,7 @@ const ConfTargetGeneric = ({ label={field.label} value={"switch_on"} tooltip={field.tooltip} - checked={value === "true"} + checked={value === "on"} /> ); case "csv":