mirrors/object-browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

authenticate websocket apis using sts (#97)

Browse Source
This commit is contained in:
César Nieto
2020-05-06 14:47:49 -07:00
committed by GitHub
parent 511cc47d2b
commit 3bfc2556fc
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
restapi/ws_handle.go
View File

@@ -109,9 +109,8 @@ func (c wsConn) readMessage() (messageType int, p []byte, err error) {
// //
// TODO: Enable CORS // TODO: Enable CORS
func serveWS(w http.ResponseWriter, req *http.Request) { func serveWS(w http.ResponseWriter, req *http.Request) {
// authenticate WS connection // authenticate WS connection with MCS
// TODO: use this claims to create the adminClient claims, err := ws.Authenticate(req)
_, err := ws.Authenticate(req)
if err != nil { if err != nil {
log.Print("error on ws authentication: ", err) log.Print("error on ws authentication: ", err)
errors.ServeError(w, req, err) errors.ServeError(w, req, err)
@@ -126,13 +125,9 @@ func serveWS(w http.ResponseWriter, req *http.Request) {
return return
} }
// TODO: CHANGE ! to use newMAdminClient once Assume Role is
// allowed to do Trace use jwt on ws.
// Using newSuperMAdminClient in the meantime for sake of functionality
// Only start Websocket Interaction after user has been // Only start Websocket Interaction after user has been
// authenticated. // authenticated with MinIO
mAdmin, err := newSuperMAdminClient() mAdmin, err := newAdminFromClaims(claims)
if err != nil { if err != nil {
log.Println("error creating Madmin Client:", err) log.Println("error creating Madmin Client:", err)
errors.ServeError(w, req, err) errors.ServeError(w, req, err)