Table tests for site replication apis (#1944)

This commit is contained in:
Prakash Senthil Vel
2022-05-04 19:40:44 +00:00
committed by GitHub
parent 42beef408c
commit 3c659a29ae

View File

@@ -60,8 +60,75 @@ func makeExecuteReq(method string, body io.Reader) (*http.Response, error) {
return response, nil
}
func AddSiteReplicationInfo() (*http.Response, error) {
func AddSiteReplicationInfo(sites []map[string]interface{}) (int, error) {
requestDataJSON, _ := json.Marshal(sites)
requestDataBody := bytes.NewReader(requestDataJSON)
response, err := makeExecuteReq("POST", requestDataBody)
if err != nil {
log.Println(response)
return -1, err
}
if response != nil {
return response.StatusCode, nil
}
return -1, nil
}
func EditSiteReplicationInfo(editedSite map[string]interface{}) (int, error) {
requestDataJSON, _ := json.Marshal(editedSite)
requestDataBody := bytes.NewReader(requestDataJSON)
response, err := makeExecuteReq("PUT", requestDataBody)
fmt.Println(response, err)
if err != nil {
return -1, err
}
if response != nil {
return response.StatusCode, nil
}
return -1, nil
}
func DeleteSiteReplicationInfo(delReq map[string]interface{}) (int, error) {
requestDataJSON, _ := json.Marshal(delReq)
requestDataBody := bytes.NewReader(requestDataJSON)
response, err := makeExecuteReq("DELETE", requestDataBody)
if err != nil {
log.Println(response)
return -1, err
}
if response != nil {
return response.StatusCode, nil
}
return -1, nil
}
func TestGetSiteReplicationInfo(t *testing.T) {
assert := assert.New(t)
response, err := makeExecuteReq("GET", nil)
tgt := &models.SiteReplicationInfoResponse{}
json.NewDecoder(response.Body).Decode(tgt)
if err != nil {
log.Println(err)
return
}
if response != nil {
assert.Equal(200, response.StatusCode, "Status Code is incorrect")
}
}
func TestAddSiteReplicationInfo(t *testing.T) {
assert := assert.New(t)
fmt.Println("Add Site Replication")
sites := make([]map[string]interface{}, 2)
sites[0] = map[string]interface{}{
"accessKey": "minioadmin",
@@ -71,56 +138,169 @@ func AddSiteReplicationInfo() (*http.Response, error) {
}
sites[1] = map[string]interface{}{
"accessKey": "minioadmin",
"endpoint": "http://minio1:9001",
"endpoint": "http://minio1:9001", //Docker container .
// "endpoint": "http://localhost:9001", for local development
"secretKey": "minioadmin",
"name": "sitellhost9001",
}
requestDataJSON, _ := json.Marshal(sites)
requestDataBody := bytes.NewReader(requestDataJSON)
return makeExecuteReq("POST", requestDataBody)
}
func EditSiteReplicationInfo() (*http.Response, error) {
getResponse, err := makeExecuteReq("GET", nil)
//defer response.Body.Close()
if err != nil {
return nil, err
errorSites1 := make([]map[string]interface{}, 2)
errorSites1[0] = map[string]interface{}{
"accessKey": "minioadmin",
"endpoint": "http://localhost:9000",
"secretKey": "minioadmin",
"name": "sitellhost9000",
}
errorSites1[1] = map[string]interface{}{
"accessKey": "minioadmin",
"endpoint": "http://non-existent:9001",
"secretKey": "minioadmin",
"name": "sitellhost9001",
}
errorSites2 := make([]map[string]interface{}, 2)
errorSites2[0] = map[string]interface{}{
"accessKey": "minioadmin",
"endpoint": "http://localhost:9000",
"secretKey": "minioadmin",
"name": "sitellhost9000",
}
errorSites2[1] = map[string]interface{}{
"accessKey": "minioadmin",
"endpoint": "http://localhost:9000",
"secretKey": "minioadmin",
"name": "sitellhost9000",
}
type args struct {
sites []map[string]interface{}
}
tests := []struct {
name string
args args
expStatusCode int
expectedError bool
}{
// valid sites for replication config
{
name: "Add Two sites for Replication",
args: args{
sites: sites,
},
expStatusCode: 200,
expectedError: false,
},
//context deadline error
{
name: "Add Invalid Site name for Replication",
args: args{
sites: errorSites1,
},
expStatusCode: 0,
expectedError: true,
},
//site already added error 500
{
name: "Add same Site name for Replication",
args: args{
sites: errorSites2,
},
expStatusCode: 500,
expectedError: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
actualStatusCode, err := AddSiteReplicationInfo(tt.args.sites)
fmt.Println("TestAddSiteReplicationInfo: ", actualStatusCode)
if tt.expStatusCode > 0 {
assert.Equal(tt.expStatusCode, actualStatusCode, "Expected Status Code is incorrect")
return
}
if tt.expectedError {
assert.NotEmpty(err)
return
}
})
}
}
func TestEditSiteReplicationInfo(t *testing.T) {
assert := assert.New(t)
getResponse, err := makeExecuteReq("GET", nil)
if err != nil {
assert.Fail("Unable to get Site replication info")
}
getResObj := &models.SiteReplicationInfoResponse{}
json.NewDecoder(getResponse.Body).Decode(getResObj)
//fmt.Println("Edit Got::", getResObj, getResObj.Sites[0], getResObj.Sites[1])
var secondDeploymentID string
if getResObj != nil {
if len(getResObj.Sites) > 0 {
secondDeploymentID = getResObj.Sites[1].DeploymentID
}
} else {
return nil, nil
assert.Fail("Unable to get Site deployment info")
}
fmt.Println("Editing::", getResObj.Sites[1])
fmt.Println("Editing::", secondDeploymentID)
pSiteInfo := map[string]interface{}{
fmt.Println("Edit Site Replication")
fmt.Println("Editing a valid site deployment id::", secondDeploymentID)
updatedSiteInfo := map[string]interface{}{
"deploymentID": secondDeploymentID,
"endpoint": "http://minio2:9002",
"endpoint": "http://minio2:9002", //replace it with docker name
//"endpoint": "http://localhost:9002", //local dev
"name": "sitellhost9002",
}
invalidUpdatedSiteInfo := map[string]interface{}{
"deploymentID": secondDeploymentID,
"endpoint": "non-existenet:9002",
"name": "sitellhost9002",
}
invalidUpdatedSiteInfo1 := map[string]interface{}{}
tests := []struct {
name string
args map[string]interface{}
expStatusCode int
expectedError bool
}{
{
name: "Edit an existing valid site",
args: updatedSiteInfo,
expStatusCode: -1,
expectedError: false,
},
{
name: "Edit with an invalid site endpoint",
args: invalidUpdatedSiteInfo,
expStatusCode: -1,
expectedError: true,
},
{
name: "Edit with an invalid empty site ",
args: invalidUpdatedSiteInfo1,
expStatusCode: 500,
expectedError: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
actualStatusCode, err := EditSiteReplicationInfo(tt.args)
fmt.Println("TestEditSiteReplicationInfo: ", actualStatusCode)
if tt.expStatusCode > 0 {
assert.Equal(tt.expStatusCode, actualStatusCode, "Expected Status Code is incorrect")
return
}
if tt.expectedError {
assert.NotEmpty(err)
return
}
requestDataJSON, _ := json.Marshal(pSiteInfo)
requestDataBody := bytes.NewReader(requestDataJSON)
return makeExecuteReq("PUT", requestDataBody)
})
}
}
func DeleteSiteReplicationInfo() (*http.Response, error) {
func TestDeleteSiteReplicationInfo(t *testing.T) {
assert := assert.New(t)
delReq := map[string]interface{}{
"all": true,
"sites": []string{
@@ -129,89 +309,64 @@ func DeleteSiteReplicationInfo() (*http.Response, error) {
"sitellhost9002",
},
}
requestDataJSON, _ := json.Marshal(delReq)
requestDataBody := bytes.NewReader(requestDataJSON)
return makeExecuteReq("DELETE", requestDataBody)
}
func TestGetSiteReplicationInfo(t *testing.T) {
assert := assert.New(t)
response, err := makeExecuteReq("GET", nil)
//defer response.Body.Close()
tgt := &models.SiteReplicationInfoResponse{}
json.NewDecoder(response.Body).Decode(tgt)
if err != nil {
log.Println(err)
return
invalidDelReq := map[string]interface{}{
"all": false,
"sites": []string{
"sitellhost9000",
},
}
if response != nil {
assert.Equal(200, response.StatusCode, "Status Code is incorrect")
invalidDelReq1 := map[string]interface{}{
"all": true,
"sites": []string{},
}
}
func TestAddSiteReplicationInfo(t *testing.T) {
assert := assert.New(t)
fmt.Println("Add Site Replication")
response, err := AddSiteReplicationInfo()
if err != nil {
log.Println(err)
return
tests := []struct {
name string
args map[string]interface{}
expStatusCode int
expectedError bool
}{
{
name: "Delete Valid Sites already added",
args: delReq,
expStatusCode: 204,
expectedError: false,
},
{
name: "Delete Invalid Sites ",
args: invalidDelReq,
expStatusCode: 500,
expectedError: true,
},
{
name: "Invalid delete request",
args: invalidDelReq1,
expStatusCode: 500,
expectedError: true,
},
}
if response != nil {
assert.Equal(200, response.StatusCode, "Status Code is incorrect")
}
fmt.Println("TestAddSiteReplicationInfo: ", response.StatusCode)
}
func TestEditSiteReplicationInfo(t *testing.T) {
assert := assert.New(t)
response, err := EditSiteReplicationInfo()
if err != nil {
log.Println(err)
return
}
if response != nil {
assert.NotEmpty(response)
assert.Equal(200, response.StatusCode, "Status Code is incorrect")
}
}
func TestDeleteSiteReplicationInfo(t *testing.T) {
assert := assert.New(t)
fmt.Println("Delete Site Replication")
response, err := DeleteSiteReplicationInfo()
if err != nil {
log.Println(err)
return
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
actualStatusCode, err := DeleteSiteReplicationInfo(tt.args)
fmt.Println("TestDeleteSiteReplicationInfo: ", actualStatusCode)
if tt.expStatusCode > 0 {
assert.Equal(tt.expStatusCode, actualStatusCode, "Expected Status Code is incorrect")
return
}
if tt.expectedError {
assert.NotEmpty(err)
return
}
})
}
if response != nil {
assert.Equal(204, response.StatusCode, "Status Code is incorrect")
}
fmt.Println("TestDeleteReplicationInfo: ", response.StatusCode)
}
// Status API
func makeStatusExecuteReq(method string, url string) (*http.Response, error) {
client := &http.Client{
Timeout: 10 * time.Second,
}
request, err := http.NewRequest(
method,
url,
@@ -224,43 +379,101 @@ func makeStatusExecuteReq(method string, url string) (*http.Response, error) {
request.Header.Add("Cookie", fmt.Sprintf("token=%s", token))
request.Header.Add("Content-Type", "application/json")
response, err := client.Do(request)
if err != nil {
return nil, err
}
return response, nil
}
func TestGetSiteReplicationStatus(t *testing.T) {
assert := assert.New(t)
reqUrls := [5]string{
//default
"http://localhost:9090/api/v1/admin/site-replication/status?users=true&groups=true&buckets=true&policies=true",
//specific bucket lookup
"http://localhost:9090/api/v1/admin/site-replication/status?users=false&groups=false&buckets=false&policies=false&entityValue=test-bucket&entityType=bucket",
//specific-user lookup
"http://localhost:9090/api/v1/admin/site-replication/status?users=false&groups=false&buckets=false&policies=false&entityValue=test-user&entityType=user",
//specific-group lookup
"http://localhost:9090/api/v1/admin/site-replication/status?users=false&groups=false&buckets=false&policies=false&entityValue=test-group&entityType=group",
//specific-policy lookup
"http://localhost:9090/api/v1/admin/site-replication/status?users=false&groups=false&buckets=false&policies=false&entityValue=test-policies&entityType=policiy",
const (
baseAPIURL = "http://localhost:9090/api/v1/admin/site-replication/status?"
lookupDefaultParams = "users=false&groups=false&buckets=false&policies=false&"
)
tests := []struct {
name string
args string
expStatusCode int
expectedError bool
}{
{
name: "Default replication status",
args: baseAPIURL + "users=true&groups=true&buckets=true&policies=true",
expStatusCode: 200,
expectedError: false,
},
{
name: "Specific bucket lookup replication status",
args: baseAPIURL + lookupDefaultParams + "entityValue=test-bucket&entityType=bucket",
expStatusCode: 200,
expectedError: false,
},
{
name: "Invalid specific bucket lookup replication status",
args: baseAPIURL + lookupDefaultParams + "entityValue=test-bucket-non-existent&entityType=bucket",
expStatusCode: 200,
expectedError: true,
},
{
name: "Specific user lookup replication status",
args: baseAPIURL + lookupDefaultParams + "entityValue=test-user&entityType=user",
expStatusCode: 200,
expectedError: false,
},
{
name: "Invalid user lookup replication status",
args: baseAPIURL + lookupDefaultParams + "entityValue=test-user-non-existent&entityType=user",
expStatusCode: 200,
expectedError: false,
},
{
name: "Specific group lookup replication status",
args: baseAPIURL + lookupDefaultParams + "entityValue=test-group&entityType=group",
expStatusCode: 200,
expectedError: false,
},
{
name: "Invalid group lookup replication status",
args: baseAPIURL + lookupDefaultParams + "entityValue=test-group-non-existent&entityType=group",
expStatusCode: 200,
expectedError: false,
},
{
name: "Specific policy replication status",
args: baseAPIURL + lookupDefaultParams + "entityValue=consoleAdmin&entityType=policy",
expStatusCode: 200,
expectedError: false,
},
{
name: "Invalid policy replication status",
args: baseAPIURL + lookupDefaultParams + "entityValue=test-policies&entityType=policy",
expStatusCode: 200,
expectedError: false,
},
}
for i, url := range reqUrls {
for ti, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
response, err := makeStatusExecuteReq("GET", tt.args)
tgt := &models.SiteReplicationStatusResponse{}
json.NewDecoder(response.Body).Decode(tgt)
log.Println(err, response)
if err != nil {
log.Println(err)
response, err := makeStatusExecuteReq("GET", url)
if tt.expectedError {
assert.NotEmpty(err)
}
return
}
if response != nil {
assert.Equal(tt.expStatusCode, response.StatusCode, "Status Code for", ti)
}
tgt := &models.SiteReplicationStatusResponse{}
json.NewDecoder(response.Body).Decode(tgt)
if err != nil {
log.Println(err)
return
}
if response != nil {
assert.Equal(200, response.StatusCode, "Status Code for", i)
}
})
}
}