mirrors/object-browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve marketplace test coverage (#2202)

Browse Source 
* Improve marketplace test coverage

* gofumpt
This commit is contained in:
Javier Adriel
2022-07-27 18:33:56 -05:00
committed by GitHub
parent 51a8bacc18
commit 5d25dd4c06
1 changed files with 38 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
operatorapi/marketplace_test.go
View File

@@ -19,7 +19,9 @@ package operatorapi
import ( import (
"context" "context"
"errors" "errors"
"fmt"
"net/http" "net/http"
"net/http/httptest"
"os" "os"
"testing" "testing"
@@ -34,6 +36,7 @@ import (
var ( var (
testWithError = false testWithError = false
testServerWithError = false
errMock = errors.New("mock error") errMock = errors.New("mock error")
k8sClientGetConfigMapMock func(ctx context.Context, namespace, configMap string, opts metav1.GetOptions) (*corev1.ConfigMap, error) k8sClientGetConfigMapMock func(ctx context.Context, namespace, configMap string, opts metav1.GetOptions) (*corev1.ConfigMap, error)
k8sClientCreateConfigMapMock func(ctx context.Context, namespace string, cm *corev1.ConfigMap, opts metav1.CreateOptions) (*corev1.ConfigMap, error) k8sClientCreateConfigMapMock func(ctx context.Context, namespace string, cm *corev1.ConfigMap, opts metav1.CreateOptions) (*corev1.ConfigMap, error)
@@ -43,9 +46,10 @@ var (
type MarketplaceTestSuite struct { type MarketplaceTestSuite struct {
suite.Suite suite.Suite
assert *assert.Assertions assert *assert.Assertions
kClient k8sClientMock kClient k8sClientMock
namespace string namespace string
postServer *httptest.Server
} }
func (c k8sClientMock) getConfigMap(ctx context.Context, namespace, configMap string, opts metav1.GetOptions) (*corev1.ConfigMap, error) { func (c k8sClientMock) getConfigMap(ctx context.Context, namespace, configMap string, opts metav1.GetOptions) (*corev1.ConfigMap, error) {
@@ -72,6 +76,17 @@ func (suite *MarketplaceTestSuite) SetupSuite() {
k8sClientUpdateConfigMapMock = suite.updateConfigMapMock k8sClientUpdateConfigMapMock = suite.updateConfigMapMock
k8sClientDeleteConfigMapMock = suite.deleteConfigMapMock k8sClientDeleteConfigMapMock = suite.deleteConfigMapMock
os.Setenv(mpConfigMapKey, "mp-mock-config") os.Setenv(mpConfigMapKey, "mp-mock-config")
suite.postServer = httptest.NewServer(http.HandlerFunc(suite.postHandler))
}
func (suite *MarketplaceTestSuite) postHandler(
w http.ResponseWriter, r *http.Request,
) {
if testServerWithError {
w.WriteHeader(400)
} else {
fmt.Fprintf(w, `{"post": "Post response"}`)
}
} }
func (suite *MarketplaceTestSuite) TearDownSuite() { func (suite *MarketplaceTestSuite) TearDownSuite() {
@@ -173,14 +188,26 @@ func (suite *MarketplaceTestSuite) TestSetMPIntegrationWithError() {
os.Unsetenv(mpHostEnvVar) os.Unsetenv(mpHostEnvVar)
} }
// TODO: Add mock server for testing microservice func (suite *MarketplaceTestSuite) TestSetMPIntegrationNoError() {
// func (suite *MarketplaceTestSuite) TestSetMPIntegrationNoError() { testWithError = false
// testWithError = false ctx, cancel := context.WithCancel(context.Background())
// ctx, cancel := context.WithCancel(context.Background()) defer cancel()
// defer cancel() os.Setenv(mpHostEnvVar, suite.postServer.URL)
// err := setMPIntegration(ctx, "mock@mock.com", "token", &suite.kClient) err := setMPIntegration(ctx, "mock@mock.com", false, &suite.kClient)
// suite.assert.Nil(err) suite.assert.Nil(err)
// } os.Unsetenv(mpHostEnvVar)
}
func (suite *MarketplaceTestSuite) TestSetMPIntegrationWithRequestError() {
testWithError = false
testServerWithError = true
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
os.Setenv(mpHostEnvVar, suite.postServer.URL)
err := setMPIntegration(ctx, "mock@mock.com", false, &suite.kClient)
suite.assert.NotNil(err)
os.Unsetenv(mpHostEnvVar)
}
func TestMarketplace(t *testing.T) { func TestMarketplace(t *testing.T) {
suite.Run(t, new(MarketplaceTestSuite)) suite.Run(t, new(MarketplaceTestSuite))