From 7f05c0bf06e7c54c767d11aa5660553dc93b9093 Mon Sep 17 00:00:00 2001 From: Cesar Celis Hernandez Date: Sat, 5 Feb 2022 12:26:33 -0500 Subject: [PATCH] Convert to table driven test (#1506) --- integration/buckets_test.go | 47 ++++++++++++++++++++++++++++++------- 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/integration/buckets_test.go b/integration/buckets_test.go index fd7afada9..80d1d2a9f 100644 --- a/integration/buckets_test.go +++ b/integration/buckets_test.go @@ -545,16 +545,45 @@ func ListObjects(bucketName string, prefix string) (*http.Response, error) { func TestAddBucket(t *testing.T) { assert := assert.New(t) - - response, err := AddBucket("test1", false, false, nil, nil) - assert.Nil(err) - if err != nil { - log.Println(err) - return + type args struct { + bucketName string } - - if response != nil { - assert.Equal(201, response.StatusCode, "Status Code is incorrect") + tests := []struct { + name string + args args + expectedStatus int + }{ + { + name: "Add Bucket with valid name", + expectedStatus: 201, + args: args{ + bucketName: "test1", + }, + }, + { + name: "Add Bucket with invalid name", + expectedStatus: 500, + args: args{ + bucketName: "*&^###Test1ThisMightBeInvalid555", + }, + }, + } + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + response, err := AddBucket( + tt.args.bucketName, false, false, nil, nil) + assert.Nil(err) + if err != nil { + log.Println(err) + assert.Fail("Error while adding the bucket") + return + } + finalResponse := inspectHTTPResponse(response) + if response != nil { + assert.Equal(tt.expectedStatus, + response.StatusCode, finalResponse) + } + }) } }