Add Insecure parameter to NewAdminClient function (#224)

When using the madmin client, for some operations such as health checks against a MinIO instnace with TLS we need a client with insecure turned on.
This commit is contained in:
Daniel Valdivia
2020-08-02 12:21:21 -07:00
committed by GitHub
parent 3760c783d0
commit 7ff009ec43

View File

@@ -33,8 +33,13 @@ import (
const globalAppName = "console" const globalAppName = "console"
// NewAdminClient gives a new client interface // NewAdminClient gives a new madmin client interface
func NewAdminClient(url, accessKey, secretKey string) (*madmin.AdminClient, *probe.Error) { func NewAdminClient(url, accessKey, secretKey string) (*madmin.AdminClient, *probe.Error) {
return NewAdminClientWithInsecure(url, accessKey, secretKey, false)
}
// NewAdminClientWithInsecure gives a new madmin client interface either secure or insecure based on parameter
func NewAdminClientWithInsecure(url, accessKey, secretKey string, insecure bool) (*madmin.AdminClient, *probe.Error) {
appName := filepath.Base(globalAppName) appName := filepath.Base(globalAppName)
s3Client, err := s3AdminNew(&mcCmd.Config{ s3Client, err := s3AdminNew(&mcCmd.Config{
@@ -44,7 +49,7 @@ func NewAdminClient(url, accessKey, secretKey string) (*madmin.AdminClient, *pro
AppName: appName, AppName: appName,
AppVersion: ConsoleVersion, AppVersion: ConsoleVersion,
AppComments: []string{appName, runtime.GOOS, runtime.GOARCH}, AppComments: []string{appName, runtime.GOOS, runtime.GOARCH},
Insecure: false, Insecure: insecure,
}) })
if err != nil { if err != nil {
return nil, err.Trace(url) return nil, err.Trace(url)