mirrors/object-browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed WS reconnection logic onError and onClose (#2591)

Browse Source 
Removes duplicated reconnection request when error is reached on Object
Browser websocket, also removed the use of the connect call back as it
will contain references to the initial request and it is not necessary
as we already have information available.

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
This commit is contained in:
Alex
2023-01-23 20:43:52 -06:00
committed by GitHub
parent a01b855d2f
commit 87399d1064
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
portal-ui/src/screens/Console/Buckets/BucketDetails/BrowserHandler.tsx
View File

@@ -121,7 +121,7 @@ const initWSConnection = (
const reconnectFn = () => { const reconnectFn = () => {
if (errorCounter <= 5) { if (errorCounter <= 5) {
initWSConnection(openCallback, onMessageCallback); initWSConnection(() => {}, onMessageCallback);
errorCounter += 1; errorCounter += 1;
} else { } else {
console.error("Websocket not available."); console.error("Websocket not available.");
@@ -139,9 +139,7 @@ const initWSConnection = (
objectsWS.onerror = () => { objectsWS.onerror = () => {
wsInFlight = false; wsInFlight = false;
console.error("Error in websocket connection. Attempting reconnection..."); console.error("Error in websocket connection. Attempting reconnection...");
// Onclose will be triggered by specification, reconnect function will be executed there to avoid duplicated requests
// We reconnect after 3 seconds
setTimeout(reconnectFn, 3000);
}; };
}; };