From d6f97841d4535561ba494ad68a78b2077ce18e5a Mon Sep 17 00:00:00 2001 From: Lenin Alevski Date: Tue, 27 Oct 2020 10:05:16 -0700 Subject: [PATCH] return generic login error when invalid credentials (#350) --- restapi/user_login.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/restapi/user_login.go b/restapi/user_login.go index 486d5884a..bcb9b7537 100644 --- a/restapi/user_login.go +++ b/restapi/user_login.go @@ -99,25 +99,25 @@ func getLoginResponse(lr *models.LoginRequest) (*models.LoginResponse, *models.E ctx := context.Background() mAdmin, err := newSuperMAdminClient() if err != nil { - return nil, prepareError(err) + return nil, prepareError(err, errorGeneric) } adminClient := adminClient{client: mAdmin} // obtain the configured MinIO region // need it for user authentication location, err := getConfiguredRegionForLogin(adminClient) if err != nil { - return nil, prepareError(err) + return nil, prepareError(err, errorGeneric) } creds, err := newConsoleCredentials(*lr.AccessKey, *lr.SecretKey, location) if err != nil { - return nil, prepareError(err) + return nil, prepareError(err, errInvalidCredentials) } credentials := consoleCredentials{consoleCredentials: creds} // obtain the current policy assigned to this user // necessary for generating the list of allowed endpoints userInfo, err := adminClient.getUserInfo(ctx, *lr.AccessKey) if err != nil { - return nil, prepareError(err) + return nil, prepareError(err, errorGeneric) } policy, _ := adminClient.getPolicy(ctx, userInfo.PolicyName) // by default every user starts with an empty array of available actions