From d956ec65a2f1a9bf19e7b3807c550a054840a0a0 Mon Sep 17 00:00:00 2001 From: Cesar Celis Hernandez Date: Tue, 31 May 2022 15:42:16 -0400 Subject: [PATCH] Cover errors in registerAdminArnsHandlers (#2059) To cover errors in registerAdminArnsHandlers --- .github/workflows/jobs.yaml | 2 +- restapi/admin_arns_test.go | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/.github/workflows/jobs.yaml b/.github/workflows/jobs.yaml index e6d9932f2..23ac36b3b 100644 --- a/.github/workflows/jobs.yaml +++ b/.github/workflows/jobs.yaml @@ -1521,7 +1521,7 @@ jobs: go tool cover -func=all.out | grep total > tmp2 result=`cat tmp2 | awk 'END {print $3}'` result=${result%\%} - threshold=50.6 + threshold=50.7 echo "Result:" echo "$result%" if (( $(echo "$result >= $threshold" |bc -l) )); then diff --git a/restapi/admin_arns_test.go b/restapi/admin_arns_test.go index a97e9cf93..ce620ebe3 100644 --- a/restapi/admin_arns_test.go +++ b/restapi/admin_arns_test.go @@ -20,8 +20,14 @@ import ( "context" "errors" "fmt" + "net/http" + "strings" "testing" + "github.com/go-openapi/runtime/middleware" + "github.com/minio/console/models" + "github.com/minio/console/restapi/operations/system" + "github.com/go-openapi/loads" "github.com/minio/console/restapi/operations" "github.com/minio/madmin-go" @@ -71,4 +77,21 @@ func TestRegisterAdminArnsHandlers(t *testing.T) { } else { fmt.Println("Function got assigned: ", api.SystemArnListHandler) } + + // To test error case in registerAdminArnsHandlers + request, _ := http.NewRequest( + "GET", + "http://localhost:9090/api/v1/buckets/", + nil, + ) + ArnListParamsStruct := system.ArnListParams{ + HTTPRequest: request, + } + modelsPrincipal := models.Principal{ + STSAccessKeyID: "accesskey", + } + var value middleware.Responder = api.SystemArnListHandler.Handle(ArnListParamsStruct, &modelsPrincipal) + str := fmt.Sprintf("%#v", value) + fmt.Println("value: ", str) + assert.Equal(strings.Contains(str, "_statusCode:500"), true) }