Previously every Handler function was receiving the session token in the form of a jwt string, in consequence every time we want to access the encrypted claims of the jwt we needed to run a decryption process, additionally we were decrypting the jwt twice, first at the session validation then inside each handler function, this was also causing a lot of using related to the merge between m3 and mcs What changed: Now we validate and decrypt the jwt once in `configure_mcs.go`, this works for both, mcs (console) and operator sessions, and then pass the decrypted claims to all the functions that need it, so no further token validation or decryption is need it.
202 lines
7.0 KiB
Go
202 lines
7.0 KiB
Go
// This file is part of MinIO Console Server
|
|
// Copyright (c) 2020 MinIO, Inc.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package restapi
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"log"
|
|
"strings"
|
|
|
|
"github.com/go-openapi/runtime/middleware"
|
|
"github.com/go-openapi/swag"
|
|
"github.com/minio/mcs/models"
|
|
"github.com/minio/mcs/restapi/operations"
|
|
madmin "github.com/minio/minio/pkg/madmin"
|
|
|
|
"github.com/minio/mcs/restapi/operations/admin_api"
|
|
)
|
|
|
|
func registerConfigHandlers(api *operations.McsAPI) {
|
|
// List Configurations
|
|
api.AdminAPIListConfigHandler = admin_api.ListConfigHandlerFunc(func(params admin_api.ListConfigParams, session *models.Principal) middleware.Responder {
|
|
configListResp, err := getListConfigResponse(session)
|
|
if err != nil {
|
|
return admin_api.NewListConfigDefault(500).WithPayload(&models.Error{Code: 500, Message: swag.String(err.Error())})
|
|
}
|
|
return admin_api.NewListConfigOK().WithPayload(configListResp)
|
|
})
|
|
// Configuration Info
|
|
api.AdminAPIConfigInfoHandler = admin_api.ConfigInfoHandlerFunc(func(params admin_api.ConfigInfoParams, session *models.Principal) middleware.Responder {
|
|
config, err := getConfigResponse(session, params)
|
|
if err != nil {
|
|
return admin_api.NewConfigInfoDefault(500).WithPayload(&models.Error{Code: 500, Message: swag.String(err.Error())})
|
|
}
|
|
return admin_api.NewConfigInfoOK().WithPayload(config)
|
|
})
|
|
// Set Configuration
|
|
api.AdminAPISetConfigHandler = admin_api.SetConfigHandlerFunc(func(params admin_api.SetConfigParams, session *models.Principal) middleware.Responder {
|
|
if err := setConfigResponse(session, params.Name, params.Body); err != nil {
|
|
return admin_api.NewSetConfigDefault(500).WithPayload(&models.Error{Code: 500, Message: swag.String(err.Error())})
|
|
}
|
|
return admin_api.NewSetConfigNoContent()
|
|
})
|
|
}
|
|
|
|
// listConfig gets all configurations' names and their descriptions
|
|
func listConfig(client MinioAdmin) ([]*models.ConfigDescription, error) {
|
|
ctx := context.Background()
|
|
configKeysHelp, err := client.helpConfigKV(ctx, "", "", false)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
var configDescs []*models.ConfigDescription
|
|
for _, c := range configKeysHelp.KeysHelp {
|
|
desc := &models.ConfigDescription{
|
|
Key: c.Key,
|
|
Description: c.Description,
|
|
}
|
|
configDescs = append(configDescs, desc)
|
|
}
|
|
return configDescs, nil
|
|
}
|
|
|
|
// getListConfigResponse performs listConfig() and serializes it to the handler's output
|
|
func getListConfigResponse(session *models.Principal) (*models.ListConfigResponse, error) {
|
|
mAdmin, err := newMAdminClient(session)
|
|
if err != nil {
|
|
log.Println("error creating Madmin Client:", err)
|
|
return nil, err
|
|
}
|
|
// create a MinIO Admin Client interface implementation
|
|
// defining the client to be used
|
|
adminClient := adminClient{client: mAdmin}
|
|
|
|
configDescs, err := listConfig(adminClient)
|
|
if err != nil {
|
|
log.Println("error listing configurations:", err)
|
|
return nil, err
|
|
}
|
|
listGroupsResponse := &models.ListConfigResponse{
|
|
Configurations: configDescs,
|
|
Total: int64(len(configDescs)),
|
|
}
|
|
return listGroupsResponse, nil
|
|
}
|
|
|
|
// getConfig gets the key values for a defined configuration
|
|
func getConfig(client MinioAdmin, name string) ([]*models.ConfigurationKV, error) {
|
|
ctx := context.Background()
|
|
|
|
configKeysHelp, err := client.helpConfigKV(ctx, name, "", false)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
configBytes, err := client.getConfigKV(ctx, name)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
target, err := madmin.ParseSubSysTarget(configBytes, configKeysHelp)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if len(target.KVS) > 0 {
|
|
// return Key Values, first element contains info
|
|
var confkv []*models.ConfigurationKV
|
|
for _, kv := range target.KVS {
|
|
confkv = append(confkv, &models.ConfigurationKV{Key: kv.Key, Value: kv.Value})
|
|
}
|
|
return confkv, nil
|
|
}
|
|
return nil, fmt.Errorf("error retrieving configuration for: %s", name)
|
|
}
|
|
|
|
// getConfigResponse performs getConfig() and serializes it to the handler's output
|
|
func getConfigResponse(session *models.Principal, params admin_api.ConfigInfoParams) (*models.Configuration, error) {
|
|
mAdmin, err := newMAdminClient(session)
|
|
if err != nil {
|
|
log.Println("error creating Madmin Client:", err)
|
|
return nil, err
|
|
}
|
|
// create a MinIO Admin Client interface implementation
|
|
// defining the client to be used
|
|
adminClient := adminClient{client: mAdmin}
|
|
|
|
configkv, err := getConfig(adminClient, params.Name)
|
|
if err != nil {
|
|
log.Println("error getting configuration:", err)
|
|
return nil, err
|
|
}
|
|
configurationObj := &models.Configuration{
|
|
Name: params.Name,
|
|
KeyValues: configkv,
|
|
}
|
|
return configurationObj, nil
|
|
}
|
|
|
|
// setConfig sets a configuration with the defined key values
|
|
func setConfig(ctx context.Context, client MinioAdmin, configName *string, kvs []*models.ConfigurationKV) error {
|
|
config := buildConfig(configName, kvs)
|
|
if err := client.setConfigKV(ctx, *config); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func setConfigWithARNAccountID(ctx context.Context, client MinioAdmin, configName *string, kvs []*models.ConfigurationKV, arnAccountID string) error {
|
|
// if arnAccountID is not empty the configuration will be treated as a notification target
|
|
// arnAccountID will be used as an identifier for that specific target
|
|
// docs: https://docs.min.io/docs/minio-bucket-notification-guide.html
|
|
if arnAccountID != "" {
|
|
configName = swag.String(fmt.Sprintf("%s:%s", *configName, arnAccountID))
|
|
}
|
|
return setConfig(ctx, client, configName, kvs)
|
|
}
|
|
|
|
// buildConfig builds a concatenated string including name and keyvalues
|
|
// e.g. `region name=us-west-1`
|
|
func buildConfig(configName *string, kvs []*models.ConfigurationKV) *string {
|
|
configElements := []string{*configName}
|
|
for _, kv := range kvs {
|
|
configElements = append(configElements, fmt.Sprintf("%s=%s", kv.Key, kv.Value))
|
|
}
|
|
config := strings.Join(configElements, " ")
|
|
return &config
|
|
}
|
|
|
|
// setConfigResponse implements setConfig() to be used by handler
|
|
func setConfigResponse(session *models.Principal, name string, configRequest *models.SetConfigRequest) error {
|
|
mAdmin, err := newMAdminClient(session)
|
|
if err != nil {
|
|
log.Println("error creating Madmin Client:", err)
|
|
return err
|
|
}
|
|
// create a MinIO Admin Client interface implementation
|
|
// defining the client to be used
|
|
adminClient := adminClient{client: mAdmin}
|
|
configName := name
|
|
|
|
ctx := context.Background()
|
|
|
|
if err := setConfigWithARNAccountID(ctx, adminClient, &configName, configRequest.KeyValues, configRequest.ArnResourceID); err != nil {
|
|
log.Println("error listing configurations:", err)
|
|
return err
|
|
}
|
|
return nil
|
|
}
|