697bc4cd1d
Previously every Handler function was receiving the session token in the form of a jwt string, in consequence every time we want to access the encrypted claims of the jwt we needed to run a decryption process, additionally we were decrypting the jwt twice, first at the session validation then inside each handler function, this was also causing a lot of using related to the merge between m3 and mcs What changed: Now we validate and decrypt the jwt once in `configure_mcs.go`, this works for both, mcs (console) and operator sessions, and then pass the decrypted claims to all the functions that need it, so no further token validation or decryption is need it.
94 lines
3.3 KiB
Go
94 lines
3.3 KiB
Go
// This file is part of MinIO Console Server
|
|
// Copyright (c) 2020 MinIO, Inc.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package auth
|
|
|
|
import (
|
|
"context"
|
|
"log"
|
|
|
|
"github.com/minio/mcs/cluster"
|
|
"github.com/minio/minio-go/v6/pkg/credentials"
|
|
operatorClientset "github.com/minio/minio-operator/pkg/client/clientset/versioned"
|
|
)
|
|
|
|
// operatorCredentialsProvider is an struct to hold the JWT (service account token)
|
|
type operatorCredentialsProvider struct {
|
|
serviceAccountJWT string
|
|
}
|
|
|
|
// Implementing the interfaces of the minio Provider, we use this to leverage on the existing mcs Authentication flow
|
|
func (s operatorCredentialsProvider) Retrieve() (credentials.Value, error) {
|
|
return credentials.Value{
|
|
AccessKeyID: "",
|
|
SecretAccessKey: "",
|
|
SessionToken: s.serviceAccountJWT,
|
|
}, nil
|
|
}
|
|
|
|
// IsExpired dummy function, must be implemented in order to work with the minio provider authentication
|
|
func (s operatorCredentialsProvider) IsExpired() bool {
|
|
return false
|
|
}
|
|
|
|
// OperatorClient interface with all functions to be implemented
|
|
// by mock when testing, it should include all OperatorClient respective api calls
|
|
// that are used within this project.
|
|
type OperatorClient interface {
|
|
Authenticate(context.Context) ([]byte, error)
|
|
}
|
|
|
|
// Interface implementation
|
|
//
|
|
// Define the structure of a operator client and define the functions that are actually used
|
|
// from the minio-operator.
|
|
type operatorClient struct {
|
|
client *operatorClientset.Clientset
|
|
}
|
|
|
|
// Authenticate implements the operator authenticate function via REST /api
|
|
func (c *operatorClient) Authenticate(ctx context.Context) ([]byte, error) {
|
|
return c.client.RESTClient().Verb("GET").RequestURI("/api").DoRaw(ctx)
|
|
}
|
|
|
|
// isServiceAccountTokenValid will make an authenticated request against kubernetes api, if the
|
|
// request success means the provided jwt its a valid service account token and the MCS user can use it for future
|
|
// requests until it expires
|
|
func isServiceAccountTokenValid(ctx context.Context, operatorClient OperatorClient) bool {
|
|
_, err := operatorClient.Authenticate(ctx)
|
|
if err != nil {
|
|
log.Println(err)
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
|
|
// GetMcsCredentialsForOperator will validate the provided JWT (service account token) and return it in the form of credentials.Credentials
|
|
func GetMcsCredentialsForOperator(jwt string) (*credentials.Credentials, error) {
|
|
ctx := context.Background()
|
|
opClientClientSet, err := cluster.OperatorClient(jwt)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
opClient := &operatorClient{
|
|
client: opClientClientSet,
|
|
}
|
|
if isServiceAccountTokenValid(ctx, opClient) {
|
|
return credentials.New(operatorCredentialsProvider{serviceAccountJWT: jwt}), nil
|
|
}
|
|
return nil, errInvalidCredentials
|
|
}
|