From 43937eb4544799b79e49365bfdf587a2e12ffff4 Mon Sep 17 00:00:00 2001
From: Adrien Beraud <adrien.beraud@savoirfairelinux.com>
Date: Thu, 8 Oct 2026 08:36:03 -0400
Subject: [PATCH] tests: cover deferred cached readiness lifecycle

---
 tests/test_dhtproxy_client.cpp | 63 ++++++++++++++++++++++++++++++++++
 tests/test_dhtproxy_client.h   |  2 ++
 2 files changed, 65 insertions(+)

diff --git a/tests/test_dhtproxy_client.cpp b/tests/test_dhtproxy_client.cpp
index 40522806..b7221fa2 100644
--- a/tests/test_dhtproxy_client.cpp
+++ b/tests/test_dhtproxy_client.cpp
@@ -116,6 +116,69 @@ DhtProxyClientTester::testReadinessReentrancy()
     CPPUNIT_ASSERT(results == std::vector<bool>({true}));
 }
 
+void
+DhtProxyClientTester::testCachedReadinessDispatch()
+{
+    for (unsigned action = 0; action < 3; ++action) {
+        DhtProxyClient client({}, {}, [] {}, "", "OpenDHT-Test", "client-id", "");
+        client.httpContext_.stop();
+        client.httpClientThread_.join();
+        client.proxyUrl_ = "http://127.0.0.1:1";
+        auto key = InfoHash::get("cached-readiness-dispatch");
+        auto values = [](const std::vector<Sp<Value>>&, bool) {
+            return true;
+        };
+        auto first = client.listen(key, values, {}, {});
+        CPPUNIT_ASSERT(first != 0);
+        auto value = std::make_shared<Value>("cached");
+        value->id = 42;
+        auto request = client.searches_.at(key).listeners.begin()->second.request;
+        auto body = Json::writeString(client.jsonBuilder_, value->toJson()) + "\n{\"sync\":{\"complete\":true}}\n";
+        request->cbs_.on_body(body.data(), body.size());
+        client.periodic(nullptr, 0, {}, clock::now());
+        CPPUNIT_ASSERT(client.getLocalById(key, 42));
+
+        std::vector<bool> results;
+        size_t delivered = 0;
+        auto attached = client.listen(
+            key,
+            [&](const std::vector<Sp<Value>>& cached, bool expired) {
+                if (!expired)
+                    delivered += cached.size();
+                return true;
+            },
+            {},
+            {},
+            [&](bool ok) {
+                results.emplace_back(ok);
+                if (ok) {
+                    CPPUNIT_ASSERT(client.getLocalById(key, 42));
+                    auto nested = client.listen(key, values, {}, {});
+                    CPPUNIT_ASSERT(nested != 0);
+                    CPPUNIT_ASSERT(client.cancelListen(key, nested));
+                } else
+                    CPPUNIT_ASSERT(client.getLocal(key, {}).empty());
+            });
+        CPPUNIT_ASSERT(attached != 0);
+        CPPUNIT_ASSERT_EQUAL(size_t(1), delivered);
+        CPPUNIT_ASSERT(results.empty());
+        CPPUNIT_ASSERT_EQUAL(size_t(1), client.readinessCallbacks_.size());
+        if (action == 1)
+            CPPUNIT_ASSERT(client.cancelListen(key, attached));
+        else if (action == 2) {
+            client.shutdown({}, true);
+            CPPUNIT_ASSERT(results == std::vector<bool>({false}));
+        }
+        client.periodic(nullptr, 0, {}, clock::now());
+        if (action == 1)
+            CPPUNIT_ASSERT(results.empty());
+        else
+            CPPUNIT_ASSERT(results == std::vector<bool>({action == 0}));
+        client.shutdown({}, true);
+        CPPUNIT_ASSERT_EQUAL(action == 1 ? size_t(0) : size_t(1), results.size());
+    }
+}
+
 void
 DhtProxyClientTester::testReadinessCancelsAnotherListener()
 {
diff --git a/tests/test_dhtproxy_client.h b/tests/test_dhtproxy_client.h
index 47c2895a..c98c34c6 100644
--- a/tests/test_dhtproxy_client.h
+++ b/tests/test_dhtproxy_client.h
@@ -15,6 +15,7 @@ class DhtProxyClientTester : public CppUnit::TestFixture
     CPPUNIT_TEST(testRestartListenersFetchesValuesAfterFailedSubscribe);
     CPPUNIT_TEST(testReadinessShutdown);
     CPPUNIT_TEST(testReadinessReentrancy);
+    CPPUNIT_TEST(testCachedReadinessDispatch);
     CPPUNIT_TEST(testReadinessCancelsAnotherListener);
 #ifdef OPENDHT_PUSH_NOTIFICATIONS
     CPPUNIT_TEST(testInitialReadinessFailures);
@@ -50,6 +51,7 @@ public:
     void testRestartListenersFetchesValuesAfterFailedSubscribe();
     void testReadinessShutdown();
     void testReadinessReentrancy();
+    void testCachedReadinessDispatch();
     void testReadinessCancelsAnotherListener();
 #ifdef OPENDHT_PUSH_NOTIFICATIONS
     void testInitialReadinessFailures();