From d12f9271b8f8aafc87387729e03fc445a03c5ea7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adrien=20B=C3=A9raud?= <>
Date: Mon, 22 Sep 2025 14:24:20 -0400
Subject: [PATCH] pht: use const reference for IndexEntry::TYPE

Prevents static initialization order issue
---
 include/opendht/indexation/pht.h | 2 +-
 src/indexation/pht.cpp           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/opendht/indexation/pht.h b/include/opendht/indexation/pht.h
index ba1cb364..a1da0d78 100644
--- a/include/opendht/indexation/pht.h
+++ b/include/opendht/indexation/pht.h
@@ -266,7 +266,7 @@ private:
 
 using Value = std::pair<InfoHash, dht::Value::Id>;
 struct OPENDHT_PUBLIC IndexEntry : public dht::Value::Serializable<IndexEntry> {
-    static const ValueType TYPE;
+    static const ValueType& TYPE;
 
     virtual void unpackValue(const dht::Value& v) {
         Serializable<IndexEntry>::unpackValue(v);
diff --git a/src/indexation/pht.cpp b/src/indexation/pht.cpp
index 67adbc79..b452bdf5 100644
--- a/src/indexation/pht.cpp
+++ b/src/indexation/pht.cpp
@@ -145,7 +145,7 @@ int Pht::Cache::lookup(const Prefix& p) {
     return pos;
 }
 
-const ValueType IndexEntry::TYPE = ValueType::USER_DATA;
+const ValueType& IndexEntry::TYPE = ValueType::USER_DATA;
 constexpr std::chrono::minutes Pht::Cache::NODE_EXPIRE_TIME;
 
 void Pht::lookupStep(Prefix p, std::shared_ptr<int> lo, std::shared_ptr<int> hi,