From f0d039b4a02e943ee8ed76ee8e56e8a452c31385 Mon Sep 17 00:00:00 2001 From: Adrien Beraud Date: Sun, 25 Oct 2026 17:22:13 -0400 Subject: [PATCH] tests: keep persisted transport paths as filesystem paths --- tests/test_dhtrunner.cpp | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/test_dhtrunner.cpp b/tests/test_dhtrunner.cpp index b6b52e93..b391414c 100644 --- a/tests/test_dhtrunner.cpp +++ b/tests/test_dhtrunner.cpp @@ -1753,14 +1753,15 @@ DhtRunnerTransportTester::testNodeIdFromTransportKey() void DhtRunnerTransportTester::testPersistedTransportKey() { - const auto path = (std::filesystem::temp_directory_path() - / ("opendht_test_transport_state_" + dht::InfoHash::getRandom().toString())).string(); - const auto previous = path + ".previous"; - std::remove(path.c_str()); - std::remove(previous.c_str()); + const auto path = std::filesystem::temp_directory_path() + / ("opendht_test_transport_state_" + dht::InfoHash::getRandom().toString()); + auto previous = path; + previous += ".previous"; + std::filesystem::remove(path); + std::filesystem::remove(previous); auto runNode = [&](const dht::TransportConfig& transport) { auto config = transportTestConfig(transport); - config.dht_config.node_config.persist_path = path; + config.dht_config.node_config.persist_path = path.string(); dht::DhtRunner node; node.run(0, config); auto id = node.getNodeId(); @@ -1801,8 +1802,8 @@ DhtRunnerTransportTester::testPersistedTransportKey() CPPUNIT_ASSERT(not std::filesystem::is_symlink(path)); CPPUNIT_ASSERT_EQUAL(previousSize, std::filesystem::file_size(previous)); #endif - std::remove(path.c_str()); - std::remove(previous.c_str()); + std::filesystem::remove(path); + std::filesystem::remove(previous); } void