mirror of
https://github.com/savoirfairelinux/opendht.git
synced 2026-11-08 04:21:51 +00:00
Cyrille BéraudandCopilot
9b9056c0c8
Query::isSatisfiedBy() considers an unfiltered answer sufficient for a filtered query, which is true for a vanilla get: onGetValuesDone() applies the operation filter to the values before calling back. A projected query is different. It receives the fields another query selected and can no longer evaluate its own filters on them, all the more so as those filters may target fields that were not selected at all. Two concurrent queries such as "SELECT id" and "SELECT id WHERE value_type=1" therefore made the filtered callback report identifiers whose type does not match, and searchNodeGetDone() additionally cancelled its own request so it never got a correctly filtered answer. Add Query::isProjectionSatisfiedBy(), which additionally requires both queries to apply the same filters, and use it for operations with a query callback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
58 lines
1.6 KiB
C++
58 lines
1.6 KiB
C++
// Copyright (c) 2014-2026 Savoir-faire Linux Inc.
|
|
// SPDX-License-Identifier: MIT
|
|
#pragma once
|
|
|
|
// cppunit
|
|
#include <cppunit/TestFixture.h>
|
|
#include <cppunit/extensions/HelperMacros.h>
|
|
|
|
namespace test {
|
|
|
|
class ValueTester : public CppUnit::TestFixture
|
|
{
|
|
CPPUNIT_TEST_SUITE(ValueTester);
|
|
CPPUNIT_TEST(testConstructors);
|
|
CPPUNIT_TEST(testFilter);
|
|
CPPUNIT_TEST(testSequenceFilterMsgpackRoundTrip);
|
|
CPPUNIT_TEST(testPushTypeMsgpackRoundTrip);
|
|
CPPUNIT_TEST(testPushTypeAbsentAfterUnpack);
|
|
CPPUNIT_TEST(testPushTypePreservedAfterEncrypt);
|
|
CPPUNIT_TEST(testPushTypeJsonRoundTrip);
|
|
CPPUNIT_TEST(testFieldValueIndexContainedIn);
|
|
CPPUNIT_TEST(testProjectionSatisfiedBy);
|
|
CPPUNIT_TEST_SUITE_END();
|
|
|
|
public:
|
|
/**
|
|
* Method automatically called before each test by CppUnit
|
|
*/
|
|
void setUp();
|
|
/**
|
|
* Method automatically called after each test CppUnit
|
|
*/
|
|
void tearDown();
|
|
/**
|
|
* Test the differents behaviors of constructors
|
|
*/
|
|
void testConstructors();
|
|
/**
|
|
* Test compare operators
|
|
*/
|
|
void testFilter();
|
|
void testSequenceFilterMsgpackRoundTrip();
|
|
void testPushTypeMsgpackRoundTrip();
|
|
void testPushTypeAbsentAfterUnpack();
|
|
void testPushTypePreservedAfterEncrypt();
|
|
void testPushTypeJsonRoundTrip();
|
|
/**
|
|
* Test that projected index containment compares field values, not only keys
|
|
*/
|
|
void testFieldValueIndexContainedIn();
|
|
/**
|
|
* Test that a projected query only reuses answers filtered exactly like it
|
|
*/
|
|
void testProjectionSatisfiedBy();
|
|
};
|
|
|
|
} // namespace test
|