Refactor logLines to SplitByNewline, deduplicate

internal/testutil/conciergetestutil/tlstestutil.go

@@ -11,7 +11,7 @@ import (
 	auth1alpha1 "go.pinniped.dev/generated/latest/apis/concierge/authentication/v1alpha1"
 )
 
-func TlsSpecFromTLSConfig(tls *tls.Config) *auth1alpha1.TLSSpec {
+func TLSSpecFromTLSConfig(tls *tls.Config) *auth1alpha1.TLSSpec {
 	pemData := make([]byte, 0)
 	for _, certificate := range tls.Certificates {
 		// this is the public part of the certificate, the private is the certificate.PrivateKey

internal/testutil/stringutil/stringutil.go

@@ -1,11 +1,11 @@
 // Copyright 2024 the Pinniped contributors. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-package testlogger
+package stringutil
 
 import "strings"
 
-func LogLines(logs string) []string {
+func SplitByNewline(logs string) []string {
 	if len(logs) == 0 {
 		return nil
 	}