plog.TestLogger returns a buffer instead of taking one in

This commit is contained in:
Joshua Casey
2024-11-07 17:46:01 -06:00
parent dc86c9305c
commit 0c131f11f8
17 changed files with 52 additions and 86 deletions
@@ -4,7 +4,6 @@
package webhookcachefiller
import (
"bytes"
"context"
"crypto/tls"
"encoding/base64"
@@ -2128,8 +2127,7 @@ func TestController(t *testing.T) {
kubeInformers := kubeinformers.NewSharedInformerFactory(kubernetesfake.NewSimpleClientset(tt.secretsAndConfigMaps...), 0)
cache := authncache.New()
var log bytes.Buffer
logger := plog.TestLogger(t, &log)
logger, log := plog.TestLogger(t)
if tt.cache != nil {
tt.cache(t, cache)
@@ -2375,8 +2373,7 @@ func TestControllerFilterSecret(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
var log bytes.Buffer
logger := plog.TestLogger(t, &log)
logger, _ := plog.TestLogger(t)
nowDoesntMatter := time.Date(1122, time.September, 33, 4, 55, 56, 778899, time.Local)
frozenClock := clocktesting.NewFakeClock(nowDoesntMatter)
@@ -2439,8 +2436,7 @@ func TestControllerFilterConfigMap(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
var log bytes.Buffer
logger := plog.TestLogger(t, &log)
logger, _ := plog.TestLogger(t)
nowDoesntMatter := time.Date(1122, time.September, 33, 4, 55, 56, 778899, time.Local)
frozenClock := clocktesting.NewFakeClock(nowDoesntMatter)