From 17cb4c2ee5045e49ce477f3d5579b8d07ee6c9b8 Mon Sep 17 00:00:00 2001 From: Joshua Casey Date: Wed, 30 Jul 2025 09:21:18 -0500 Subject: [PATCH] Update unit test malformed jwt error messages due to https://github.com/coreos/go-oidc/compare/v3.14.1...v3.15.0 --- internal/upstreamoidc/upstreamoidc_test.go | 6 +++--- pkg/oidcclient/login_test.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/upstreamoidc/upstreamoidc_test.go b/internal/upstreamoidc/upstreamoidc_test.go index 762e09de2..201021709 100644 --- a/internal/upstreamoidc/upstreamoidc_test.go +++ b/internal/upstreamoidc/upstreamoidc_test.go @@ -187,7 +187,7 @@ func TestProviderConfig(t *testing.T) { { name: "invalid ID token", returnIDTok: "invalid-jwt", - wantErr: "received invalid ID token: oidc: malformed jwt: oidc: malformed jwt, expected 3 parts got 1", + wantErr: "received invalid ID token: oidc: malformed jwt: go-jose/go-jose: compact JWS format must have three parts", }, { name: "invalid access token hash", @@ -1009,7 +1009,7 @@ func TestProviderConfig(t *testing.T) { requireIDToken: true, rawClaims: []byte(`{"userinfo_endpoint": "not-empty"}`), userInfo: forceUserInfoWithClaims("some-other-subject", `{"name": "Pinny TheSeal", "sub": "some-other-subject"}`), - wantErr: "received invalid ID token: oidc: malformed jwt: oidc: malformed jwt, expected 3 parts got 1", + wantErr: "received invalid ID token: oidc: malformed jwt: go-jose/go-jose: compact JWS format must have three parts", }, { name: "invalid nonce", @@ -1145,7 +1145,7 @@ func TestProviderConfig(t *testing.T) { name: "invalid ID token", authCode: "valid", returnIDTok: "invalid-jwt", - wantErr: "received invalid ID token: oidc: malformed jwt: oidc: malformed jwt, expected 3 parts got 1", + wantErr: "received invalid ID token: oidc: malformed jwt: go-jose/go-jose: compact JWS format must have three parts", }, { name: "invalid access token hash", diff --git a/pkg/oidcclient/login_test.go b/pkg/oidcclient/login_test.go index 12242011e..8bb1629bc 100644 --- a/pkg/oidcclient/login_test.go +++ b/pkg/oidcclient/login_test.go @@ -2582,7 +2582,7 @@ func TestLogin(t *testing.T) { //nolint:gocyclo `"level"=4 "msg"="Pinniped: Performing RFC8693 token exchange" "requestedAudience"="test-audience-produce-invalid-jwt"`, `"level"=4 "msg"="Pinniped: Performing OIDC discovery" "issuer"="` + successServer.URL + `"`, }, - wantErr: `failed to exchange token: received invalid JWT: oidc: malformed jwt: oidc: malformed jwt, expected 3 parts got 1`, + wantErr: `failed to exchange token: received invalid JWT: oidc: malformed jwt: go-jose/go-jose: compact JWS format must have three parts`, }, { name: "with requested audience, session cache hit with valid access token, ID token has wrong audience, and token exchange request succeeds",