From 23be766c8bcc981b4e05dfe0d059502e8b16a724 Mon Sep 17 00:00:00 2001 From: Ryan Richard Date: Fri, 18 Dec 2020 15:14:51 -0800 Subject: [PATCH] Move const to file-of-use and replce dup string Signed-off-by: aram price --- .../supervisorconfig/generator/federation_domain_secrets.go | 4 ---- .../controller/supervisorconfig/generator/secret_helper.go | 4 +++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/internal/controller/supervisorconfig/generator/federation_domain_secrets.go b/internal/controller/supervisorconfig/generator/federation_domain_secrets.go index 68e893c56..34619fe43 100644 --- a/internal/controller/supervisorconfig/generator/federation_domain_secrets.go +++ b/internal/controller/supervisorconfig/generator/federation_domain_secrets.go @@ -24,10 +24,6 @@ import ( "go.pinniped.dev/internal/plog" ) -const ( - federationDomainKind = "FederationDomain" -) - type federationDomainSecretsController struct { secretHelper SecretHelper secretRefFunc func(domain *configv1alpha1.FederationDomain) *corev1.LocalObjectReference diff --git a/internal/controller/supervisorconfig/generator/secret_helper.go b/internal/controller/supervisorconfig/generator/secret_helper.go index 3c2173875..fe2f8da7a 100644 --- a/internal/controller/supervisorconfig/generator/secret_helper.go +++ b/internal/controller/supervisorconfig/generator/secret_helper.go @@ -39,6 +39,8 @@ const ( // FederationDomainStateEncryptionKeyType for the Secret storing the FederationDomain state encryption key. FederationDomainStateEncryptionKeyType corev1.SecretType = "secrets.pinniped.dev/federation-domain-state-encryption-key" + federationDomainKind = "FederationDomain" + // symmetricSecretDataKey is the corev1.Secret.Data key for the symmetric key value generated by this helper. symmetricSecretDataKey = "key" @@ -102,7 +104,7 @@ func (s *symmetricSecretHelper) Generate(parent *configv1alpha1.FederationDomain *metav1.NewControllerRef(parent, schema.GroupVersionKind{ Group: configv1alpha1.SchemeGroupVersion.Group, Version: configv1alpha1.SchemeGroupVersion.Version, - Kind: "FederationDomain", + Kind: federationDomainKind, }), }, },