From 2460568be3abfe9817428b28752ddc304edf1636 Mon Sep 17 00:00:00 2001 From: Ryan Richard Date: Mon, 15 Mar 2021 16:11:45 -0700 Subject: [PATCH] Add some debug logging --- internal/concierge/impersonator/impersonator.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/internal/concierge/impersonator/impersonator.go b/internal/concierge/impersonator/impersonator.go index 117909a4e..6df28a762 100644 --- a/internal/concierge/impersonator/impersonator.go +++ b/internal/concierge/impersonator/impersonator.go @@ -269,9 +269,8 @@ func newImpersonationReverseProxyFunc(restConfig *rest.Config) (func(*genericapi return } - plog.Trace("proxying authenticated request", - "url", r.URL.String(), - "method", r.Method, + plog.Debug("impersonation proxy servicing request", "method", r.Method, "url", r.URL.String()) + plog.Trace("impersonation proxy servicing request was for user", "username", userInfo.GetName(), // this info leak seems fine for trace level logs ) @@ -279,6 +278,8 @@ func newImpersonationReverseProxyFunc(restConfig *rest.Config) (func(*genericapi reverseProxy.Transport = rt reverseProxy.FlushInterval = 200 * time.Millisecond // the "watch" verb will not work without this line reverseProxy.ServeHTTP(w, r) + + plog.Debug("impersonation proxy finished servicing request", "method", r.Method, "url", r.URL.String()) }) }, nil }