Resolving code review suggestions:

- set provideClusterInfo to true
- kubernetes library versions to 0.20.1
- version timestamps back to v0.0.0-00010101000000-000000000000
This commit is contained in:
Margo Crawford
2021-01-08 10:21:59 -08:00
parent 1b770b01ae
commit 326f10bbbf
4 changed files with 26 additions and 19 deletions

View File

@@ -129,6 +129,7 @@ func runGetKubeconfig(out io.Writer, deps kubeconfigDeps, flags getKubeconfigPar
if err != nil {
return fmt.Errorf("could not determine the Pinniped executable path: %w", err)
}
execConfig.ProvideClusterInfo = true
oidcCABundle, err := loadCABundlePaths(flags.oidc.caBundlePaths)
if err != nil {

View File

@@ -321,7 +321,7 @@ func TestGetKubeconfig(t *testing.T) {
- --token=test-token
command: '.../path/to/pinniped'
env: []
provideClusterInfo: false
provideClusterInfo: true
`),
},
{
@@ -366,7 +366,7 @@ func TestGetKubeconfig(t *testing.T) {
- --token-env=TEST_TOKEN
command: '.../path/to/pinniped'
env: []
provideClusterInfo: false
provideClusterInfo: true
`),
},
{
@@ -422,7 +422,7 @@ func TestGetKubeconfig(t *testing.T) {
- --request-audience=test-audience
command: '.../path/to/pinniped'
env: []
provideClusterInfo: false
provideClusterInfo: true
`, base64.StdEncoding.EncodeToString(testCA.Bundle())),
},
{
@@ -484,7 +484,7 @@ func TestGetKubeconfig(t *testing.T) {
- --request-audience=test-audience
command: '.../path/to/pinniped'
env: []
provideClusterInfo: false
provideClusterInfo: true
`, base64.StdEncoding.EncodeToString(testCA.Bundle())),
},
}