mirror of
https://github.com/vmware-tanzu/pinniped.git
synced 2026-01-07 14:05:50 +00:00
Resolving code review suggestions:
- set provideClusterInfo to true - kubernetes library versions to 0.20.1 - version timestamps back to v0.0.0-00010101000000-000000000000
This commit is contained in:
@@ -129,6 +129,7 @@ func runGetKubeconfig(out io.Writer, deps kubeconfigDeps, flags getKubeconfigPar
|
||||
if err != nil {
|
||||
return fmt.Errorf("could not determine the Pinniped executable path: %w", err)
|
||||
}
|
||||
execConfig.ProvideClusterInfo = true
|
||||
|
||||
oidcCABundle, err := loadCABundlePaths(flags.oidc.caBundlePaths)
|
||||
if err != nil {
|
||||
|
||||
@@ -321,7 +321,7 @@ func TestGetKubeconfig(t *testing.T) {
|
||||
- --token=test-token
|
||||
command: '.../path/to/pinniped'
|
||||
env: []
|
||||
provideClusterInfo: false
|
||||
provideClusterInfo: true
|
||||
`),
|
||||
},
|
||||
{
|
||||
@@ -366,7 +366,7 @@ func TestGetKubeconfig(t *testing.T) {
|
||||
- --token-env=TEST_TOKEN
|
||||
command: '.../path/to/pinniped'
|
||||
env: []
|
||||
provideClusterInfo: false
|
||||
provideClusterInfo: true
|
||||
`),
|
||||
},
|
||||
{
|
||||
@@ -422,7 +422,7 @@ func TestGetKubeconfig(t *testing.T) {
|
||||
- --request-audience=test-audience
|
||||
command: '.../path/to/pinniped'
|
||||
env: []
|
||||
provideClusterInfo: false
|
||||
provideClusterInfo: true
|
||||
`, base64.StdEncoding.EncodeToString(testCA.Bundle())),
|
||||
},
|
||||
{
|
||||
@@ -484,7 +484,7 @@ func TestGetKubeconfig(t *testing.T) {
|
||||
- --request-audience=test-audience
|
||||
command: '.../path/to/pinniped'
|
||||
env: []
|
||||
provideClusterInfo: false
|
||||
provideClusterInfo: true
|
||||
`, base64.StdEncoding.EncodeToString(testCA.Bundle())),
|
||||
},
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user