CRD already validates that IDP transform constant names are unique

- Remove that validation from the controller since the CRD already
  validates it during creates and updates.
- Also finish the supervisor_federationdomain_status_test.go by adding
  more tests for both controller validations and CRD validations

test/testlib/client.go

@@ -354,7 +354,7 @@ func WaitForFederationDomainStatusConditions(ctx context.Context, t *testing.T,
 				"wanted status conditions: %#v\nactual status conditions were: %#v\nnot equal at index %d",
 				expectConditions, fd.Status.Conditions, i)
 		}
-	}, 5*time.Second, 1*time.Second, "wanted FederationDomain conditions")
+	}, 60*time.Second, 1*time.Second, "wanted FederationDomain conditions")
 }
 
 func RandBytes(t *testing.T, numBytes int) []byte {