mirror of
https://github.com/vmware-tanzu/pinniped.git
synced 2026-09-05 23:57:12 +00:00
add code review todos and light refactoring
Co-authored-by: Ryan Richard <richardry@vmware.com>
This commit is contained in:
committed by
Ryan Richard
co-authored by
Ryan Richard
parent
1b7a26d932
commit
6e9023e090
@@ -28,6 +28,8 @@ func TestTLSSpecKubeBuilderValidationConcierge_Parallel(t *testing.T) {
|
||||
customResourceName string
|
||||
expectedError string
|
||||
}{
|
||||
// TODO: these "spec.endpoint" could use the real URL of the local-user-authenticator
|
||||
// TODO: should we repeat these tests using the JWTAuthenticator too?
|
||||
{
|
||||
name: "should disallow certificate authority data source with missing name",
|
||||
customResourceYaml: here.Doc(`
|
||||
|
||||
@@ -28,6 +28,8 @@ func TestTLSSpecKubeBuilderValidationSupervisor_Parallel(t *testing.T) {
|
||||
customResourceName string
|
||||
expectedError string
|
||||
}{
|
||||
// TODO: use the OIDC provider from env instead of bar.com
|
||||
// TODO: make ths a loop to also run the same tests on LDAP, AD, GitHub??
|
||||
{
|
||||
name: "should disallow certificate authority data source with missing name",
|
||||
customResourceYaml: here.Doc(`
|
||||
|
||||
Reference in New Issue
Block a user