add code review todos and light refactoring

Co-authored-by: Ryan Richard <richardry@vmware.com>
This commit is contained in:
Joshua Casey
2024-08-05 11:32:19 -07:00
committed by Ryan Richard
co-authored by Ryan Richard
parent 1b7a26d932
commit 6e9023e090
11 changed files with 142 additions and 116 deletions
@@ -28,6 +28,8 @@ func TestTLSSpecKubeBuilderValidationConcierge_Parallel(t *testing.T) {
customResourceName string
expectedError string
}{
// TODO: these "spec.endpoint" could use the real URL of the local-user-authenticator
// TODO: should we repeat these tests using the JWTAuthenticator too?
{
name: "should disallow certificate authority data source with missing name",
customResourceYaml: here.Doc(`
@@ -28,6 +28,8 @@ func TestTLSSpecKubeBuilderValidationSupervisor_Parallel(t *testing.T) {
customResourceName string
expectedError string
}{
// TODO: use the OIDC provider from env instead of bar.com
// TODO: make ths a loop to also run the same tests on LDAP, AD, GitHub??
{
name: "should disallow certificate authority data source with missing name",
customResourceYaml: here.Doc(`