From 2054708c53faf5c905e26a8c8549e55d4533ca73 Mon Sep 17 00:00:00 2001
From: Ryan Richard <richardry@vmware.com>
Date: Thu, 16 May 2024 13:49:53 -0700
Subject: [PATCH] update hack/prepare-supervisor-on-kind.sh for GitHub IDPs

---
 hack/prepare-supervisor-on-kind.sh | 27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/hack/prepare-supervisor-on-kind.sh b/hack/prepare-supervisor-on-kind.sh
index 2c4467f0a..0a8a971a3 100755
--- a/hack/prepare-supervisor-on-kind.sh
+++ b/hack/prepare-supervisor-on-kind.sh
@@ -94,13 +94,6 @@ if [[ "$use_oidc_upstream" == "no" && "$use_ldap_upstream" == "no" && "$use_ad_u
   exit 1
 fi
 
-if [[ "$use_github_upstream" == "yes" ]]; then
-  if [[ "${PINNIPED_TEST_SUPERVISOR_UPSTREAM_GITHUB_CLIENT_ID:-}" == "" || "${PINNIPED_TEST_SUPERVISOR_UPSTREAM_GITHUB_CLIENT_SECRET:-}" == "" ]]; then
-    echo "Error: Please set environment vars PINNIPED_TEST_SUPERVISOR_UPSTREAM_GITHUB_CLIENT_ID and PINNIPED_TEST_SUPERVISOR_UPSTREAM_GITHUB_CLIENT_SECRET when using --github flag"
-    exit 1
-  fi
-fi
-
 # Read the env vars output by hack/prepare-for-integration-tests.sh
 source /tmp/integration-test-env
 
@@ -303,7 +296,7 @@ EOF
 fi
 
 if [[ "$use_github_upstream" == "yes" ]]; then
-  # Make an GitHubIdentityProvider.  Needs to be configured with an actual GitHub App or GitHub OAuth App.  
+  # Make an GitHubIdentityProvider.  Needs to be configured with an actual GitHub App or GitHub OAuth App.
   cat <<EOF | kubectl apply --namespace "$PINNIPED_TEST_SUPERVISOR_NAMESPACE" -f -
 apiVersion: idp.supervisor.pinniped.dev/v1alpha1
 kind: GitHubIdentityProvider
@@ -317,7 +310,7 @@ spec:
       policy: AllGitHubUsers
 EOF
 
-  # Make a Secret for the above GitHubIdentityProvider to describe the GitHub client configured.  
+  # Make a Secret for the above GitHubIdentityProvider to describe the GitHub client configured.
   cat <<EOF | kubectl apply --namespace "$PINNIPED_TEST_SUPERVISOR_NAMESPACE" -f -
 apiVersion: v1
 kind: Secret
@@ -325,9 +318,15 @@ type: "secrets.pinniped.dev/github-client"
 metadata:
   name: my-github-provider-client-secret
 stringData:
-  clientID: "$PINNIPED_TEST_SUPERVISOR_UPSTREAM_GITHUB_CLIENT_ID"
-  clientSecret: "$PINNIPED_TEST_SUPERVISOR_UPSTREAM_GITHUB_CLIENT_SECRET"
+  clientID: "$PINNIPED_TEST_GITHUB_APP_CLIENT_ID"
+  clientSecret: "$PINNIPED_TEST_GITHUB_APP_CLIENT_SECRET"
 EOF
+
+  # Grant the test user some RBAC permissions so we can play with kubectl as that user.
+  # TODO
+#  kubectl create clusterrolebinding github-test-user-can-view --clusterrole view \
+#    --user "$PINNIPED_TEST_GITHUB_TODO_WE_DONT_HAVE_THIS_VARIABLE_YET" \
+#    --dry-run=client --output yaml | kubectl apply -f -
 fi
 
 # Create a CA and TLS serving certificates for the Supervisor's FederationDomain.
@@ -591,6 +590,12 @@ if [[ "$use_ad_upstream" == "yes" ]]; then
   echo
 fi
 
+if [[ "$use_github_upstream" == "yes" ]]; then
+  echo "    GitHub Username: $PINNIPED_TEST_GITHUB_USER_USERNAME (or use your own account)"
+  echo "    GitHub Password: $PINNIPED_TEST_GITHUB_USER_PASSWORD (also requires OTP, or use your own account)"
+  echo
+fi
+
 # Echo the commands that may be used to login and print the identity of the currently logged in user.
 # Once the CLI has cached your tokens, it will automatically refresh your short-lived credentials whenever
 # they expire, so you should not be prompted to log in again for the rest of the day.