From 85c548bca24ad97513d6d60ff6b7572ed5c7c525 Mon Sep 17 00:00:00 2001 From: Ryan Richard Date: Mon, 6 Jul 2026 11:08:16 -0700 Subject: [PATCH] fix lint errors Signed-off-by: Ryan Richard --- internal/crypto/ptls/profiles.go | 4 ++-- test/integration/concierge_impersonation_proxy_test.go | 1 - test/integration/ptls_gofips140_test.go | 5 ++++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/internal/crypto/ptls/profiles.go b/internal/crypto/ptls/profiles.go index 803655afe..777cb4205 100644 --- a/internal/crypto/ptls/profiles.go +++ b/internal/crypto/ptls/profiles.go @@ -32,8 +32,8 @@ func secureCipherSuiteIDs() []uint16 { // These are considered "insecure" by Go because they are returned by tls.InsecureCipherSuites(). // So although they are included in Go's src/crypto/tls/defaults_fips140.go, they will not actually be used. - //tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256, - //tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256, + // tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256, + // tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256, } } diff --git a/test/integration/concierge_impersonation_proxy_test.go b/test/integration/concierge_impersonation_proxy_test.go index 9ec4a4a29..018ccc5d1 100644 --- a/test/integration/concierge_impersonation_proxy_test.go +++ b/test/integration/concierge_impersonation_proxy_test.go @@ -1544,7 +1544,6 @@ func TestImpersonationProxy(t *testing.T) { //nolint:gocyclo // yeah, it's compl require.Empty(t, stderr) expectedCiphers := testlib.GetExpectedCiphers(ptls.Default(nil), testlib.DefaultCipherSuitePreference()) require.Contains(t, stdout, expectedCiphers, "wantedToContain:\n%s\nactual stdout:\n%s", expectedCiphers, stdout) - }) }) diff --git a/test/integration/ptls_gofips140_test.go b/test/integration/ptls_gofips140_test.go index 7c5a4ec32..6b5be4f40 100644 --- a/test/integration/ptls_gofips140_test.go +++ b/test/integration/ptls_gofips140_test.go @@ -53,8 +53,11 @@ func TestFIPSCipherSuites_Parallel(t *testing.T) { // tls config of the client without explicitly set ciphers // is the same as the tls config of the test server with explicitly // set ciphers from ptls. - request, _ := http.NewRequest("GET", server.URL, nil) + request, _ := http.NewRequestWithContext(t.Context(), "GET", server.URL, nil) response, err := transport.RoundTrip(request) + t.Cleanup(func() { + require.NoError(t, response.Body.Close()) + }) require.NoError(t, err) require.Equal(t, http.StatusOK, response.StatusCode) }