From 9b3bcca15e34f65da6e735975ab19ab8d9aa4e15 Mon Sep 17 00:00:00 2001 From: Joshua Casey Date: Fri, 23 Aug 2024 09:45:43 -0500 Subject: [PATCH] Add test to confirm that pversion.Get() returns something that utilversion.NewEffectiveVersion can consume --- internal/pversion/version_test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/internal/pversion/version_test.go b/internal/pversion/version_test.go index 46ebea4ec..8e4161fb3 100644 --- a/internal/pversion/version_test.go +++ b/internal/pversion/version_test.go @@ -11,6 +11,7 @@ import ( "github.com/stretchr/testify/require" apimachineryversion "k8s.io/apimachinery/pkg/version" + utilversion "k8s.io/apiserver/pkg/util/version" ) func TestGet(t *testing.T) { @@ -132,3 +133,10 @@ func TestGet(t *testing.T) { }) } } + +func TestThatPVersionIsCompatibleWithEffectiveVersion(t *testing.T) { + version := Get().String() + effectiveVersion := utilversion.NewEffectiveVersion(version) + require.NotNil(t, effectiveVersion) + require.Equal(t, version, "v"+effectiveVersion.BinaryVersion().String()) +}