From a72155a57f9392ace3ad09a9296d22ef91b3526f Mon Sep 17 00:00:00 2001
From: Ben Petersen <ben@benjaminapetersen.me>
Date: Thu, 11 Apr 2024 16:51:53 -0400
Subject: [PATCH] Update prepare-supervisor-on-kind.sh final polish

---
 hack/prepare-supervisor-on-kind.sh | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/hack/prepare-supervisor-on-kind.sh b/hack/prepare-supervisor-on-kind.sh
index c142dd2d9..2c4467f0a 100755
--- a/hack/prepare-supervisor-on-kind.sh
+++ b/hack/prepare-supervisor-on-kind.sh
@@ -303,8 +303,7 @@ EOF
 fi
 
 if [[ "$use_github_upstream" == "yes" ]]; then
-  # Make an GitHubIdentityProvider.  Needs to be configured with an actual GitHub App or GitHub OAuth App.
-  # TODO: claims ought be configured
+  # Make an GitHubIdentityProvider.  Needs to be configured with an actual GitHub App or GitHub OAuth App.  
   cat <<EOF | kubectl apply --namespace "$PINNIPED_TEST_SUPERVISOR_NAMESPACE" -f -
 apiVersion: idp.supervisor.pinniped.dev/v1alpha1
 kind: GitHubIdentityProvider
@@ -318,8 +317,7 @@ spec:
       policy: AllGitHubUsers
 EOF
 
-  # Make a Secret for the above GitHubIdentityProvider to describe the GitHub client configured.
-  # TODO: make clientID and clientSecret configurable, create & store values in our secret manager
+  # Make a Secret for the above GitHubIdentityProvider to describe the GitHub client configured.  
   cat <<EOF | kubectl apply --namespace "$PINNIPED_TEST_SUPERVISOR_NAMESPACE" -f -
 apiVersion: v1
 kind: Secret
@@ -332,7 +330,6 @@ stringData:
 EOF
 fi
 
-
 # Create a CA and TLS serving certificates for the Supervisor's FederationDomain.
 if [[ ! -f "$root_ca_crt_path" ]]; then
   step certificate create \
@@ -469,8 +466,6 @@ if [[ "$use_github_upstream" == "yes" ]]; then
 EOF
 fi
 
-
-
 # Apply the FederationDomain from the file created above.
 kubectl apply --namespace "$PINNIPED_TEST_SUPERVISOR_NAMESPACE" -f "$fd_file"