mirror of
https://github.com/vmware-tanzu/pinniped.git
synced 2026-01-06 21:47:45 +00:00
Update comments for testing
This commit is contained in:
@@ -372,7 +372,7 @@ func TestImpersonatorConfigControllerSync(t *testing.T) {
|
||||
})
|
||||
r.NoError(err)
|
||||
|
||||
// Return a func that starts a fake server when called, and shuts down the fake server when stopCh is closed.
|
||||
// Return a func that starts a fake server when called, and shuts down the fake server when ctx is cancelled.
|
||||
// This fake server is enough like the real impersonation proxy server for this unit test because it
|
||||
// uses the supplied providers to serve TLS. The goal of this unit test is to make sure that the server
|
||||
// was started/stopped/configured correctly, not to test the actual impersonation behavior.
|
||||
@@ -404,7 +404,7 @@ func TestImpersonatorConfigControllerSync(t *testing.T) {
|
||||
}()
|
||||
|
||||
if testHTTPServerInterruptCh == nil {
|
||||
// Wait in the foreground for the stopCh to be closed, and kill the server when that happens.
|
||||
// Wait in the foreground for the context to be done, and kill the server when that happens.
|
||||
// This is similar to the behavior of the real impersonation server.
|
||||
<-ctx.Done()
|
||||
} else {
|
||||
|
||||
Reference in New Issue
Block a user