From b7c26c43ca5527e5f744e82f176625d4d82bcf8f Mon Sep 17 00:00:00 2001
From: Joshua Casey <joshuatcasey@gmail.com>
Date: Tue, 23 Jul 2024 17:22:21 -0500
Subject: [PATCH] Add LDAPIdentityProvider and ActiveDirectoryIdentityProvider
 to the Supervisor TLS config static validation integration tests

Co-authored-by: Ryan Richard <richardry@vmware.com>
---
 test/integration/supervisor_tls_spec_test.go | 60 +++++++++++++++++++-
 1 file changed, 59 insertions(+), 1 deletion(-)

diff --git a/test/integration/supervisor_tls_spec_test.go b/test/integration/supervisor_tls_spec_test.go
index 8fa989029..8d14708a5 100644
--- a/test/integration/supervisor_tls_spec_test.go
+++ b/test/integration/supervisor_tls_spec_test.go
@@ -31,6 +31,35 @@ func TestTLSSpecKubeBuilderValidationSupervisor_Parallel(t *testing.T) {
 			%s
 	`)
 
+	ldapIDPTemplate := here.Doc(`
+		apiVersion: idp.supervisor.%s/v1alpha1
+		kind: LDAPIdentityProvider
+		metadata:
+			name: %s
+		spec:
+			host: %s
+			bind:
+				secretName: foo-bar-bind-credentials
+			userSearch:
+				base: foo
+				attributes:
+					username: bar
+					uid: baz
+			%s
+	`)
+
+	activeDirectoryIDPTemplate := here.Doc(`
+		apiVersion: idp.supervisor.%s/v1alpha1
+		kind: ActiveDirectoryIdentityProvider
+		metadata:
+			name: %s
+		spec:
+			host: %s
+			bind:
+				secretName: foo-bar-bind-credentials
+			%s
+	`)
+
 	githubIDPTemplate := here.Doc(`
 		apiVersion: idp.supervisor.%s/v1alpha1
 		kind: GitHubIdentityProvider
@@ -52,7 +81,6 @@ func TestTLSSpecKubeBuilderValidationSupervisor_Parallel(t *testing.T) {
 		expectedError       string
 		expectedGitHubError string
 	}{
-		// TODO: make this a loop to also run the same tests on LDAP, AD, GitHub??
 		{
 			name: "should disallow certificate authority data source with missing name",
 			tlsYAML: here.Doc(`
@@ -202,6 +230,36 @@ func TestTLSSpecKubeBuilderValidationSupervisor_Parallel(t *testing.T) {
 				)
 			})
 
+			t.Run("apply LDAP IDP", func(t *testing.T) {
+				resourceName := "test-ldap-idp-" + testlib.RandHex(t, 7)
+				yamlBytes := []byte(fmt.Sprintf(ldapIDPTemplate,
+					env.APIGroupSuffix, resourceName, env.SupervisorUpstreamLDAP.Host, indentedTLSYAML))
+
+				performKubectlApply(
+					t,
+					yamlBytes,
+					`ldapidentityprovider.idp.supervisor.pinniped.dev`,
+					tc.expectedError,
+					"LDAPIdentityProvider",
+					resourceName,
+				)
+			})
+
+			t.Run("apply ActiveDirectory IDP", func(t *testing.T) {
+				resourceName := "test-ad-idp-" + testlib.RandHex(t, 7)
+				yamlBytes := []byte(fmt.Sprintf(activeDirectoryIDPTemplate,
+					env.APIGroupSuffix, resourceName, env.SupervisorUpstreamLDAP.Host, indentedTLSYAML))
+
+				performKubectlApply(
+					t,
+					yamlBytes,
+					`activedirectoryidentityprovider.idp.supervisor.pinniped.dev`,
+					tc.expectedError,
+					"ActiveDirectoryIdentityProvider",
+					resourceName,
+				)
+			})
+
 			t.Run("apply GitHub IDP", func(t *testing.T) {
 				// GitHub is nested deeper
 				indentedTLSYAMLForGitHub := strings.ReplaceAll(indentedTLSYAML, "\n", "\n    ")