mirrors/pinniped
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/pinniped.git synced 2026-01-10 07:58:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

review cleanup, remove TODOs

Browse Source
This commit is contained in:
Benjamin A. Petersen
2024-04-25 11:07:55 -04:00
parent 2753b468fd
commit cd86d57763
12 changed files with 18 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/controller/supervisorconfig/githubupstreamwatcher/github_upstream_watcher_test.go
View File

@@ -371,8 +371,7 @@ func TestController(t *testing.T) {
wantErr string
wantLogs []string
wantResultingCache []*upstreamgithub.ProviderConfig
// wantResultingCache []*oidctestutil.TestUpstreamGitHubIdentityProvider
wantResultingUpstreams []v1alpha1.GitHubIdentityProvider
wantResultingUpstreams []v1alpha1.GitHubIdentityProvider
}{
{
name: "no GitHubIdentityProviders",
@@ -1763,7 +1762,6 @@ func TestController(t *testing.T) {
var actualIDP *upstreamgithub.Provider
for _, possibleIDP := range actualIDPList {
if possibleIDP.GetName() == tt.wantResultingCache[i].Name {
// For this check, we know that the actual IDPs are going to have type upstreamgithub.ProviderConfig
var ok bool
actualIDP, ok = possibleIDP.(*upstreamgithub.Provider)
require.True(t, ok)