From e4d2c8ba0795d4e2229505647dc80dbce84258d2 Mon Sep 17 00:00:00 2001 From: Ryan Richard Date: Mon, 12 May 2025 17:58:17 -0700 Subject: [PATCH] skip race detector for impersonator package for now This commit is meant to be reverted when the upstream bug is fixed which causes tests to fail when the race detector is enabled for unit tests in the impersonator package. There is a commit in the hack dir and another commit in the `ci` branch for CI. --- pipelines/shared-tasks/run-unit-tests/task.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pipelines/shared-tasks/run-unit-tests/task.sh b/pipelines/shared-tasks/run-unit-tests/task.sh index b7731afd8..50bc21e12 100755 --- a/pipelines/shared-tasks/run-unit-tests/task.sh +++ b/pipelines/shared-tasks/run-unit-tests/task.sh @@ -14,4 +14,9 @@ export GOCACHE="$PWD/cache/gocache" export GOMODCACHE="$PWD/cache/gomodcache" cd pinniped -go test -short -timeout 15m -race -coverprofile "${COVERAGE_OUTPUT}" -covermode atomic ./... + +# Temporarily avoid using the race detector for the impersonator package due to https://github.com/kubernetes/kubernetes/issues/128548 +# Note that this will exclude the impersonator package from the code coverage for now as a side effect. +# TODO: change this back to using the race detector everywhere +go test -short -timeout 15m -race -coverprofile "${COVERAGE_OUTPUT}" -covermode atomic $(go list ./... | grep -v internal/concierge/impersonator) +go test -short ./internal/concierge/impersonator