From e884cef1ef435f2716a9f5fd77dbee63bbe2f6da Mon Sep 17 00:00:00 2001 From: Andrew Keesler Date: Mon, 3 Aug 2020 10:29:54 -0400 Subject: [PATCH] Resolve SingularName TODO with comment Signed-off-by: Andrew Keesler --- test/integration/api_discovery_test.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/test/integration/api_discovery_test.go b/test/integration/api_discovery_test.go index c4ca2303c..d35b7abe7 100644 --- a/test/integration/api_discovery_test.go +++ b/test/integration/api_discovery_test.go @@ -45,13 +45,17 @@ func TestGetAPIResourceList(t *testing.T) { require.NotNil(t, actualPlaceHolderResources) expectedLoginRequestAPIResource := metav1.APIResource{ - Name: "loginrequests", - Kind: "LoginRequest", - SingularName: "", // TODO(akeesler): what should this be? + Name: "loginrequests", + Kind: "LoginRequest", Verbs: metav1.Verbs([]string{ "create", }), Namespaced: false, + + // This is currently an empty string in the response; maybe it should not be + // empty? Seems like no harm in keeping it like this for now, but feel free + // to update in the future if there is a compelling reason to do so. + SingularName: "", } expectedLDCAPIResource := metav1.APIResource{