Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

Enforce importas:

- go.pinniped.dev/generated/latest/apis/supervisor/config/v1alpha1
- go.pinniped.dev/generated/latest/apis/supervisor/idp/v1alpha1

test/testlib/assertions.go

@@ -25,7 +25,7 @@ type (
 	// assertionFailure is a single error observed during an iteration of the RequireEventually() loop.
 	assertionFailure struct {
 		format string
-		args   []interface{}
+		args   []any
 	}
 )
 
@@ -33,7 +33,7 @@ type (
 var _ require.TestingT = (*loopTestingT)(nil)
 
 // Errorf is called by the assert.Assertions methods to record an error.
-func (e *loopTestingT) Errorf(format string, args ...interface{}) {
+func (e *loopTestingT) Errorf(format string, args ...any) {
 	*e = append(*e, assertionFailure{format, args})
 }
 
@@ -62,7 +62,7 @@ func RequireEventuallyf(
 	waitFor time.Duration,
 	tick time.Duration,
 	msg string,
-	args ...interface{},
+	args ...any,
 ) {
 	t.Helper()
 	RequireEventually(t, f, waitFor, tick, fmt.Sprintf(msg, args...))
@@ -75,7 +75,7 @@ func RequireEventually(
 	f func(requireEventually *require.Assertions),
 	waitFor time.Duration,
 	tick time.Duration,
-	msgAndArgs ...interface{},
+	msgAndArgs ...any,
 ) {
 	t.Helper()
 
@@ -129,7 +129,7 @@ func RequireEventuallyWithoutError(
 	f func() (bool, error),
 	waitFor time.Duration,
 	tick time.Duration,
-	msgAndArgs ...interface{},
+	msgAndArgs ...any,
 ) {
 	t.Helper()
 	// This previously used wait.PollImmediate (now deprecated), which did not take a ctx arg in the func.
@@ -146,7 +146,7 @@ func RequireNeverWithoutError(
 	f func() (bool, error),
 	waitFor time.Duration,
 	tick time.Duration,
-	msgAndArgs ...interface{},
+	msgAndArgs ...any,
 ) {
 	t.Helper()
 	// This previously used wait.PollImmediate (now deprecated), which did not take a ctx arg in the func.

test/testlib/browsertest/browsertest.go

@@ -104,7 +104,7 @@ func OpenBrowser(t *testing.T) *Browser {
 	b := &Browser{chromeCtx: chromeCtx}
 
 	// Subscribe to console events and exceptions to make them available later.
-	chromedp.ListenTarget(chromeCtx, func(ev interface{}) {
+	chromedp.ListenTarget(chromeCtx, func(ev any) {
 		switch ev := ev.(type) {
 		case *chromedpruntime.EventConsoleAPICalled:
 			args := make([]string, len(ev.Args))

test/testlib/client.go

@@ -30,7 +30,7 @@ import (
 	authenticationv1alpha1 "go.pinniped.dev/generated/latest/apis/concierge/authentication/v1alpha1"
 	"go.pinniped.dev/generated/latest/apis/concierge/login/v1alpha1"
 	clientsecretv1alpha1 "go.pinniped.dev/generated/latest/apis/supervisor/clientsecret/v1alpha1"
-	configv1alpha1 "go.pinniped.dev/generated/latest/apis/supervisor/config/v1alpha1"
+	supervisorconfigv1alpha1 "go.pinniped.dev/generated/latest/apis/supervisor/config/v1alpha1"
 	idpv1alpha1 "go.pinniped.dev/generated/latest/apis/supervisor/idp/v1alpha1"
 	conciergeclientset "go.pinniped.dev/generated/latest/client/concierge/clientset/versioned"
 	pinnipedsupervisorclientset "go.pinniped.dev/generated/latest/client/supervisor/clientset/versioned"
@@ -357,9 +357,9 @@ func WaitForJWTAuthenticatorStatusConditions(ctx context.Context, t *testing.T,
 func CreateTestFederationDomain(
 	ctx context.Context,
 	t *testing.T,
-	spec configv1alpha1.FederationDomainSpec,
-	expectStatus configv1alpha1.FederationDomainPhase,
-) *configv1alpha1.FederationDomain {
+	spec supervisorconfigv1alpha1.FederationDomainSpec,
+	expectStatus supervisorconfigv1alpha1.FederationDomainPhase,
+) *supervisorconfigv1alpha1.FederationDomain {
 	t.Helper()
 	testEnv := IntegrationEnv(t)
 
@@ -367,7 +367,7 @@ func CreateTestFederationDomain(
 	defer cancel()
 
 	federationDomainsClient := NewSupervisorClientset(t).ConfigV1alpha1().FederationDomains(testEnv.SupervisorNamespace)
-	federationDomain, err := federationDomainsClient.Create(createContext, &configv1alpha1.FederationDomain{
+	federationDomain, err := federationDomainsClient.Create(createContext, &supervisorconfigv1alpha1.FederationDomain{
 		ObjectMeta: testObjectMeta(t, "oidc-provider"),
 		Spec:       spec,
 	}, metav1.CreateOptions{})
@@ -393,7 +393,7 @@ func CreateTestFederationDomain(
 	return federationDomain
 }
 
-func WaitForFederationDomainStatusPhase(ctx context.Context, t *testing.T, federationDomainName string, expectPhase configv1alpha1.FederationDomainPhase) {
+func WaitForFederationDomainStatusPhase(ctx context.Context, t *testing.T, federationDomainName string, expectPhase supervisorconfigv1alpha1.FederationDomainPhase) {
 	t.Helper()
 	testEnv := IntegrationEnv(t)
 	federationDomainsClient := NewSupervisorClientset(t).ConfigV1alpha1().FederationDomains(testEnv.SupervisorNamespace)
@@ -404,7 +404,7 @@ func WaitForFederationDomainStatusPhase(ctx context.Context, t *testing.T, feder
 		requireEventually.Equalf(expectPhase, fd.Status.Phase, "actual status conditions were: %#v", fd.Status.Conditions)
 
 		// If the FederationDomain was successfully created, ensure all secrets are present before continuing
-		if expectPhase == configv1alpha1.FederationDomainPhaseReady {
+		if expectPhase == supervisorconfigv1alpha1.FederationDomainPhaseReady {
 			requireEventually.NotEmpty(fd.Status.Secrets.JWKS.Name, "expected status.secrets.jwks.name not to be empty")
 			requireEventually.NotEmpty(fd.Status.Secrets.TokenSigningKey.Name, "expected status.secrets.tokenSigningKey.name not to be empty")
 			requireEventually.NotEmpty(fd.Status.Secrets.StateSigningKey.Name, "expected status.secrets.stateSigningKey.name not to be empty")
@@ -510,7 +510,7 @@ func CreateClientCredsSecret(t *testing.T, clientID string, clientSecret string)
 	)
 }
 
-func CreateOIDCClient(t *testing.T, spec configv1alpha1.OIDCClientSpec, expectedPhase configv1alpha1.OIDCClientPhase) (string, string) {
+func CreateOIDCClient(t *testing.T, spec supervisorconfigv1alpha1.OIDCClientSpec, expectedPhase supervisorconfigv1alpha1.OIDCClientPhase) (string, string) {
 	t.Helper()
 	env := IntegrationEnv(t)
 	client := NewSupervisorClientset(t)
@@ -520,7 +520,7 @@ func CreateOIDCClient(t *testing.T, spec configv1alpha1.OIDCClientSpec, expected
 	oidcClientClient := client.ConfigV1alpha1().OIDCClients(env.SupervisorNamespace)
 
 	// Create the OIDCClient using GenerateName to get a random name.
-	created, err := oidcClientClient.Create(ctx, &configv1alpha1.OIDCClient{
+	created, err := oidcClientClient.Create(ctx, &supervisorconfigv1alpha1.OIDCClient{
 		ObjectMeta: metav1.ObjectMeta{
 			GenerateName: "client.oauth.pinniped.dev-test-", // use the required name prefix
 			Labels:       map[string]string{"pinniped.dev/test": ""},
@@ -542,7 +542,7 @@ func CreateOIDCClient(t *testing.T, spec configv1alpha1.OIDCClientSpec, expected
 	clientSecret := createOIDCClientSecret(t, created)
 
 	// Wait for the OIDCClient to enter the expected phase (or time out).
-	var result *configv1alpha1.OIDCClient
+	var result *supervisorconfigv1alpha1.OIDCClient
 	RequireEventuallyf(t, func(requireEventually *require.Assertions) {
 		var err error
 		result, err = oidcClientClient.Get(ctx, created.Name, metav1.GetOptions{})
@@ -553,7 +553,7 @@ func CreateOIDCClient(t *testing.T, spec configv1alpha1.OIDCClientSpec, expected
 	return created.Name, clientSecret
 }
 
-func createOIDCClientSecret(t *testing.T, forOIDCClient *configv1alpha1.OIDCClient) string {
+func createOIDCClientSecret(t *testing.T, forOIDCClient *supervisorconfigv1alpha1.OIDCClient) string {
 	t.Helper()
 	env := IntegrationEnv(t)
 	supervisorClient := NewSupervisorClientset(t)

test/testlib/spew.go

@@ -1,11 +1,11 @@
-// Copyright 2020 the Pinniped contributors. All Rights Reserved.
+// Copyright 2020-2024 the Pinniped contributors. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
 package testlib
 
 import "github.com/davecgh/go-spew/spew"
 
-func Sdump(a ...interface{}) string {
+func Sdump(a ...any) string {
 	config := spew.ConfigState{
 		Indent:                  "\t",
 		MaxDepth:                10, // prevent log explosion