Joshua Casey 6e9023e090 add code review todos and light refactoring ...

Co-authored-by: Ryan Richard <richardry@vmware.com>

2024-08-05 11:32:19 -07:00

..

admissionpluginconfig

Enable 'copyloopvar' linter

2024-05-10 12:51:02 -05:00

apiserviceref

Use API service as owner ref for cluster scoped resources

2021-02-10 21:52:08 -05:00

authenticators

Don't skip upstream group memberships when groups scope is not granted

2024-02-21 13:12:18 -08:00

backoff

Enable 'intrange' linter

2024-05-10 12:51:02 -05:00

celtransformer

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00

certauthority

Enable 'copyloopvar' linter

2024-05-10 12:51:02 -05:00

clientcertissuer

Move all mock files into internal/mocks and use mock prefix

2024-05-21 10:38:25 -05:00

clusterhost

Lightly standardize import aliases

2023-11-15 13:52:17 -06:00

concierge

some mild refactoring of ptls common.go (mostly renames)

2024-06-14 13:27:38 -07:00

config

some mild refactoring of ptls common.go (mostly renames)

2024-06-14 13:27:38 -07:00

constable

…

controller

add code review todos and light refactoring

2024-08-05 11:32:19 -07:00

controllerinit

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00

controllerlib

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00

controllermanager

test secret and configmap filtering in concierge authenticator controllers

2024-08-05 11:32:19 -07:00

crud

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00

crypto

some mild refactoring of ptls common.go (mostly renames)

2024-06-14 13:27:38 -07:00

deploymentref

Enable 'copyloopvar' linter

2024-05-10 12:51:02 -05:00

downward

Enable 'copyloopvar' linter

2024-05-10 12:51:02 -05:00

dynamiccert

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00

endpointaddr

make host name parsing case-insensitive

2024-07-29 14:32:01 -07:00

execcredcache

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00

federationdomain

remove unnecessary warning log message

2024-07-10 09:32:23 -07:00

fositestorage

upgrade github.com/go-jose/go-jose and github.com/coreos/go-oidc

2024-06-21 11:16:40 -07:00

fositestoragei

Enforce more imports

2024-05-21 09:31:15 -05:00

githubclient

Make github org comparison case-insensitive, but return original case

2024-05-22 21:21:45 -05:00

groupsuffix

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00

here

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00

httputil

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00

idtransform

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00

kubeclient

Prefer slices package and slices.Concat where possible

2024-05-21 09:31:16 -05:00

leaderelection

Enable 'copyloopvar' linter

2024-05-10 12:51:02 -05:00

localuserauthenticator

Enforce aliases for 'k8s.io/apimachinery/pkg/util/errors' and 'k8s.io/apimachinery/pkg/api/errors'

2024-05-21 09:31:15 -05:00

mocks

No need for calling code to use deprecated options

2024-06-11 13:09:59 -05:00

net/phttp

Enable 'copyloopvar' linter

2024-05-10 12:51:02 -05:00

oidcclientsecretstorage

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00

ownerref

Enable 'copyloopvar' linter

2024-05-10 12:51:02 -05:00

plog

Remove plog.Logr, make plog.TestZapr private, and CLI logs do not need a name

2024-06-11 17:27:45 -05:00

psession

upgrade github.com/go-jose/go-jose and github.com/coreos/go-oidc

2024-06-21 11:16:40 -07:00

pversion

Split off helper function

2023-08-28 12:14:14 -05:00

registry

Remove plog.Logr, make plog.TestZapr private, and CLI logs do not need a name

2024-06-11 17:27:45 -05:00

secret

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00

setutil

Make github org comparison case-insensitive, but return original case

2024-05-22 21:21:45 -05:00

sliceutil

Make github org comparison case-insensitive, but return original case

2024-05-22 21:21:45 -05:00

supervisor

update supervisor controllers

2024-08-05 11:32:19 -07:00

testutil

upgrade github.com/go-jose/go-jose and github.com/coreos/go-oidc

2024-06-21 11:16:40 -07:00

tokenclient

Enable 'copyloopvar' linter

2024-05-10 12:51:02 -05:00

upstreamgithub

Lint new files from the GitHub branch

2024-06-11 10:16:18 -05:00

upstreamldap

user sees error msg when GitHub login is denied due to allowed orgs

2024-06-03 10:56:28 -07:00

upstreamoidc

upgrade github.com/go-jose/go-jose and github.com/coreos/go-oidc

2024-06-21 11:16:40 -07:00

valuelesscontext

Enable 'makezero' and 'prealloc' linters, and require 'any' instead of 'interface{}'

2024-05-21 09:31:15 -05:00