From 8051f5808cf31a3cacb3b9818e9bda2e45554bc9 Mon Sep 17 00:00:00 2001
From: Andrew Wood <ivarch657@gmail.com>
Date: Mon, 24 Jul 2023 21:48:23 +0100
Subject: [PATCH] Cleanups suggested by shellcheck.

---
 autoconf/scripts/benchmark.sh | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/autoconf/scripts/benchmark.sh b/autoconf/scripts/benchmark.sh
index 5c94957..a5eca7b 100755
--- a/autoconf/scripts/benchmark.sh
+++ b/autoconf/scripts/benchmark.sh
@@ -8,12 +8,12 @@
 test_input=$(mktemp /tmp/pvbench1XXXXXX)
 strace_output=$(mktemp /tmp/pvbench2XXXXXX)
 
-trap "rm -f ${test_input} ${strace_output}" EXIT
+trap 'rm -f ${test_input} ${strace_output}' EXIT
 
 pv=${pv:-./pv}
-test -x ${pv} || pv=pv
+test -x "${pv}" || pv="pv"
 
-dd if=/dev/zero of=${test_input} bs=1k count=1k >/dev/null 2>&1
+dd if=/dev/zero of="${test_input}" bs=1k count=1k >/dev/null 2>&1
 
 echo -e "Buf(k)\tRate(k)\tReads\tRsize\tWrites\tWsize"
 
@@ -21,16 +21,16 @@ for ((buffer=100; buffer<=1000; buffer+=100)); do
 	for ((rate=0; rate<=1000; rate+=100)); do
 		rateparm="-L ${rate}k"
 		test ${rate} -eq 0 && rateparm=""
-		strace -tt -o ${strace_output} \
-		  ${pv} ${rateparm} -B ${buffer}k \
-		  -f < ${test_input} > /dev/null 2>&1
+		strace -tt -o "${strace_output}" \
+		  "${pv}" "${rateparm}" -B "${buffer}k" \
+		  -f < "${test_input}" > /dev/null 2>&1
 		rdata=$(
 		  awk '$2~/^read\(0,/{c++;t+=$NF}END{print c "\t" t/c}' \
-		   ${strace_output}
+		   "${strace_output}"
 		)
 		wdata=$(
 		   awk '$2~/^write\(1,/{c++;t+=$NF}END{print c "\t" t/c}' \
-		   ${strace_output}
+		   "${strace_output}"
 		)
 		echo -e "${buffer}\t${rate}\t${rdata}\t${wdata}"
 	done