From a9c4c6e049c3b22afa24296bc9c1c83b8ee3c2ef Mon Sep 17 00:00:00 2001 From: Andrew Wood Date: Tue, 15 Aug 2023 22:30:56 +0100 Subject: [PATCH] Add TODO markers for memory management cleanup work to come soon. --- src/pv/state.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/pv/state.c b/src/pv/state.c index 4a5b758..6780a2e 100644 --- a/src/pv/state.c +++ b/src/pv/state.c @@ -92,6 +92,9 @@ void pv_state_free(pvstate_t state) free(state->display_buffer); state->display_buffer = NULL; + /* TODO: after changing ->name to a strdup(), free() it here */ + /* TODO: after changing ->format_string to a strdup(), free() it here */ + if (NULL != state->transfer_buffer) free(state->transfer_buffer); state->transfer_buffer = NULL; @@ -135,6 +138,7 @@ void pv_state_set_format(pvstate_t state, bool progress, bool timer, bool eta, b PV_ADDFORMAT(lastwritten > 0, buf); } + /* TODO: free state->name, store strdup(name) */ state->name = name; state->reparse_display = 1; } @@ -243,11 +247,13 @@ void pv_state_height_set(pvstate_t state, unsigned int val) void pv_state_name_set(pvstate_t state, /*@null@ */ const char *val) { + /* TODO: free state->name, store strdup(val) */ state->name = val; }; void pv_state_format_string_set(pvstate_t state, /*@null@ */ const char *val) { + /* TODO: free state->format_string, store strdup(val) */ state->format_string = val; };