From c8ad7eb0e2e18a075de4d13354c396a64820f27f Mon Sep 17 00:00:00 2001 From: Andrew Wood Date: Sat, 11 Jan 2025 20:57:26 +0000 Subject: [PATCH] Bypass valgrind checks on ARM by default due to false positives. --- docs/NEWS.md | 1 + tests/run-valgrind.sh | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/docs/NEWS.md b/docs/NEWS.md index 675bb73..00375c1 100644 --- a/docs/NEWS.md +++ b/docs/NEWS.md @@ -1,6 +1,7 @@ ### UNRELEASED * *fix:* turn off IPC support if _sys/shm.h_ is not available, for compilation on Termux + * *fix:* bypass valgrind checks on ARM by default due to false positives ### 1.9.25 - 22 December 2024 diff --git a/tests/run-valgrind.sh b/tests/run-valgrind.sh index 4634324..6d143b7 100755 --- a/tests/run-valgrind.sh +++ b/tests/run-valgrind.sh @@ -35,6 +35,13 @@ if test "${SKIP_VALGRIND_TESTS}" = "1"; then exit 77 fi +if command -v arch >/dev/null 2>&1 && arch | grep -Fq -e arm -e aarch; then + if ! test "${ENABLE_VALGRIND_ARM}" = "1"; then + echo "skipping valgrind on ARM without ENABLE_VALGRIND_ARM" + exit 77 + fi +fi + valgrindHelp="$(valgrind --help 2>&1)" for valgrindOption in "verbose" "show-error-list" "error-exitcode" "track-fds" "leak-check"; do echo "${valgrindHelp}" | grep -Fq "${valgrindOption}" || { echo "test requires \`valgrind --${valgrindOption}'"; exit 77; }