From d65dbd2f37d2c8c67a8e456159d2b75536ab3e3d Mon Sep 17 00:00:00 2001 From: Andrew Wood Date: Tue, 12 May 2026 23:06:09 +0100 Subject: [PATCH] Make pv_format() static, as it is only used in one place (cppcheck recommendation). --- src/include/pv-internal.h | 3 --- src/pv/display.c | 6 +++--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/include/pv-internal.h b/src/include/pv-internal.h index 9096403..276475c 100644 --- a/src/include/pv-internal.h +++ b/src/include/pv-internal.h @@ -628,9 +628,6 @@ pvdisplay_bytecount_t pv_formatter_previous_line(pvformatter_args_t); pvdisplay_bytecount_t pv_formatter_name(pvformatter_args_t); pvdisplay_bytecount_t pv_formatter_sgr(pvformatter_args_t); -bool pv_format (pvprogramstatus_t, readonly_pvcontrol_t, - readonly_pvtransferstate_t, readonly_pvtransfercalc_t, - /*@null@ */ const char *, pvdisplay_t, bool, bool); void pv_display (pvprogramstatus_t, readonly_pvcontrol_t, pvtransientflags_t, readonly_pvtransferstate_t, pvtransfercalc_t, pvcursorstate_t, pvdisplay_t, /*@null@ */ pvdisplay_t, bool); diff --git a/src/pv/display.c b/src/pv/display.c index 0d55319..2f2ddbe 100644 --- a/src/pv/display.c +++ b/src/pv/display.c @@ -998,9 +998,9 @@ static void pv__format_init(pvprogramstatus_t status, readonly_pvcontrol_t contr * * See pv__format_init for the adjustments that may be made to "status". */ -bool pv_format(pvprogramstatus_t status, readonly_pvcontrol_t control, readonly_pvtransferstate_t transfer, - readonly_pvtransfercalc_t calc, /*@null@ */ const char *format_supplied, pvdisplay_t display, - bool reinitialise, bool final) +static bool pv_format(pvprogramstatus_t status, readonly_pvcontrol_t control, readonly_pvtransferstate_t transfer, + readonly_pvtransfercalc_t calc, /*@null@ */ const char *format_supplied, pvdisplay_t display, + bool reinitialise, bool final) { struct pvdisplay_component_s *format_component_array; char display_segments[PV_SIZEOF_FORMAT_SEGMENTS_BUF]; /* flawfinder: ignore - always bounded */