From dae41a447ca3ed4440b69d3da6f97d1d82c44a55 Mon Sep 17 00:00:00 2001 From: Nicky Semenza Date: Wed, 13 Oct 2021 15:37:09 -0700 Subject: [PATCH] move GODEBUG from code to readme --- .github/workflows/go.yml | 1 - README.md | 16 ++-------------- redoctober.go | 1 - redoctober_test.go | 1 - 4 files changed, 2 insertions(+), 17 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 46818de..d617724 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -5,7 +5,6 @@ jobs: test: runs-on: ubuntu-latest env: - GOFLAGS: "-mod=vendor" GODEBUG: x509ignoreCN=0 steps: - uses: actions/checkout@v2 diff --git a/README.md b/README.md index f030577..fcc9cb3 100644 --- a/README.md +++ b/README.md @@ -10,21 +10,9 @@ encryption and decryption server. [![Go Test](https://github.com/cloudflare/redoctober/actions/workflows/go.yml/badge.svg)](https://github.com/cloudflare/redoctober/actions/workflows/go.yml) [![Coverage Status](http://codecov.io/github/cloudflare/redoctober/coverage.svg?branch=master)](http://codecov.io/github/cloudflare/redoctober?branch=master) -This project requires [Go 1.16](http://golang.org/doc/install#download) -or later to compile. Verify your go version by running `go version`: +Note: `GODEBUG=x509ignoreCN=0` must be set during runtime (#204) - $ go version - go version go1.4 - -As with any Go program you do need to set the -[GOPATH environment variable](http://golang.org/doc/code.html#GOPATH) -accordingly. With Go set up you can download and compile sources: - - $ go get github.com/cloudflare/redoctober - -And run the tests: - - $ go test github.com/cloudflare/redoctober... +This project requires [Go 1.16](http://golang.org/doc/install#download) or later to compile. ## Running diff --git a/redoctober.go b/redoctober.go index ab9c31f..fdcd6ad 100644 --- a/redoctober.go +++ b/redoctober.go @@ -109,7 +109,6 @@ func registerCli() { //go:generate go run generate.go func main() { - os.Setenv("GODEBUG", "x509ignoreCN=0") // need to keep using go1.16 registerCli() var err error if confFile != "" { diff --git a/redoctober_test.go b/redoctober_test.go index a7bfaa9..6409e57 100644 --- a/redoctober_test.go +++ b/redoctober_test.go @@ -84,7 +84,6 @@ func init() { } func setup(t *testing.T) (cmd *exec.Cmd) { - os.Setenv("GODEBUG", "x509ignoreCN=0") const maxAttempts = 5 // Look for the redoctober binary in current directory and then in $GOPATH/bin