From 053bea18cd7bfaf032f30d6e259f9488f888db65 Mon Sep 17 00:00:00 2001
From: Pavel Mineev <pavel@mineev.me>
Date: Sat, 11 Apr 2020 23:21:47 +0300
Subject: [PATCH] Cut react devtools forwarding  by webpack in production build

---
 docker-init.sh             | 2 --
 frontend/iframe.html       | 6 ++++--
 frontend/webpack.config.js | 8 +++++++-
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/docker-init.sh b/docker-init.sh
index 3104aace..3347fee5 100755
--- a/docker-init.sh
+++ b/docker-init.sh
@@ -2,8 +2,6 @@
 echo "prepare environment"
 # replace BASE_URL constant by REMARK_URL
 sed -i "s|https://demo.remark42.com|${REMARK_URL}|g" /srv/web/*.js
-# remove devtools attach helper. TODO: move to webpack loader
-sed -i "/REMOVE-START/,/REMOVE-END/d" /srv/web/iframe.html
 
 if [ -d "/srv/var" ]; then
   chown -R app:app /srv/var 2>/dev/null
diff --git a/frontend/iframe.html b/frontend/iframe.html
index 82fd6e7f..4b3bf0a9 100644
--- a/frontend/iframe.html
+++ b/frontend/iframe.html
@@ -109,14 +109,16 @@
     <div id="remark42">
       <div class="preloader preloader_view_iframe"></div>
     </div>
+    <% if (htmlWebpackPlugin.options.env === 'development') { %>
     <script>
-      /* REMOVE-START */
       if (window.parent !== window) {
         try {
           window.__REACT_DEVTOOLS_GLOBAL_HOOK__ = window.parent.__REACT_DEVTOOLS_GLOBAL_HOOK__;
         } catch (e) {}
       }
-      /* REMOVE-END */
+    </script>
+    <% } %>
+    <script>
       var lastHeight = 0;
       setInterval(function() {
         if (document.body.offsetHeight !== lastHeight && document.body.offsetHeight > 10) {
diff --git a/frontend/webpack.config.js b/frontend/webpack.config.js
index f3304627..8b2cc073 100644
--- a/frontend/webpack.config.js
+++ b/frontend/webpack.config.js
@@ -168,6 +168,12 @@ module.exports = () => ({
       'process.env.REMARK_NODE': JSON.stringify(NODE_ID),
       'process.env.REMARK_URL': env === 'production' ? JSON.stringify(remarkUrl) : 'window.location.origin',
     }),
+    new Html({
+      template: path.resolve(__dirname, 'iframe.html'),
+      filename: 'iframe.html',
+      inject: false,
+      env,
+    }),
     new Html({
       template: path.resolve(__dirname, 'index.ejs'),
       inject: false,
@@ -203,7 +209,7 @@ module.exports = () => ({
             openAnalyzer: false,
           }),
         ]),
-    new Copy(['./iframe.html', './deleteme.html', './markdown-help.html']),
+    new Copy(['./deleteme.html', './markdown-help.html']),
   ],
   watchOptions: {
     ignored: /(node_modules|\.vendor\.js$)/,