From 8626e4181f37b6c9efbbb1f9168b2fd2a0d18bc1 Mon Sep 17 00:00:00 2001 From: Dmitry Verkhoturov Date: Tue, 30 Jun 2026 19:53:10 +0100 Subject: [PATCH] Fix CI for node 20 / pnpm 10: e2e Playwright image and jest arg forwarding - frontend/Dockerfile.e2e: bump base image to mcr.microsoft.com/playwright: v1.61.1-noble to match the Playwright 1.61.1 npm bump (browser revision mismatch was failing all e2e specs), and corepack pnpm@8 -> pnpm@10.10.0 to match the pnpm bump and the v9 lockfile. - release.yml validate: pnpm 10 forwards 'test -- --runInBand' literally as 'jest -- --runInBand' (treated as a path pattern, 0 tests). Drop the extra separator: 'pnpm test --runInBand'. --- .github/workflows/release.yml | 2 +- frontend/Dockerfile.e2e | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 7e897bed..f654bde2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -74,7 +74,7 @@ jobs: run: | pnpm lint pnpm type-check - pnpm test -- --runInBand + pnpm test --runInBand working-directory: frontend/apps/remark42 env: CI: "true" diff --git a/frontend/Dockerfile.e2e b/frontend/Dockerfile.e2e index 3e808ed3..94e84976 100644 --- a/frontend/Dockerfile.e2e +++ b/frontend/Dockerfile.e2e @@ -1,11 +1,11 @@ -FROM mcr.microsoft.com/playwright:v1.57.0-noble +FROM mcr.microsoft.com/playwright:v1.61.1-noble ENV CI true WORKDIR /frontend COPY ./package.json ./pnpm-workspace.yaml ./pnpm-lock.yaml /frontend/ COPY ./e2e/package.json /frontend/e2e/ -RUN corepack enable && corepack prepare pnpm@8 --activate && pnpm install +RUN corepack enable && corepack prepare pnpm@10.10.0 --activate && pnpm install COPY ./e2e/playwright.config.ts /frontend/e2e/ COPY ./e2e/tests /frontend/e2e/tests/