From 8cd5533aed76affdac4cf9e5a5d1e876a371a166 Mon Sep 17 00:00:00 2001
From: Vyrtsev Mikhail <reeywhaar@gmail.com>
Date: Tue, 16 Jul 2019 01:45:22 +0300
Subject: [PATCH] fix lint errors

---
 .../components/auth-panel/auth-panel.test.tsx | 14 +++++-----
 .../_type/_down/comment__vote_type_down.scss  |  3 ++-
 .../_type/_up/comment__vote_type_up.scss      |  3 ++-
 .../app/components/comment/comment.test.tsx   | 26 +++++++++----------
 frontend/app/utils/parseQuery.ts              | 18 ++++++-------
 5 files changed, 33 insertions(+), 31 deletions(-)

diff --git a/frontend/app/components/auth-panel/auth-panel.test.tsx b/frontend/app/components/auth-panel/auth-panel.test.tsx
index 92e4f53d..6065a5fc 100644
--- a/frontend/app/components/auth-panel/auth-panel.test.tsx
+++ b/frontend/app/components/auth-panel/auth-panel.test.tsx
@@ -24,7 +24,7 @@ describe('<AuthPanel />', () => {
     });
 
     it('should render login form with google and github provider', () => {
-      const element = <AuthPanel {...DefaultProps as Props} user={null} />;
+      const element = <AuthPanel {...(DefaultProps as Props)} user={null} />;
 
       render(element, container);
 
@@ -45,7 +45,7 @@ describe('<AuthPanel />', () => {
     it('should render login form with google and github provider for read-only post', () => {
       const element = (
         <AuthPanel
-          {...DefaultProps as Props}
+          {...(DefaultProps as Props)}
           user={null}
           postInfo={{ ...DefaultProps.postInfo, read_only: true } as PostInfo}
         />
@@ -70,7 +70,7 @@ describe('<AuthPanel />', () => {
     it('should not render settings if there is no hidden users', () => {
       const element = (
         <AuthPanel
-          {...DefaultProps as Props}
+          {...(DefaultProps as Props)}
           user={null}
           postInfo={{ ...DefaultProps.postInfo, read_only: true } as PostInfo}
         />
@@ -86,7 +86,7 @@ describe('<AuthPanel />', () => {
     it('should render settings if there is some hidden users', () => {
       const element = (
         <AuthPanel
-          {...DefaultProps as Props}
+          {...(DefaultProps as Props)}
           user={null}
           postInfo={{ ...DefaultProps.postInfo, read_only: true } as PostInfo}
           hiddenUsers={{ hidden_joe: {} as any }}
@@ -108,7 +108,7 @@ describe('<AuthPanel />', () => {
     });
 
     it('should render info about current user', () => {
-      const element = <AuthPanel {...DefaultProps as Props} user={{ id: `john`, name: 'John' } as User} />;
+      const element = <AuthPanel {...(DefaultProps as Props)} user={{ id: `john`, name: 'John' } as User} />;
 
       render(element, container);
 
@@ -129,7 +129,9 @@ describe('<AuthPanel />', () => {
     });
 
     it('should render admin action', () => {
-      const element = <AuthPanel {...DefaultProps as Props} user={{ id: `test`, admin: true, name: 'John' } as User} />;
+      const element = (
+        <AuthPanel {...(DefaultProps as Props)} user={{ id: `test`, admin: true, name: 'John' } as User} />
+      );
 
       render(element, container);
 
diff --git a/frontend/app/components/comment/__vote/_type/_down/comment__vote_type_down.scss b/frontend/app/components/comment/__vote/_type/_down/comment__vote_type_down.scss
index 5caf0646..4c8db682 100644
--- a/frontend/app/components/comment/__vote/_type/_down/comment__vote_type_down.scss
+++ b/frontend/app/components/comment/__vote/_type/_down/comment__vote_type_down.scss
@@ -2,7 +2,8 @@
   transform: scale(1, -1);
   margin-left: 4px;
 
-  &.comment__vote_selected, &:hover {
+  &.comment__vote_selected,
+  &:hover {
     background-image: url('comment__vote_type_down.svg');
   }
 }
diff --git a/frontend/app/components/comment/__vote/_type/_up/comment__vote_type_up.scss b/frontend/app/components/comment/__vote/_type/_up/comment__vote_type_up.scss
index c3a78603..5fb20825 100644
--- a/frontend/app/components/comment/__vote/_type/_up/comment__vote_type_up.scss
+++ b/frontend/app/components/comment/__vote/_type/_up/comment__vote_type_up.scss
@@ -1,7 +1,8 @@
 .comment__vote_type_up {
   margin-right: 4px;
 
-  &.comment__vote_selected, &:hover {
+  &.comment__vote_selected,
+  &:hover {
     background-image: url('comment__vote_type_up.svg');
   }
 }
diff --git a/frontend/app/components/comment/comment.test.tsx b/frontend/app/components/comment/comment.test.tsx
index 14a26ebd..b15e0fb6 100644
--- a/frontend/app/components/comment/comment.test.tsx
+++ b/frontend/app/components/comment/comment.test.tsx
@@ -37,7 +37,7 @@ describe('<Comment />', () => {
     });
 
     it('disabled on user info widget', () => {
-      const element = <Comment {...{ ...DefaultProps, view: 'user' } as Props} />;
+      const element = <Comment {...({ ...DefaultProps, view: 'user' } as Props)} />;
       render(element, container);
 
       const voteButtons = container.querySelectorAll('.comment__vote');
@@ -51,7 +51,7 @@ describe('<Comment />', () => {
 
     it('disabled on read only post', () => {
       const element = (
-        <Comment {...{ ...DefaultProps, post_info: { ...DefaultProps.post_info, read_only: true } } as Props} />
+        <Comment {...({ ...DefaultProps, post_info: { ...DefaultProps.post_info, read_only: true } } as Props)} />
       );
       render(element, container);
 
@@ -67,7 +67,7 @@ describe('<Comment />', () => {
     it('disabled for deleted comment', () => {
       const element = (
         // ahem
-        <Comment {...{ ...DefaultProps, data: { ...DefaultProps.data, delete: true } } as Props} />
+        <Comment {...({ ...DefaultProps, data: { ...DefaultProps.data, delete: true } } as Props)} />
       );
       render(element, container);
 
@@ -83,13 +83,13 @@ describe('<Comment />', () => {
     it('disabled for guest', () => {
       const element = (
         <Comment
-          {...{
+          {...({
             ...DefaultProps,
             user: {
               id: 'someone',
               picture: 'somepicture-url',
             },
-          } as Props}
+          } as Props)}
         />
       );
       render(element, container);
@@ -104,7 +104,7 @@ describe('<Comment />', () => {
     });
 
     it('disabled for own comment', () => {
-      const element = <Comment {...{ ...DefaultProps, user: null } as Props} />;
+      const element = <Comment {...({ ...DefaultProps, user: null } as Props)} />;
       render(element, container);
 
       const voteButtons = container.querySelectorAll('.comment__vote');
@@ -120,7 +120,7 @@ describe('<Comment />', () => {
       const voteSpy = jest.fn(async () => {});
       const element = (
         <Comment
-          {...DefaultProps as Props}
+          {...(DefaultProps as Props)}
           data={{ ...DefaultProps.data, vote: +1 } as Props['data']}
           putCommentVote={voteSpy}
         />
@@ -145,7 +145,7 @@ describe('<Comment />', () => {
       const voteSpy = jest.fn(async () => {});
       const element = (
         <Comment
-          {...DefaultProps as Props}
+          {...(DefaultProps as Props)}
           data={{ ...DefaultProps.data, vote: -1 } as Props['data']}
           putCommentVote={voteSpy}
         />
@@ -175,7 +175,7 @@ describe('<Comment />', () => {
     });
 
     it('for admin if shows admin controls', () => {
-      const element = <Comment {...{ ...DefaultProps, user: { ...DefaultProps.user, admin: true } } as Props} />;
+      const element = <Comment {...({ ...DefaultProps, user: { ...DefaultProps.user, admin: true } } as Props)} />;
       render(element, container);
 
       const controls = container.querySelectorAll('.comment__controls > span');
@@ -188,7 +188,7 @@ describe('<Comment />', () => {
     });
 
     it('for regular user it shows only "hide"', () => {
-      const element = <Comment {...{ ...DefaultProps, user: { ...DefaultProps.user, admin: false } } as Props} />;
+      const element = <Comment {...({ ...DefaultProps, user: { ...DefaultProps.user, admin: false } } as Props)} />;
       render(element, container);
 
       const controls = container.querySelectorAll('.comment__controls > span');
@@ -197,7 +197,7 @@ describe('<Comment />', () => {
     });
 
     it('verification badge clickable for admin', () => {
-      const element = <Comment {...{ ...DefaultProps, user: { ...DefaultProps.user, admin: true } } as Props} />;
+      const element = <Comment {...({ ...DefaultProps, user: { ...DefaultProps.user, admin: true } } as Props)} />;
       render(element, container);
 
       const controls = container.querySelector('.comment__verification')!;
@@ -207,10 +207,10 @@ describe('<Comment />', () => {
     it('verification badge not clickable for regular user', () => {
       const element = (
         <Comment
-          {...{
+          {...({
             ...DefaultProps,
             data: { ...DefaultProps.data, user: { ...DefaultProps.data!.user, verified: true } },
-          } as Props}
+          } as Props)}
         />
       );
       render(element, container);
diff --git a/frontend/app/utils/parseQuery.ts b/frontend/app/utils/parseQuery.ts
index 26d47204..8f83ba53 100644
--- a/frontend/app/utils/parseQuery.ts
+++ b/frontend/app/utils/parseQuery.ts
@@ -4,17 +4,15 @@ export function parseQuery(search: string): { [key: string]: string } {
   return search
     .substr(1)
     .split('&')
-    .map(
-      (chunk): [string, string] => {
-        const parts = chunk.split('=');
-        if (parts.length < 2) {
-          parts[1] = '';
-        } else {
-          parts[1] = decodeURIComponent(parts[1]);
-        }
-        return parts as [string, string];
+    .map((chunk): [string, string] => {
+      const parts = chunk.split('=');
+      if (parts.length < 2) {
+        parts[1] = '';
+      } else {
+        parts[1] = decodeURIComponent(parts[1]);
       }
-    )
+      return parts as [string, string];
+    })
     .reduce<{ [key: string]: string }>((c, x) => {
       c[x[0]] = x[1];
       return c;