From dd9b7d46acea05fc6be0df784b0f4bc459714727 Mon Sep 17 00:00:00 2001 From: Sergey Date: Sat, 12 Jan 2019 01:15:50 +0500 Subject: [PATCH 1/2] telegram: increase coverage --- backend/app/notify/telegram_test.go | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/backend/app/notify/telegram_test.go b/backend/app/notify/telegram_test.go index c90caf63..5474fa6c 100644 --- a/backend/app/notify/telegram_test.go +++ b/backend/app/notify/telegram_test.go @@ -36,6 +36,12 @@ func TestTelegram_New(t *testing.T) { _, err = NewTelegram("no-such-thing", "remark_test", 2*time.Second, "http://127.0.0.1:4321/") assert.EqualError(t, err, "can't initialize telegram notifications: Get http://127.0.0.1:4321/no-such-thing/getMe: dial tcp 127.0.0.1:4321: connect: connection refused") + + _, err = NewTelegram("good-token", "remark_test", 2*time.Second, "") + assert.Error(t, err) + + _, err = NewTelegram("good-token", "remark_test", 0, ts.URL+"/") + assert.NoError(t, err) } func TestTelegram_Send(t *testing.T) { @@ -50,10 +56,15 @@ func TestTelegram_Send(t *testing.T) { cp := store.Comment{Text: "some parent text"} cp.User.Name = "to" + err = tb.Send(context.TODO(), request{comment: c, parent: cp}) + assert.NoError(t, err) + c.PostTitle = "test title" err = tb.Send(context.TODO(), request{comment: c, parent: cp}) assert.NoError(t, err) - assert.Equal(t, "telegram: remark_test", tb.String()) + tb, _ = NewTelegram("non-json-resp", "remark_test", 2*time.Second, ts.URL+"/") + err = tb.Send(context.TODO(), request{comment: c, parent: cp}) + assert.Contains(t, err.Error(), "unexpected telegram status code 404") } func mockTelegramServer() *httptest.Server { From c08a31809c7f44cb3a7afdb5a86cf1cce030c030 Mon Sep 17 00:00:00 2001 From: Sergey Date: Sat, 12 Jan 2019 01:22:08 +0500 Subject: [PATCH 2/2] moving back assert.equal --- backend/app/notify/telegram_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/backend/app/notify/telegram_test.go b/backend/app/notify/telegram_test.go index 5474fa6c..1f669bbb 100644 --- a/backend/app/notify/telegram_test.go +++ b/backend/app/notify/telegram_test.go @@ -65,6 +65,8 @@ func TestTelegram_Send(t *testing.T) { tb, _ = NewTelegram("non-json-resp", "remark_test", 2*time.Second, ts.URL+"/") err = tb.Send(context.TODO(), request{comment: c, parent: cp}) assert.Contains(t, err.Error(), "unexpected telegram status code 404") + + assert.Equal(t, "telegram: remark_test", tb.String()) } func mockTelegramServer() *httptest.Server {