From cdda2d0319cc0a611a77e194925b7c33a3421c8f Mon Sep 17 00:00:00 2001 From: Quan Anh Tong Date: Mon, 13 Apr 2020 20:11:32 +0700 Subject: [PATCH 1/2] the correct GOARCH value is arm, not arm32 --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 8415016b..3430cbdf 100644 --- a/README.md +++ b/README.md @@ -97,7 +97,7 @@ _this is the recommended way to run remark42_ * download archive for [stable release](https://github.com/umputun/remark/releases) or [development version](https://remark42.com/downloads) * unpack with `gunzip` (Linux, macOS) or with `zip` (Windows) * run as `remark42.{os}-{arch} server {parameters...}`, i.e. `remark42.linux-amd64 server --secret=12345 --url=http://127.0.0.1:8080` -* alternatively compile from the sources - `make OS=[linux|darwin|windows] ARCH=[amd64,386,arm64,arm32]` +* alternatively compile from the sources - `make OS=[linux|darwin|windows] ARCH=[amd64,386,arm64,arm]` #### Parameters From 7ebea0ca9d79d84e98e2aa62e143ef39b82f3af9 Mon Sep 17 00:00:00 2001 From: Quan Anh Tong Date: Mon, 13 Apr 2020 20:20:02 +0700 Subject: [PATCH 2/2] Revert "fix artifact filename on arm32" This reverts commit 2e47fde46e5e919ece258b8d50bd5201bc338057. --- Dockerfile.artifacts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile.artifacts b/Dockerfile.artifacts index 50e74dde..1b8bb59f 100644 --- a/Dockerfile.artifacts +++ b/Dockerfile.artifacts @@ -59,7 +59,7 @@ RUN \ export GOFLAGS="-mod=vendor" && \ GOOS=linux GOARCH=amd64 go build -o remark42.linux-amd64 -ldflags "-X main.revision=${version} -s -w" ./app && \ GOOS=linux GOARCH=386 go build -o remark42.linux-386 -ldflags "-X main.revision=${version} -s -w" ./app && \ - GOOS=linux GOARCH=arm go build -o remark42.linux-arm32 -ldflags "-X main.revision=${version} -s -w" ./app && \ + GOOS=linux GOARCH=arm go build -o remark42.linux-arm -ldflags "-X main.revision=${version} -s -w" ./app && \ GOOS=linux GOARCH=arm64 go build -o remark42.linux-arm64 -ldflags "-X main.revision=${version} -s -w" ./app && \ GOOS=windows GOARCH=amd64 go build -o remark42.windows-amd64.exe -ldflags "-X main.revision=${version} -s -w" ./app && \ GOOS=darwin GOARCH=amd64 go build -o remark42.darwin-amd64 -ldflags "-X main.revision=${version} -s -w" ./app && \ @@ -73,7 +73,7 @@ RUN \ cp ../LICENSE ./LICENSE && cp ../README.md ./README.md && \ tar cvzf remark42${tag}.linux-amd64.tar.gz remark42.linux-amd64 LICENSE README.md && \ tar cvzf remark42${tag}.linux-386.tar.gz remark42.linux-386 LICENSE README.md && \ - tar cvzf remark42${tag}.linux-arm32.tar.gz remark42.linux-arm32 LICENSE README.md && \ + tar cvzf remark42${tag}.linux-arm.tar.gz remark42.linux-arm LICENSE README.md && \ tar cvzf remark42${tag}.linux-arm64.tar.gz remark42.linux-arm64 LICENSE README.md && \ tar cvzf remark42${tag}.darwin-amd64.tar.gz remark42.darwin-amd64 LICENSE README.md && \ tar cvzf remark42${tag}.freebsd-amd64.tar.gz remark42.freebsd-amd64 LICENSE README.md && \