3 Commits

Include renames

Author	SHA1	Message	Date
Dmitry VerkhoturovandGitHub	b6975af63c	Fix collapsed threads not restoring, and the clock skew correction (#2188) ... * Fix collapsed threads not restoring, and the clock skew correction Collapse state was kept as a flat list of `siteID_url_commentID` strings and read back by splitting on `_`. Any underscore in the url, the site id or the comment id made the pieces impossible to tell apart, so a page whose url contains one lost its collapsed threads on every reload, and one page's entries could be read or deleted as another's: `/post` matched everything stored for `/post_2`, and a site id of `blog` matched `blog_ru`. No separator fixes that, since every candidate can occur inside the values, so the ids are now nested under the site and the url instead. Anything stored in the old shape reads as empty: collapsed threads are a view preference, and re-expanding them once is not worth a migration. The e2e suite had been stripping underscores out of its own thread urls to work around this, which left its collapse test unable to fail on the bug it covers. That workaround is gone, and the test now fails without this fix. `serverClientTimeDiff` was written in seconds and added to an epoch in milliseconds, so the correction it exists to apply was a thousandth of the real skew. It is now milliseconds, and named for the unit. A response with no usable `date` used to fall back to a zero timestamp, which already made the "skew" about twenty days and would have made it fifty-five years once the units were right. Nothing is stored now unless the reading is plausible, since `Date.parse` is lenient enough to turn junk into a date and let an absurd value through the branch that parses. The score tooltip reports controversy again when there is any. It has been dead since the vote component was rewritten in 0e4ae6e0, which moved the score into its own component and left the line behind commented out; the value has been passed in and dropped ever since. Unlike the original it stays out of the way when there is no controversy, which the backend sends as an absent field rather than a zero. * Drop the nested frontend dockerignore Docker reads `.dockerignore` from the build context root only, and nothing builds from `frontend/`: every context in the repo is the repository root, apart from the site, which has its own. There is no Dockerfile under `frontend/` any more either. So the file was never consulted, and both lines it carried, `/.vscode/` and `/.idea/`, are already in the root `.dockerignore` verbatim.	2026-08-21 22:12:19 -05:00
Dmitry VerkhoturovandGitHub	a0879b2336	Measure the iframe reveal budgets from inside the page (#2189) ... The three reveal tests timed their budgets from before `page.Goto`, so a slow navigation was spent against a window that belongs to the iframe. In `TestIframe_StaysHiddenUntilTheDocumentReportsInited` that made the test vacuous rather than flaky: on a navigation between 2.5 and 5 seconds the loop bounding the visibility assertion had no budget left, ran zero times, and the test passed having asserted nothing. Reproduced by delaying the demo document by three seconds, where the assertion ran 0 times before and runs 23 after. The timeout test had the mirror of it, with navigation counting toward the lower bound that exists to catch a shortened fallback. An init script now records, in the page, when the widget's iframe element enters the document and when its visibility first flips. `create-iframe.ts` arms its fallback a moment earlier, on the detached element, so these read a shade short and every bound is conservative in the same direction. Both bounds were also wider than the thing they guard. The hidden window now runs almost to the fallback rather than half of it, and the lower bound sits just under it rather than at three quarters, which a fallback shortened to four seconds used to clear. CI reruns a failing test once rather than failing the build on the first flake. A browser suite has a floor no amount of care removes, and one flake failing the build is what stops people trusting the suite. Once rather than twice, because a rerun stops at the first pass and each further attempt only widens the window where a real intermittent regression is absorbed. What needed a rerun is written to a report and uploaded with the traces, which are kept whether or not the job went green: a run that recovered on the rerun is exactly the one whose evidence used to be discarded.	2026-08-21 22:05:51 -05:00
Dmitry VerkhoturovandGitHub	ff77f41a3a	Move the e2e suite to Go and playwright-go (#2180) ... * Move the e2e suite to Go and playwright-go The seven playwright tests in `frontend/e2e` become twenty in `e2e/`, a separate Go module driving the same browsers through playwright-go. The npm project, its lockfile entries, its prettier config and `Dockerfile.e2e` go with it, leaving `frontend/` a single-member workspace. The suite covers posting with markdown, replying and the nesting that implies, editing inside the deadline and the backend refusing one outside it, deleting, voting with the optimistic score observed mid-flight and rolled back on failure, changing the sort, collapse persistence across a reload, dev, anonymous and email sign-in end to end, the profile iframe, and the two scripts that render into the host page rather than the widget's own frame. The rendering tests run in chromium, firefox and webkit. The rest sign in, sign-in needs the dev oauth2 provider, and reaching that by name from the host is chromium-only, so they run there alone. `compose-e2e-test.yml` runs remark42, a second instance with a short edit window so that path does not need a five-minute test, and mailpit, which catches the email verification message the suite reads back. Everything binds to the loopback interface: the stack holds a known secret and an admin shared id, and `go test` can start it unattended. The tests run on the host rather than in a container. Three settings there exist for the tests rather than for realism. `REMARK_URL` uses a hostname because the dev oauth2 server binds whatever host it reads out of it, and a loopback bind inside a container cannot be published. `UPDATE_LIMIT` is raised because the default of 0.5/sec rejects any test posting twice in a row. The suite also paces its own `/auth/` calls, which are capped at 2/sec by a bare literal in `rest.go` rather than by a setting. Each test gets its own comment thread from a query string on the demo page, so nothing has to reset the database between runs. CI gains a vet and lint job for the module, since the build tag keeps it out of a plain `go test ./...`, and uploads a browser trace for any test that fails. `e2e/README.md` carries the rest: how to run it, what the stack is for, and the widget behaviour the assertions have to work around. * Update golangci-lint to 2.13.1 in the backend workflow The pin sat three minors behind what the linter installs locally, so CI checked the backend with an older set of rules than anyone running it by hand. 2.10.1 also fetches its config schema over the network on every `config verify`, which is a failure mode with no bearing on the code. Both targets are clean on 2.13.1, `backend/app` and the memory_store example.	2026-08-21 17:53:12 -05:00