@paskal
* sort imports, add missing copyright
* regenerate engine mock
* make all image.Store interface functions public
* go mod tidy
* make image.Store.Load return []byte instead of io.ReadCloser
* separate memory_store example RPC server to multiple files by handlers groups
* fix potential race on close
* move validate inside
* demote commit and cleanup in image.Store to non-exposed functions.
* replace immediate image commit with delayed via Submit
* minor: remove error logging, rename tests
* minor: err wrapping, comments wording
* clarify FileSystem.Save code
* attempt to fix#584 by making submitted image commits on a half of TTL
Co-authored-by: Dmitry Verkhoturov <paskal.07@gmail.com>
* add subscription link support to notification email verification template
* always show token for email subscription in verification email
* hide SubscribeURL from users
* Update email templates
* Fix README
* fix detail
* fix typo
* Changes connected with comment at issue
https://github.com/umputun/remark/issues/494#issuecomment-570801318
* Unify styles between templates
* remove breaking words
* use the same prefix for parent and child
* move SMTP settings to separate group
* move deprecated options in separate section in readme
* adjust variables in docker-compose
* add description to SmtpGroup
* remove SMTP option setting which is already set to same value
* remove smtp port default for consistency
* add server deprecated functions handling
* satisfy linter
* add missing bracket in description
* add test for handleDeprecatedFlags
* add HandleDeprecatedFlags function to CommonOptionsCommander
* improve HandleDeprecatedFlags behavior
* add missing result check to ServerCommand.HandleDeprecatedFlags
* replace store.Locator with SiteID where only it is used
* add EmailSubscription flag to User information
* add /user endpoint test for email subscription
* increase timeout for TestServerAuthHooks http client
* replace assert.Equal checks for slice length with require.Equal
* unify channel name across tests
* fix panic in Test_Main
* increase TestRest_CreateWithPictures timeout for HDD slowness
* increase TestService_VoteSameIPWithDuration timeout for HDD slowness
* increase go test timeout for HDD run
* increase TestRest_CreateWithPictures timeout for HDD slowness
* improve TestServer* reliability
* improve TestService_UserReplies reliability
* increase timeout for Test_Main
* improve TestRest_CreateWithPictures readability and reliability
* introduce random port to REST over SSL tests
* tinker TestRest_InfoStreamSince to have more slack before failure
* finalize test errors check unification
* simplify prepServerApp in cmd package tests
* improve TestRest_InfoStreamCancel reliability
* adjust TestServerApp_WithSSL to use sslPort in all test checks
* make Test_Main reliable and remove 5s sleep
* make test finishing reliable using "done" channel for TestServerApp*
* explicitly ignore error from test connection close
* add client with timeout to places which used default http client
* move random port creation and waiting for server in separate function for reuse
* improve TestServer tests robustness
* move all server waiting code in tests to separate functions
* change chooseRandomUnusedPort to try to listen to port before return
* fix waitForHTTPSServerStart
* move email unsubscription page outside of API and make it HTML
* make separate HTML template for SendErrorHTML
* fix error template name
* add test for SendErrorHTML, introduce MustExecute function
* fix content check in test of TestSendErrorHTML
* fix logging test to be more generic and not depend on line numbers