package api import ( "bytes" "crypto/tls" "encoding/json" "fmt" "io" "math/rand" "net" "net/http" "net/http/httptest" "os" "strconv" "strings" "testing" "time" "github.com/go-pkgz/auth/v2" "github.com/go-pkgz/auth/v2/avatar" "github.com/go-pkgz/auth/v2/provider" "github.com/go-pkgz/auth/v2/token" cache "github.com/go-pkgz/lcw/v2" R "github.com/go-pkgz/rest" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" bolt "go.etcd.io/bbolt" "go.uber.org/goleak" "github.com/umputun/remark42/backend/app/migrator" "github.com/umputun/remark42/backend/app/notify" "github.com/umputun/remark42/backend/app/rest" "github.com/umputun/remark42/backend/app/rest/proxy" "github.com/umputun/remark42/backend/app/store" adminstore "github.com/umputun/remark42/backend/app/store/admin" "github.com/umputun/remark42/backend/app/store/engine" "github.com/umputun/remark42/backend/app/store/image" "github.com/umputun/remark42/backend/app/store/service" ) // To generate a token, enter one of the tokens here into https://jwt.io, change the secret to one you're using in your test // ("secret" in case of startupT), and alter the fields you want to be changed. var devToken = `eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZW1hcms0MiIsImV4cCI6Mzc4OTE5MTgyMiwianRpIjoicmFuZG9tIGlkIiwiaXNzIjoicmVtYXJrNDIiLCJuYmYiOjE1MjE4ODQyMjIsInVzZXIiOnsibmFtZSI6ImRldmVsb3BlciBvbmUiLCJpZCI6InByb3ZpZGVyMV9kZXYiLCJwaWN0dXJlIjoiaHR0cDovL2V4YW1wbGUuY29tL3BpYy5wbmciLCJpcCI6IjEyNy4wLjAuMSIsImVtYWlsIjoibWVAZXhhbXBsZS5jb20ifX0.dirTS_ahSF6375sdO2iodm2K2UmRTzQNQMFiHuTQCVs` var dev2Token = `eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZW1hcms0MiIsImV4cCI6Mzc4OTE5MTgyMiwianRpIjoicmFuZG9tIGlkIiwiaXNzIjoicmVtYXJrNDIiLCJuYmYiOjE1MjE4ODQyMjIsInVzZXIiOnsibmFtZSI6ImRldmVsb3BlciBvbmUiLCJpZCI6InByb3ZpZGVyMV9kZXYyIiwicGljdHVyZSI6Imh0dHA6Ly9leGFtcGxlLmNvbS9waWMucG5nIiwiaXAiOiIxMjcuMC4wLjEiLCJlbWFpbCI6Im1lQGV4YW1wbGUuY29tIn19.qsR_PupfjIq7uw0eAuyGV8nsUoMx9v541c9olnRInRQ` var anonToken = `eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZW1hcms0MiIsImV4cCI6Mzc4OTE5MTgyMiwianRpIjoicmFuZG9tIGlkIiwiaXNzIjoicmVtYXJrNDIiLCJuYmYiOjE1MjE4ODQyMjIsInVzZXIiOnsibmFtZSI6ImFub255bW91cyB0ZXN0IHVzZXIiLCJpZCI6ImFub255bW91c190ZXN0X3VzZXIiLCJwaWN0dXJlIjoiaHR0cDovL2V4YW1wbGUuY29tL3BpYy5wbmciLCJpcCI6IjEyNy4wLjAuMSIsImVtYWlsIjoiYW5vbkBleGFtcGxlLmNvbSJ9fQ.gAae2WMxZNZE5ebVboptPEyQ7Nk6EQxciNnGJ_mPOuU` var emailUserToken = `eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZW1hcms0MiIsImV4cCI6Mzc4OTE5MTgyMiwianRpIjoicmFuZG9tIGlkIiwiaXNzIjoicmVtYXJrNDIiLCJuYmYiOjE1MjE4ODQyMjIsInVzZXIiOnsibmFtZSI6Imdvb2RAZXhhbXBsZS5jb20gdGVzdCB1c2VyIiwiaWQiOiJlbWFpbF9mNWRmZTlkMmU2YmQ3NWZjNzRlYTVmYWJmMjczYjQ1YjViYWViMTk1IiwicGljdHVyZSI6Imh0dHA6Ly9leGFtcGxlLmNvbS9waWMucG5nIiwiaXAiOiIxMjcuMC4wLjEiLCJlbWFpbCI6Imdvb2RAZXhhbXBsZS5jb20ifX0.vH2HN1JpuXL8okTJq1A-zGHQ-l2ILcwxvDDEmu2zwks` var devTokenBadAud = `eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZW1hcms0Ml9iYWQiLCJleHAiOjM3ODkxOTE4MjIsImp0aSI6InJhbmRvbSBpZCIsImlzcyI6InJlbWFyazQyIiwibmJmIjoxNTIxODg0MjIyLCJ1c2VyIjp7Im5hbWUiOiJkZXZlbG9wZXIgb25lIiwiaWQiOiJwcm92aWRlcjFfZGV2IiwicGljdHVyZSI6Imh0dHA6Ly9leGFtcGxlLmNvbS9waWMucG5nIiwiaXAiOiIxMjcuMC4wLjEiLCJlbWFpbCI6Im1lQGV4YW1wbGUuY29tIn19.X-lvnHvBz6VfEbVV4f-bjcZuLY5pYtvEansk_TQMrX8` var adminUmputunToken = `eyJhbGciOiJIUzI1NiJ9.eyJhdWQiOiJyZW1hcms0MiIsImV4cCI6MTk1NDU5Nzk4MCwianRpIjoiOTdhMmUwYWM0ZGM3ZDVmNjkyNmQ1ZTg2MjBhY2VmOWE0MGMwIiwiaWF0IjoxNDU0NTk3NjgwLCJpc3MiOiJyZW1hcms0MiIsInVzZXIiOnsibmFtZSI6IlVtcHV0dW4iLCJpZCI6ImdpdGh1Yl9lZjBmNzA2YTciLCJwaWN0dXJlIjoiaHR0cHM6Ly9yZW1hcms0Mi5yYWRpby10LmNvbS9hcGkvdjEvYXZhdGFyL2NiNDJmZjQ5M2FkZTY5NmQ4OGEzYTU5MGYxMzZhZTllMzRkZTdjMWIuaW1hZ2UiLCJhdHRycyI6eyJhZG1pbiI6dHJ1ZSwiYmxvY2tlZCI6ZmFsc2V9fX0.dZiOjWHguo9f42XCMooMcv4EmYFzifl_-LEvPZHCtks` func TestRest_FileServer(t *testing.T) { ts, _, teardown := startupT(t) defer teardown() testHTMLName := "test-remark.html" testHTMLFile := os.TempDir() + "/" + testHTMLName err := os.WriteFile(testHTMLFile, []byte("some html"), 0o700) assert.NoError(t, err) body, code := get(t, ts.URL+"/web/"+testHTMLName) assert.Equal(t, http.StatusOK, code) assert.Equal(t, "some html", body) _ = os.Remove(testHTMLFile) } func TestRest_Shutdown(t *testing.T) { srv := Rest{Authenticator: &auth.Service{}, ImageProxy: &proxy.Image{}} done := make(chan bool) // without waiting for channel close at the end goroutine will stay alive after test finish // which would create data race with next test go func() { time.Sleep(200 * time.Millisecond) srv.Shutdown() close(done) }() st := time.Now() srv.Run("127.0.0.1", 0) assert.True(t, time.Since(st).Seconds() < 1, "should take about 100ms") <-done } func TestRest_filterComments(t *testing.T) { user := store.User{ID: "user1", Name: "user name 1"} c1 := store.Comment{User: user, Text: "test test #1", Locator: store.Locator{SiteID: "radio-t", URL: "https://radio-t.com/blah1"}, Timestamp: time.Date(2018, 5, 27, 1, 14, 10, 0, time.Local)} c2 := store.Comment{User: user, Text: "test test #2", ParentID: "p1", Locator: store.Locator{SiteID: "radio-t", URL: "https://radio-t.com/blah1"}, Timestamp: time.Date(2018, 5, 27, 1, 14, 20, 0, time.Local)} c3 := store.Comment{User: user, Text: "test test #3", ParentID: "p1", Locator: store.Locator{SiteID: "radio-t", URL: "https://radio-t.com/blah1"}, Timestamp: time.Date(2018, 5, 27, 1, 14, 25, 0, time.Local)} r := filterComments([]store.Comment{c1, c2, c3}, func(c store.Comment) bool { return c.Text == "test test #1" || c.Text == "test test #3" }) assert.Equal(t, 2, len(r), "one comment filtered") } func TestRest_RunStaticSSLMode(t *testing.T) { sslPort := chooseRandomUnusedPort() srv := Rest{ Authenticator: auth.NewService(auth.Opts{ AvatarStore: avatar.NewLocalFS("/tmp"), AvatarResizeLimit: 300, }), ImageProxy: &proxy.Image{}, SSLConfig: SSLConfig{ SSLMode: Static, Port: sslPort, Key: "../../cmd/testdata/key.pem", Cert: "../../cmd/testdata/cert.pem", }, RemarkURL: fmt.Sprintf("https://localhost:%d", sslPort), } port := chooseRandomUnusedPort() go func() { srv.Run("", port) }() waitForHTTPSServerStart(sslPort) client := http.Client{ // prevent http redirect CheckRedirect: func(*http.Request, []*http.Request) error { return http.ErrUseLastResponse }, // allow self-signed certificate Transport: &http.Transport{ TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, }, } defer client.CloseIdleConnections() resp, err := client.Get(fmt.Sprintf("http://localhost:%d/blah?param=1", port)) require.NoError(t, err) defer resp.Body.Close() assert.Equal(t, http.StatusTemporaryRedirect, resp.StatusCode) assert.Equal(t, fmt.Sprintf("https://localhost:%d/blah?param=1", sslPort), resp.Header.Get("Location")) resp, err = client.Get(fmt.Sprintf("https://localhost:%d/ping", sslPort)) require.NoError(t, err) defer resp.Body.Close() assert.Equal(t, http.StatusOK, resp.StatusCode) body, err := io.ReadAll(resp.Body) assert.NoError(t, err) assert.Equal(t, "pong", string(body)) srv.Shutdown() } func TestRest_RunAutocertModeHTTPOnly(t *testing.T) { sslPort := chooseRandomUnusedPort() srv := Rest{ Authenticator: &auth.Service{}, ImageProxy: &proxy.Image{}, SSLConfig: SSLConfig{ SSLMode: Auto, Port: sslPort, }, RemarkURL: fmt.Sprintf("https://localhost:%d", sslPort), } port := chooseRandomUnusedPort() go func() { // can't check https server locally, just only http server srv.Run("", port) }() waitForHTTPSServerStart(sslPort) client := http.Client{ // prevent http redirect CheckRedirect: func(*http.Request, []*http.Request) error { return http.ErrUseLastResponse }, } defer client.CloseIdleConnections() resp, err := client.Get(fmt.Sprintf("http://localhost:%d/blah?param=1", port)) require.NoError(t, err) defer resp.Body.Close() assert.Equal(t, http.StatusTemporaryRedirect, resp.StatusCode) assert.Equal(t, fmt.Sprintf("https://localhost:%d/blah?param=1", sslPort), resp.Header.Get("Location")) srv.Shutdown() } func TestRest_rejectAnonUser(t *testing.T) { ts := httptest.NewServer(fakeAuth(rejectAnonUser(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) { fmt.Fprintln(w, "Hello") })))) defer ts.Close() resp, err := http.Get(ts.URL) require.NoError(t, err) require.NoError(t, resp.Body.Close()) assert.Equal(t, http.StatusUnauthorized, resp.StatusCode, "use not logged in") resp, err = http.Get(ts.URL + "?fake_id=anonymous_user123&fake_name=test") require.NoError(t, err) require.NoError(t, resp.Body.Close()) assert.Equal(t, http.StatusForbidden, resp.StatusCode, "anon rejected") resp, err = http.Get(ts.URL + "?fake_id=real_user123&fake_name=test") require.NoError(t, err) require.NoError(t, resp.Body.Close()) assert.Equal(t, http.StatusOK, resp.StatusCode, "real user") } func Test_URLKey(t *testing.T) { tbl := []struct { url string user store.User key string }{ {"http://example.com/1", store.User{}, "http://example.com/1"}, {"http://example.com/1", store.User{ID: "user"}, "http://example.com/1"}, {"http://example.com/1", store.User{ID: "user", Admin: true}, "admin!!http://example.com/1"}, } for i, tt := range tbl { t.Run(strconv.Itoa(i), func(t *testing.T) { r, err := http.NewRequest("GET", tt.url, http.NoBody) require.NoError(t, err) if tt.user.ID != "" { r = rest.SetUserInfo(r, tt.user) } assert.Equal(t, tt.key, URLKey(r)) }) } } func Test_URLKeyWithUser(t *testing.T) { tbl := []struct { url string user store.User key string }{ {"http://example.com/1", store.User{}, "http://example.com/1"}, {"http://example.com/1", store.User{ID: "user"}, "user!!http://example.com/1"}, {"http://example.com/2", store.User{ID: "user2"}, "user2!!http://example.com/2"}, {"http://example.com/1", store.User{ID: "user", Admin: true}, "admin!!user!!http://example.com/1"}, } for i, tt := range tbl { t.Run(strconv.Itoa(i), func(t *testing.T) { r, err := http.NewRequest("GET", tt.url, http.NoBody) require.NoError(t, err) if tt.user.ID != "" { r = rest.SetUserInfo(r, tt.user) } assert.Equal(t, tt.key, URLKeyWithUser(r)) }) } } func TestRest_parseError(t *testing.T) { tbl := []struct { err error res int }{ {fmt.Errorf("can not vote for his own comment"), rest.ErrVoteSelf}, {fmt.Errorf("already voted for"), rest.ErrVoteDbl}, {fmt.Errorf("maximum number of votes exceeded for comment"), rest.ErrVoteMax}, {fmt.Errorf("minimal score reached for comment"), rest.ErrVoteMinScore}, {fmt.Errorf("too late to edit"), rest.ErrCommentEditExpired}, {fmt.Errorf("parent comment with reply can't be edited"), rest.ErrCommentEditChanged}, {fmt.Errorf("blah blah"), rest.ErrInternal}, } for n, tt := range tbl { t.Run(strconv.Itoa(n), func(t *testing.T) { res := parseError(tt.err, rest.ErrInternal) assert.Equal(t, tt.res, res) }) } } func TestRest_cacheControl(t *testing.T) { tbl := []struct { url string version string exp time.Duration etag string maxAge int }{ {"http://example.com/foo", "v1", time.Hour, "b433be1ea19edaee9dc92ca4b895b6bdf3c058cb", 3600}, {"http://example.com/foo2", "v1", 10 * time.Hour, "6d8466aef3246c1057452561acddf7ad9d0d99e0", 36000}, {"http://example.com/foo", "v2", time.Hour, "481700c52aab0dfbca99f3ffc2a4fbb27884c114", 3600}, {"https://example.com/foo", "v2", time.Hour, "bebd4f1b87f474792c4e75e5affe31fbf67f5778", 3600}, } for i, tt := range tbl { t.Run(strconv.Itoa(i), func(t *testing.T) { req := httptest.NewRequest("GET", tt.url, http.NoBody) w := httptest.NewRecorder() h := cacheControl(tt.exp, tt.version)(http.HandlerFunc(func(http.ResponseWriter, *http.Request) {})) h.ServeHTTP(w, req) resp := w.Result() assert.Equal(t, http.StatusOK, resp.StatusCode) assert.NoError(t, resp.Body.Close()) t.Logf("%+v", resp.Header) assert.Equal(t, `"`+tt.etag+`"`, resp.Header.Get("Etag")) assert.Equal(t, `max-age=`+strconv.Itoa(int(tt.exp.Seconds()))+", no-cache", resp.Header.Get("Cache-Control")) }) } } func TestRest_frameAncestors(t *testing.T) { ts, _, teardown := startupT(t, func(o *Rest) { o.AllowedAncestors = []string{"'self'", "https://example.com"} }) // test case with frame-ancestors client := http.Client{} resp, err := client.Get(ts.URL + "/web/index.html") require.NoError(t, err) defer resp.Body.Close() assert.Equal(t, http.StatusOK, resp.StatusCode) assert.Contains(t, resp.Header.Get("Content-Security-Policy"), "frame-ancestors 'self' https://example.com;") teardown() // test case without frame-ancestors ts, _, teardown = startupT(t, func(srv *Rest) { srv.AllowedAncestors = []string{} }) defer teardown() resp, err = client.Get(ts.URL + "/web/index.html") require.NoError(t, err) defer resp.Body.Close() assert.Equal(t, http.StatusOK, resp.StatusCode) assert.Contains(t, resp.Header.Get("Content-Security-Policy"), "frame-ancestors *;") } // check CSP, img-src should be 'self' with proxy enabled and * without it func TestRest_securityHeaders(t *testing.T) { ts, _, teardown := startupT(t) // with proxy disabled client := http.Client{} resp, err := client.Get(ts.URL + "/web/index.html") require.NoError(t, err) defer resp.Body.Close() assert.Equal(t, http.StatusOK, resp.StatusCode) assert.Contains(t, resp.Header.Get("Content-Security-Policy"), "img-src *;") assert.Equal(t, "nosniff", resp.Header.Get("X-Content-Type-Options")) assert.Equal(t, "strict-origin-when-cross-origin", resp.Header.Get("Referrer-Policy")) teardown() // check CSP with proxy enabled ts, _, teardown = startupT(t, func(srv *Rest) { srv.ExternalImageProxy = true }) defer teardown() resp, err = client.Get(ts.URL + "/web/index.html") require.NoError(t, err) defer resp.Body.Close() assert.Equal(t, http.StatusOK, resp.StatusCode) assert.Contains(t, resp.Header.Get("Content-Security-Policy"), "img-src 'self';") assert.Equal(t, "nosniff", resp.Header.Get("X-Content-Type-Options")) assert.Equal(t, "strict-origin-when-cross-origin", resp.Header.Get("Referrer-Policy")) } func TestRest_subscribersOnly(t *testing.T) { paidSubUser := &token.User{} paidSubUser.SetPaidSub(true) tbl := []struct { subsOnly bool user token.User setUser bool status int }{ {true, token.User{}, false, http.StatusUnauthorized}, {true, token.User{}, true, http.StatusForbidden}, {false, token.User{}, false, http.StatusOK}, {false, token.User{}, true, http.StatusOK}, {true, *paidSubUser, true, http.StatusOK}, } for i, tt := range tbl { t.Run(strconv.Itoa(i), func(t *testing.T) { req := httptest.NewRequest("GET", "http://example.com", http.NoBody) if tt.setUser { req = token.SetUserInfo(req, tt.user) } w := httptest.NewRecorder() h := subscribersOnly(tt.subsOnly)(http.HandlerFunc(func(http.ResponseWriter, *http.Request) {})) h.ServeHTTP(w, req) resp := w.Result() assert.Equal(t, tt.status, resp.StatusCode) assert.NoError(t, resp.Body.Close()) }) } } func Test_validEmailAuth(t *testing.T) { tbl := []struct { req string status int }{ {"/auth/email/login?site=remark42&address=umputun%example.com&user=someone", http.StatusOK}, {"/auth/email/login?site=site-with-dash_and_underscore-and.dot&address=umputun%example.com&user=someone", http.StatusOK}, {"/auth/email/login?site=remark42&address=umputun%example.com&user=someone+blah", http.StatusOK}, {"/auth/email/login?site=remark42&address=umputun%example.com&user=Евгений+Умпутун", http.StatusOK}, {"/auth/email/login?site=remark42&address=umputun%example.com&user=12", http.StatusForbidden}, {"/auth/email/login?site=remark42&address=umputun%example.com&user=..blah+blah", http.StatusForbidden}, {"/auth/email/login?site=remark42&address=umputun%example.com&user=someonelooong+loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong", http.StatusForbidden}, {"/auth/twitter/login?site=remark42&address=umputun%example.com&user=..blah+blah", http.StatusOK}, {"/auth/email/login?site=remark42&address=umputun%example.com", http.StatusOK}, {"/auth/email/login?site=remark42&address=umputun+example.com&user=someone", http.StatusForbidden}, {"/auth/email/login?site=bad!site&address=umputun%example.com&user=someone", http.StatusForbidden}, {"/auth/email/login?site=loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongsite&address=umputun%example.com&user=someone", http.StatusForbidden}, } for i, tt := range tbl { t.Run(strconv.Itoa(i), func(t *testing.T) { req := httptest.NewRequest("GET", "http://example.com"+tt.req, http.NoBody) w := httptest.NewRecorder() h := validEmailAuth()(http.HandlerFunc(func(http.ResponseWriter, *http.Request) {})) h.ServeHTTP(w, req) resp := w.Result() assert.Equal(t, tt.status, resp.StatusCode) assert.NoError(t, resp.Body.Close()) }) } } // randomPath pick a file or folder name which is not in use for sure func randomPath(tempDir, basename, suffix string) (string, error) { for range 10 { fname := fmt.Sprintf("/%s/%s-%d%s", tempDir, basename, rand.Int31(), suffix) fmt.Printf("fname %q", fname) _, err := os.Stat(fname) if err != nil { return fname, nil } } return "", fmt.Errorf("cannot create temp file in %s", tempDir) } // startupT runs fully configured testing server // srvHook is an optional func to set some Rest param after the creation but prior to Run func startupT(t *testing.T, srvHook ...func(srv *Rest)) (ts *httptest.Server, srv *Rest, teardown func()) { tmp := os.TempDir() testDB, err := randomPath(tmp, "test-remark", ".db") require.NoError(t, err) _ = os.RemoveAll(tmp + "/ava-remark42") _ = os.RemoveAll(tmp + "/pics-remark42") b, err := engine.NewBoltDB(bolt.Options{}, engine.BoltSite{FileName: testDB, SiteID: "remark42"}) require.NoError(t, err) memCache := cache.NewScache[[]byte](cache.NewNopCache[[]byte]()) astore := adminstore.NewStaticStore("123456", []string{"remark42"}, []string{"a1", "a2"}, "admin@remark-42.com") restrictedWordsMatcher := service.NewRestrictedWordsMatcher(service.StaticRestrictedWordsLister{Words: []string{"duck"}}) dataStore := &service.DataStore{ Engine: b, EditDuration: 5 * time.Minute, MaxCommentSize: 4000, AdminStore: astore, MaxVotes: service.UnlimitedVotes, RestrictedWordsMatcher: restrictedWordsMatcher, } remarkURL := "https://demo.remark42.com" srv = &Rest{ DataService: dataStore, Authenticator: auth.NewService(auth.Opts{ AdminPasswd: "password", SecretReader: token.SecretFunc(func(string) (string, error) { return "secret", nil }), AvatarStore: avatar.NewLocalFS(tmp + "/ava-remark42"), }), Cache: memCache, WebRoot: tmp, RemarkURL: remarkURL, ImageService: image.NewService(&image.FileSystem{ Location: tmp + "/pics-remark42", Partitions: 100, Staging: tmp + "/pics-remark42/staging", }, image.ServiceParams{ EditDuration: 100 * time.Millisecond, ImageAPI: remarkURL + "/api/v1/picture/", ProxyAPI: remarkURL + "/api/v1/img", MaxSize: 10000, }), ImageProxy: &proxy.Image{}, ReadOnlyAge: 10, CommentFormatter: store.NewCommentFormatter(&proxy.Image{}), Migrator: &Migrator{ DisqusImporter: &migrator.Disqus{DataStore: dataStore}, WordPressImporter: &migrator.WordPress{DataStore: dataStore}, CommentoImporter: &migrator.Commento{DataStore: dataStore}, NativeImporter: &migrator.Native{DataStore: dataStore}, NativeExporter: &migrator.Native{DataStore: dataStore}, URLMapperMaker: migrator.NewURLMapper, Cache: memCache, KeyStore: astore, }, NotifyService: notify.NopService, EmojiEnabled: true, openRouteLimiter: 100, } srv.ScoreThresholds.Low, srv.ScoreThresholds.Critical = -5, -10 // add some providers. Needed because we don't allow users with unlisted providers to authenticate providers := []string{"provider1", "anonymous", "github", "email"} for _, p := range providers { srv.Authenticator.AddDirectProvider(p, provider.CredCheckerFunc(func(_, _ string) (ok bool, err error) { return true, nil })) } for _, h := range srvHook { h(srv) } routes := srv.routes() ts = httptest.NewServer(routes) teardown = func() { ts.Close() require.NoError(t, srv.DataService.Close()) _ = os.Remove(testDB) _ = os.RemoveAll(tmp + "/ava-remark42") _ = os.RemoveAll(tmp + "/pics-remark42") } return ts, srv, teardown } // fake auth middleware make user authenticated and uses query's fake_id for ID and fake_name for Name func fakeAuth(next http.Handler) http.Handler { fn := func(w http.ResponseWriter, r *http.Request) { if r.URL.Query().Get("fake_id") != "" { r = rest.SetUserInfo(r, store.User{ ID: r.URL.Query().Get("fake_id"), Name: r.URL.Query().Get("fake_name"), }) } next.ServeHTTP(w, r) } return http.HandlerFunc(fn) } func get(t *testing.T, url string) (response string, statusCode int) { r, err := http.Get(url) require.NoError(t, err) body, err := io.ReadAll(r.Body) require.NoError(t, err) require.NoError(t, r.Body.Close()) return string(body), r.StatusCode } func sendReq(_ *testing.T, r *http.Request, tkn string) (*http.Response, error) { client := http.Client{Timeout: 5 * time.Second} defer client.CloseIdleConnections() if tkn != "" { r.Header.Set("X-JWT", tkn) } return client.Do(r) } func getWithDevAuth(t *testing.T, url string) (body string, code int) { client := &http.Client{Timeout: 5 * time.Second} defer client.CloseIdleConnections() req, err := http.NewRequest("GET", url, http.NoBody) require.NoError(t, err) req.Header.Add("X-JWT", devToken) r, err := client.Do(req) require.NoError(t, err) b, err := io.ReadAll(r.Body) assert.NoError(t, err) require.NoError(t, r.Body.Close()) return string(b), r.StatusCode } func getWithDev2Auth(t *testing.T, url string) (body string, code int) { client := &http.Client{Timeout: 5 * time.Second} defer client.CloseIdleConnections() req, err := http.NewRequest("GET", url, http.NoBody) require.NoError(t, err) req.Header.Add("X-JWT", dev2Token) r, err := client.Do(req) require.NoError(t, err) b, err := io.ReadAll(r.Body) assert.NoError(t, err) require.NoError(t, r.Body.Close()) return string(b), r.StatusCode } func getWithAdminAuth(t *testing.T, url string) (response string, statusCode int) { client := &http.Client{Timeout: 5 * time.Second} defer client.CloseIdleConnections() req, err := http.NewRequest("GET", url, http.NoBody) require.NoError(t, err) req.SetBasicAuth("admin", "password") r, err := client.Do(req) require.NoError(t, err) body, err := io.ReadAll(r.Body) assert.NoError(t, err) require.NoError(t, r.Body.Close()) return string(body), r.StatusCode } func post(t *testing.T, url, body string) (*http.Response, error) { client := &http.Client{Timeout: 5 * time.Second} defer client.CloseIdleConnections() req, err := http.NewRequest("POST", url, strings.NewReader(body)) assert.NoError(t, err) req.SetBasicAuth("admin", "password") return client.Do(req) } func addCommentGetCreatedTime(t *testing.T, c store.Comment, ts *httptest.Server) (id string, created time.Time) { b, err := json.Marshal(c) require.NoError(t, err, "can't marshal comment %+v", c) client := &http.Client{Timeout: 5 * time.Second} defer client.CloseIdleConnections() postURL := ts.URL + "/api/v1/comment" if c.Locator.SiteID != "" { postURL += "?site=" + c.Locator.SiteID } req, err := http.NewRequest("POST", postURL, bytes.NewBuffer(b)) require.NoError(t, err) req.Header.Add("X-JWT", devToken) resp, err := client.Do(req) require.NoError(t, err) require.Equal(t, http.StatusCreated, resp.StatusCode) b, err = io.ReadAll(resp.Body) require.NoError(t, resp.Body.Close()) require.NoError(t, err) crResp := R.JSON{} err = json.Unmarshal(b, &crResp) require.NoError(t, err) time.Sleep(time.Nanosecond * 10) created, err = time.Parse(time.RFC3339, crResp["time"].(string)) require.NoError(t, err) return crResp["id"].(string), created } func addComment(t *testing.T, c store.Comment, ts *httptest.Server) string { id, _ := addCommentGetCreatedTime(t, c, ts) return id } func requireAdminOnly(t *testing.T, req *http.Request) { resp, err := sendReq(t, req, "") // no-auth user require.NoError(t, err) require.NoError(t, resp.Body.Close()) assert.Equal(t, http.StatusUnauthorized, resp.StatusCode) resp, err = sendReq(t, req, devToken) // non-admin user require.NoError(t, err) require.NoError(t, resp.Body.Close()) assert.Equal(t, http.StatusForbidden, resp.StatusCode) } func chooseRandomUnusedPort() (port int) { for range 10 { port = 40000 + int(rand.Int31n(10000)) if ln, err := net.Listen("tcp", fmt.Sprintf(":%d", port)); err == nil { _ = ln.Close() break } } return port } func waitForHTTPSServerStart(port int) { // wait for up to 3 seconds for HTTPS server to start for range 300 { time.Sleep(time.Millisecond * 10) conn, _ := net.DialTimeout("tcp", fmt.Sprintf("localhost:%d", port), time.Millisecond*10) if conn != nil { _ = conn.Close() break } } } func TestMain(m *testing.M) { goleak.VerifyTestMain( m, // this will be fixed in https://github.com/hashicorp/golang-lru/issues/159 goleak.IgnoreTopFunction("github.com/hashicorp/golang-lru/v2/expirable.NewLRU[...].func1"), ) } // TestRest_matchSiteID reproduces the multi-tenant isolation gap in the matchSiteID // middleware. Before the fix, the check `if siteID != "" && user.SiteID != siteID` // silently allowed any authenticated request that omitted the ?site= query param. // On admin and user-mutation routes this meant the cross-site check was bypassable // just by dropping the parameter. The fix requires ?site= to be present and to match // the user's bound site. func TestRest_matchSiteID(t *testing.T) { wrapped := matchSiteID(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) { w.WriteHeader(http.StatusOK) _, _ = w.Write([]byte("ok")) })) cases := []struct { name string userSite string query string want int }{ {name: "matching site allowed", userSite: "site-a", query: "?site=site-a", want: http.StatusOK}, {name: "mismatched site forbidden", userSite: "site-a", query: "?site=site-b", want: http.StatusForbidden}, {name: "missing site param rejected", userSite: "site-a", query: "", want: http.StatusForbidden}, {name: "empty site param rejected", userSite: "site-a", query: "?site=", want: http.StatusForbidden}, } for _, c := range cases { t.Run(c.name, func(t *testing.T) { h := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { r = rest.SetUserInfo(r, store.User{ID: "u", Name: "u", SiteID: c.userSite}) wrapped.ServeHTTP(w, r) }) ts := httptest.NewServer(h) defer ts.Close() resp, err := http.Get(ts.URL + c.query) require.NoError(t, err) require.NoError(t, resp.Body.Close()) assert.Equal(t, c.want, resp.StatusCode) }) } }