Dmitry VerkhoturovandUmputun
e98657a88a
Address all golangci-lint v2.10.1 (CI's version) findings:
* Add http.MaxBytesReader hard cap to ParseMultipartForm sites in
rest_private.savePictureCtrl (32MB) and api/migrator (256MB) — fixes
G120 by bounding total request body before form parsing.
* Suppress G70x in CLI subcommands cmd/{backup,cleanup,import,remap}.go:
all four issue HTTP requests against operator-supplied RemarkURL/CLI
flags, never user input. Each suppression carries a one-line reason.
* Suppress G122 in image fs_store cleanup walk: staging directory tree
is server-only, no untrusted symlinks land there.
64 lines
1.8 KiB
Go
64 lines
1.8 KiB
Go
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"os"
|
|
|
|
log "github.com/go-pkgz/lgr"
|
|
)
|
|
|
|
// RemapCommand set of flags and command for change linkage between comments to
|
|
// different urls based on given rules (input file)
|
|
type RemapCommand struct {
|
|
InputFile string `short:"f" long:"file" description:"input file name" required:"true"`
|
|
|
|
SupportCmdOpts
|
|
CommonOpts
|
|
}
|
|
|
|
// Execute runs (re)mapper with RemapCommand parameters, entry point for "remap" command
|
|
func (rc *RemapCommand) Execute(_ []string) error {
|
|
log.Printf("[INFO] start remap, site %s, file with rules %s", rc.Site, rc.InputFile)
|
|
resetEnv("SECRET", "ADMIN_PASSWD")
|
|
|
|
rulesReader, err := os.Open(rc.InputFile)
|
|
if err != nil {
|
|
return fmt.Errorf("cant open file %s: %w", rc.InputFile, err)
|
|
}
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
ctx, cancel := context.WithTimeout(context.Background(), rc.Timeout)
|
|
defer cancel()
|
|
remapURL := fmt.Sprintf("%s/api/v1/admin/remap?site=%s", rc.RemarkURL, rc.Site)
|
|
req, err := http.NewRequest(http.MethodPost, remapURL, rulesReader) //nolint:gosec // RemarkURL is operator CLI flag, not user input
|
|
if err != nil {
|
|
return fmt.Errorf("can't make remap request for %s: %w", remapURL, err)
|
|
}
|
|
req.SetBasicAuth("admin", rc.AdminPasswd)
|
|
|
|
resp, err := client.Do(req.WithContext(ctx)) //nolint:gosec // see above
|
|
if err != nil {
|
|
return fmt.Errorf("request failed for %s: %w", remapURL, err)
|
|
}
|
|
defer func() {
|
|
if err = resp.Body.Close(); err != nil {
|
|
log.Printf("[WARN] failed to close response, %s", err)
|
|
}
|
|
}()
|
|
if resp.StatusCode >= 300 {
|
|
return responseError(resp)
|
|
}
|
|
|
|
body, err := io.ReadAll(resp.Body)
|
|
if err != nil {
|
|
return fmt.Errorf("can't get response: %w", err)
|
|
}
|
|
|
|
log.Printf("[INFO] completed, status=%d, %s", resp.StatusCode, string(body))
|
|
return nil
|
|
}
|