* Make backend tests wait on conditions instead of durations The backend workflow has a long tail of runs that fail once and pass on a rerun. Every one of them comes down to a test assuming an operation finishes within some duration rather than waiting for the state it needs. Three were reproducible and each was reproduced against the old code before being changed: TestServerAuthHooks minted a token that lived one second and never tested expiry, so a slow runner turned the first POST into a 401; TestServerApp_AnonMode saw "connection refused" because waitForHTTPServerStart returned silently after three seconds and left a later assertion to fail with something unrelated; TestFsStore_Cleanup slept 200ms against a 300ms ttl that Cleanup widens to 400ms with its commit grace, so roughly 100ms of stall collected an image meant to survive. Fixed sleeps before asserting on asynchronous work are replaced with polls on the condition itself, using require.Eventually and require.EventuallyWithT, and require.Never where the assertion is that something did not happen. Polling closures assert on the CollectT they are handed rather than on t, since testify runs them on another goroutine, and polls that issue HTTP requests stay under the rate limit on the routes they poll through. Where a test needs time to have passed, the clock input is pinned instead: staging ages are stamped with os.Chtimes on both sides of the cleanup boundary right before each call, which also makes the 100ms commit grace an exact case rather than something no assertion reaches, and the RSS tests set store.Comment.Timestamp explicitly rather than racing the wall clock into the first 100ms of a second so pubDate matches. chooseUnusedPort takes a port from the kernel's ephemeral range. Picking at random out of a fixed 10000-port window let two package binaries, which go test ./... runs concurrently, land on the same number between the probe closing and the server binding. The start helpers fail naming the port they waited on, and the SSL tests wait on the redirect port as well as the TLS one. Arbitrary budgets that nothing tests are gone: ten HTTP clients with a one-second timeout against bolt-backed import and export, the "should take about 100msec" assertions, and a one-second bound on noticing an already cancelled context. Shutdown stays bounded at ten seconds so a hang is still caught. Two assertions get stronger. TestServerAuthHooks accepted 403 or 401 from a blocked user, an alternative that existed only because the short token could expire mid-test; it is deterministically 403 now. TestAdmin_BlockedList asserted two users blocked while one carried the same 150ms ttl the next step waits to lapse, so the halves raced each other. goleak stops reporting the regexp2 clock goroutine, which chroma pulls in for syntax highlighting and which lives for up to a second after the last match with a timeout; it ends on its own but a binary finishing inside that window was reported as leaking, and this suite now finishes sooner. The ignore for net/http.(*Server).Shutdown goes the other way: it no longer matches anything, with both packages run fifteen times each under CPU oversubscription to confirm. Two gaps the change would otherwise have opened are covered directly rather than left to the side effects that used to cover them. The one-second token was the only thing exercising the authenticator's ClaimsUpd hook on refresh, so TestServerApp_ClaimsUpd now calls the hook itself and checks admin, blocked, email and restricted-name impersonation, including the two pass-through cases. Lifting the open-route limit removed the last incidental exercise of the rate limiter, so TestRateLimiter drives a burst past the allowance and checks the refusals and that the limit is per client. Both run without a wall clock, and both were confirmed to fail when the behaviour they cover is removed. Production code is untouched. The two sleeps outside test code, the 429 backoff in cmd/cleanup.go and the submit poll in store/image/image.go, are left alone: no CI failure implicates them. Test sleeps drop from 67 to 21, all of them either inside a testing/synctest bubble or a poll interval. The suite runs in about 22 seconds instead of 46, mostly because TestPublic_FindCommentsCtrl_ConsistentCount no longer paces a hundred subtests with an 80ms sleep each to stay under the open route limit. The 300s per-package budget now matches across both workflows, the race_test target and the documented command, and CLAUDE.md records the convention. with '#' will be ignored, and an empty message aborts the commit. # # Date: Sat Aug 22 01:12:31 2026 +0100 # # interactive rebase in progress; onto7c312da1# Last command done (1 command done): # reword deb6cbf1 # Make backend tests wait on conditions instead of durations # Next command to do (1 remaining command): # reword 262e6dc2 # Apply go fix under Go 1.27 # You are currently editing a commit while rebasing branch 'fix/backend-test-flakiness' on '7c312da1'. # # Changes to be committed: .github/workflows/release.yml # modified: CLAUDE.md # modified: Makefile modified: backend/_example/memory_store/server/rpc_test.go # modified: backend/app/cmd/import_test.go # modified: backend/app/cmd/server_test.go # modified: backend/app/main_test.go # modified: backend/app/rest/api/admin_test.go # modified: backend/app/rest/api/middleware_test.go # modified: backend/app/rest/api/migrator_test.go # modified: backend/app/rest/api/rest_private_test.go # modified: backend/app/rest/api/rest_public_test.go # modified: backend/app/rest/api/rest_test.go # modified: backend/app/rest/api/rss_test.go # modified: backend/app/rest/proxy/image_test.go # modified: backend/app/store/image/fs_store_test.go # modified: backend/app/store/service/service_test.go # modified: docs/backlog/api-tests-deadlock-on-macos.md # * Apply go fix under Go 1.27 Go 1.27 extends go fix with the modernizers, so `go fix ./...` now rewrites patterns the language has since replaced. Running it across all three modules produces this: legacy sync/atomic calls on plain integers become the atomic types (notify.Service.closed, image.Service.term and submitCount, and several test counters), reverse index loops become slices.Backward, a Split-then-index becomes strings.Cut, counted loops become range over an int, and interface{} becomes any in the e2e suite. The example module needed no changes. The e2e module is behind a build tag, so it only matches with `go fix -tags e2e ./...`. One knock-on: prealloc can see the bound of a loop once it is written as range over an int, so the slice it feeds is now preallocated. with '#' will be ignored, and an empty message aborts the commit. # # Date: Sat Aug 22 01:32:09 2026 +0100 # # interactive rebase in progress; onto7c312da1# Last commands done (2 commands done): # reword deb6cbf1 262e6dc2 # Apply go fix under Go 1.27 # No commands remaining. # You are currently editing a commit while rebasing branch 'fix/backend-test-flakiness' on '7c312da1'. # # Changes to be committed: backend/app/migrator/native.go # modified: backend/app/notify/notify.go backend/app/rest/api/rest_private_test.go # modified: backend/app/store/comment.go # modified: backend/app/store/image/image.go # modified: backend/app/store/service/service_test.go # modified: backend/app/store/service/title_test.go # modified: e2e/e2e_test.go # modified: e2e/widgets_test.go #
1704 lines
69 KiB
Go
1704 lines
69 KiB
Go
package api
|
|
|
|
import (
|
|
"bytes"
|
|
"compress/gzip"
|
|
"context"
|
|
"encoding/base64"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"mime/multipart"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/go-pkgz/auth/v2/token"
|
|
"github.com/go-pkgz/lgr"
|
|
R "github.com/go-pkgz/rest"
|
|
"github.com/golang-jwt/jwt/v5"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/umputun/remark42/backend/app/notify"
|
|
"github.com/umputun/remark42/backend/app/rest/proxy"
|
|
"github.com/umputun/remark42/backend/app/store"
|
|
"github.com/umputun/remark42/backend/app/store/image"
|
|
)
|
|
|
|
// gopher png for test, from https://golang.org/src/image/png/example_test.go
|
|
const gopher = `iVBORw0KGgoAAAANSUhEUgAAAEsAAAA8CAAAAAALAhhPAAAFfUlEQVRYw62XeWwUVRzHf2+OPbo9d7tsWyiyaZti6eWGAhISoIGKECEKCAiJJkYTiUgTMYSIosYYBBIUIxoSPIINEBDi2VhwkQrVsj1ESgu9doHWdrul7ba73WNm3vOPtsseM9MdwvvrzTs+8/t95ze/33sI5BqiabU6m9En8oNjduLnAEDLUsQXFF8tQ5oxK3vmnNmDSMtrncks9Hhtt/qeWZapHb1ha3UqYSWVl2ZmpWgaXMXGohQAvmeop3bjTRtv6SgaK/Pb9/bFzUrYslbFAmHPp+3WhAYdr+7GN/YnpN46Opv55VDsJkoEpMrY/vO2BIYQ6LLvm0ThY3MzDzzeSJeeWNyTkgnIE5ePKsvKlcg/0T9QMzXalwXMlj54z4c0rh/mzEfr+FgWEz2w6uk8dkzFAgcARAgNp1ZYef8bH2AgvuStbc2/i6CiWGj98y2tw2l4FAXKkQBIf+exyRnteY83LfEwDQAYCoK+P6bxkZm/0966LxcAAILHB56kgD95PPxltuYcMtFTWw/FKkY/6Opf3GGd9ZF+Qp6mzJxzuRSractOmJrH1u8XTvWFHINNkLQLMR+XHXvfPPHw967raE1xxwtA36IMRfkAAG29/7mLuQcb2WOnsJReZGfpiHsSBX81cvMKywYZHhX5hFPtOqPGWZCXnhWGAu6lX91ElKXSalcLXu3UaOXVay57ZSe5f6Gpx7J2MXAsi7EqSp09b/MirKSyJfnfEEgeDjl8FgDAfvewP03zZ+AJ0m9aFRM8eEHBDRKjfcreDXnZdQuAxXpT2NRJ7xl3UkLBhuVGU16gZiGOgZmrSbRdqkILuL/yYoSXHHkl9KXgqNu3PB8oRg0geC5vFmLjad6mUyTKLmF3OtraWDIfACyXqmephaDABawfpi6tqqBZytfQMqOz6S09iWXhktrRaB8Xz4Yi/8gyABDm5NVe6qq/3VzPrcjELWrebVuyY2T7ar4zQyybUCtsQ5Es1FGaZVrRVQwAgHGW2ZCRZshI5bGQi7HesyE972pOSeMM0dSktlzxRdrlqb3Osa6CCS8IJoQQQgBAbTAa5l5epO34rJszibJI8rxLfGzcp1dRosutGeb2VDNgqYrwTiPNsLxXiPi3dz7LiS1WBRBDBOnqEjyy3aQb+/bLiJzz9dIkscVBBLxMfSEac7kO4Fpkngi0ruNBeSOal+u8jgOuqPz12nryMLCniEjtOOOmpt+KEIqsEdocJjYXwrh9OZqWJQyPCTo67LNS/TdxLAv6R5ZNK9npEjbYdT33gRo4o5oTqR34R+OmaSzDBWsAIPhuRcgyoteNi9gF0KzNYWVItPf2TLoXEg+7isNC7uJkgo1iQWOfRSP9NR11RtbZZ3OMG/VhL6jvx+J1m87+RCfJChAtEBQkSBX2PnSiihc/Twh3j0h7qdYQAoRVsRGmq7HU2QRbaxVGa1D6nIOqaIWRjyRZpHMQKWKpZM5feA+lzC4ZFultV8S6T0mzQGhQohi5I8iw+CsqBSxhFMuwyLgSwbghGb0AiIKkSDmGZVmJSiKihsiyOAUs70UkywooYP0bii9GdH4sfr1UNysd3fUyLLMQN+rsmo3grHl9VNJHbbwxoa47Vw5gupIqrZcjPh9R4Nye3nRDk199V+aetmvVtDRE8/+cbgAAgMIWGb3UA0MGLE9SCbWX670TDy1y98c3D27eppUjsZ6fql3jcd5rUe7+ZIlLNQny3Rd+E5Tct3WVhTM5RBCEdiEK0b6B+/ca2gYU393nFj/n1AygRQxPIUA043M42u85+z2SnssKrPl8Mx76NL3E6eXc3be7OD+H4WHbJkKI8AU8irbITQjZ+0hQcPEgId/Fn/pl9crKH02+5o2b9T/eMx7pKoskYgAAAABJRU5ErkJggg==`
|
|
|
|
func gopherPNG() io.Reader { return base64.NewDecoder(base64.StdEncoding, strings.NewReader(gopher)) }
|
|
|
|
func TestRest_Create(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
resp, err := post(t, ts.URL+"/api/v1/comment?site=remark42",
|
|
`{"text": "test 123", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`)
|
|
assert.NoError(t, err)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(b))
|
|
assert.NoError(t, resp.Body.Close())
|
|
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
loc := c["locator"].(map[string]any)
|
|
assert.Equal(t, "remark42", loc["site"])
|
|
assert.Equal(t, "https://radio-t.com/blah1", loc["url"])
|
|
assert.True(t, len(c["id"].(string)) > 8)
|
|
}
|
|
|
|
// based on issue https://github.com/umputun/remark42/issues/1292
|
|
func TestRest_CreateFilteredCode(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
resp, err := post(t, ts.URL+"/api/v1/comment?site=remark42",
|
|
`{"text": "`+"`foo<bar>`"+`", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`)
|
|
assert.NoError(t, err)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(b))
|
|
assert.NoError(t, resp.Body.Close())
|
|
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
require.NoError(t, err, string(b))
|
|
loc := c["locator"].(map[string]any)
|
|
assert.Equal(t, "remark42", loc["site"])
|
|
assert.Equal(t, "https://radio-t.com/blah1", loc["url"])
|
|
assert.Equal(t, "`foo<bar>`", c["orig"])
|
|
assert.Contains(t, c["text"], "foo")
|
|
assert.Contains(t, c["text"], "bar")
|
|
assert.True(t, len(c["id"].(string)) > 8)
|
|
}
|
|
|
|
// based on issue https://github.com/umputun/remark42/issues/1631
|
|
func TestRest_CreateAndPreviewWithImage(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
ts.Close()
|
|
defer teardown()
|
|
|
|
srv.ImageService.ProxyAPI = srv.RemarkURL + "/api/v1/img"
|
|
srv.ImageProxy = &proxy.Image{
|
|
HTTP2HTTPS: true,
|
|
CacheExternal: true,
|
|
RoutePath: "/api/v1/img",
|
|
RemarkURL: srv.RemarkURL,
|
|
ImageService: srv.ImageService,
|
|
Transport: http.DefaultTransport,
|
|
}
|
|
srv.CommentFormatter = store.NewCommentFormatter(srv.ImageProxy)
|
|
// need to recreate the server with new ImageProxy, otherwise old one will be used
|
|
ts = httptest.NewServer(srv.routes())
|
|
defer ts.Close()
|
|
|
|
var pngRead bool
|
|
// server with the test PNG image
|
|
pngServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
|
_, e := io.Copy(w, gopherPNG())
|
|
assert.NoError(t, e)
|
|
pngRead = true
|
|
}))
|
|
defer pngServer.Close()
|
|
|
|
t.Run("create", func(t *testing.T) {
|
|
resp, err := post(t, ts.URL+"/api/v1/comment?site=remark42",
|
|
`{"text": "", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`)
|
|
assert.NoError(t, err)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(b))
|
|
assert.NoError(t, resp.Body.Close())
|
|
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
require.NoError(t, err, string(b))
|
|
assert.NotContains(t, c["text"], pngServer.URL)
|
|
assert.Contains(t, c["text"], srv.RemarkURL)
|
|
loc := c["locator"].(map[string]any)
|
|
assert.Equal(t, "remark42", loc["site"])
|
|
assert.Equal(t, "https://radio-t.com/blah1", loc["url"])
|
|
assert.True(t, len(c["id"].(string)) > 8)
|
|
assert.Equal(t, false, pngRead, "original image is not yet accessed by server")
|
|
})
|
|
|
|
t.Run("preview", func(t *testing.T) {
|
|
resp, err := post(t, ts.URL+"/api/v1/preview",
|
|
`{"text": "", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`)
|
|
assert.NoError(t, err)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(b))
|
|
assert.NoError(t, resp.Body.Close())
|
|
|
|
assert.NotContains(t, string(b), pngServer.URL)
|
|
assert.Contains(t, string(b), srv.RemarkURL)
|
|
|
|
assert.Equal(t, false, pngRead, "original image is not yet accessed by server")
|
|
// retrieve the image from the cache
|
|
imgURL, _, _ := strings.Cut(strings.Split(string(b), "src=\"")[1], "\"")
|
|
// replace srv.RemarkURL with ts.URL
|
|
imgURL = strings.ReplaceAll(imgURL, srv.RemarkURL, ts.URL)
|
|
resp, err = http.Get(imgURL)
|
|
assert.NoError(t, err)
|
|
b, err = io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(b))
|
|
assert.NoError(t, resp.Body.Close())
|
|
// compare image to original gopher png after decoding from base64
|
|
assert.Equal(t, gopher, base64.StdEncoding.EncodeToString(b))
|
|
|
|
assert.Equal(t, true, pngRead, "original image accessed to be shown to user")
|
|
})
|
|
|
|
}
|
|
|
|
func TestRest_CreateOldPost(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
// make old, but not too old comment
|
|
old := store.Comment{Text: "test test old", ParentID: "", Timestamp: time.Now().AddDate(0, 0, -5),
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}, User: store.User{ID: "u1"}}
|
|
_, err := srv.DataService.Create(old)
|
|
assert.NoError(t, err)
|
|
|
|
comments, err := srv.DataService.Find(store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}, "time", store.User{})
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 1, len(comments))
|
|
|
|
// try to add new comment to the same old post
|
|
resp, err := post(t, ts.URL+"/api/v1/comment?site=remark42",
|
|
`{"text": "test 123", "locator":{"site": "remark42","url": "https://radio-t.com/blah1"}}`)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
|
|
assert.NoError(t, srv.DataService.DeleteAll("remark42"))
|
|
// make too old comment
|
|
old = store.Comment{Text: "test test old", ParentID: "", Timestamp: time.Now().AddDate(0, 0, -15),
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}, User: store.User{ID: "u1"}}
|
|
_, err = srv.DataService.Create(old)
|
|
assert.NoError(t, err)
|
|
|
|
resp, err = post(t, ts.URL+"/api/v1/comment?site=remark42",
|
|
`{"text": "test 123", "locator":{"site": "remark42","url": "https://radio-t.com/blah1"}}`)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusForbidden, resp.StatusCode)
|
|
}
|
|
|
|
func TestRest_CreateTooBig(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
longComment := fmt.Sprintf(`{"text": "%4001s", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`, "Щ")
|
|
|
|
resp, err := post(t, ts.URL+"/api/v1/comment?site=remark42", longComment)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "comment text exceeded max allowed size 4000 (4001)", c["error"])
|
|
assert.Equal(t, "invalid comment", c["details"])
|
|
|
|
veryLongComment := fmt.Sprintf(`{"text": "%70000s", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`, "Щ")
|
|
resp, err = post(t, ts.URL+"/api/v1/comment?site=remark42", veryLongComment)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
|
|
b, err = io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c = R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "http: request body too large", c["error"])
|
|
assert.Equal(t, "can't bind comment", c["details"])
|
|
}
|
|
|
|
func TestRest_CreateWithRestrictedWord(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
badComment := `{"text": "What the duck is that?", "locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`
|
|
|
|
resp, err := post(t, ts.URL+"/api/v1/comment?site=remark42", badComment)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "comment contains restricted words", c["error"])
|
|
assert.Equal(t, "invalid comment", c["details"])
|
|
}
|
|
|
|
func TestRest_CreateRelativeURL(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
// check that it's not possible to click insert URL button and not alter the URL in it (which is `url` by default)
|
|
relativeURLText := `{"text": "here is a link with relative URL: [google.com](url)", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`
|
|
resp, err := post(t, ts.URL+"/api/v1/comment?site=remark42", relativeURLText)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "links should start with mailto:, http:// or https://", c["error"])
|
|
assert.Equal(t, "invalid comment", c["details"])
|
|
}
|
|
|
|
func TestRest_CreateRejected(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
body := `{"text": "test 123", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`
|
|
|
|
// try to create without auth
|
|
resp, err := http.Post(ts.URL+"/api/v1/comment?site=remark42", "", strings.NewReader(body))
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusUnauthorized, resp.StatusCode)
|
|
|
|
// try with wrong aud
|
|
client := &http.Client{Timeout: 5 * time.Second}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest("POST", ts.URL+"/api/v1/comment?site=remark42", strings.NewReader(body))
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devTokenBadAud)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusForbidden, resp.StatusCode, "reject wrong aud")
|
|
}
|
|
|
|
func TestRest_CreateWithWrongImage(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
// create comment
|
|
resp, err := post(t, ts.URL+"/api/v1/comment?site=remark42", fmt.Sprintf(`{"text": "", "locator":{"url": "https://radio-t.com/blah1", "site": "radio-t"}}`, srv.RemarkURL))
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
assert.Contains(t,
|
|
string(b),
|
|
"{\"code\":20,\"details\":\"can't load picture from the comment\","+
|
|
"\"error\":\"can't get image file for dev_user/bad_picture: can't get image stats for dev_user/bad_picture: stat ",
|
|
)
|
|
assert.Contains(t,
|
|
string(b),
|
|
"/pics-remark42/staging/dev_user/62/bad_picture: no such file or directory\"}\n",
|
|
)
|
|
}
|
|
|
|
func TestRest_CreateWithLazyImage(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
body := `{"text": "test 123 ", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`
|
|
// create comment
|
|
resp, err := post(t, ts.URL+"/api/v1/comment?site=remark42", body)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c := store.Comment{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, c.Text, "<p>test 123 <img src=\"http://example.com/image.png\" alt=\"\" loading=\"lazy\"/></p>\n")
|
|
}
|
|
|
|
func TestRest_CreateAndGet(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
// create comment
|
|
resp, err := post(t, ts.URL+"/api/v1/comment?site=remark42",
|
|
`{"text": "**test** *123*\n\n http://radio-t.com", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
|
|
id := c["id"].(string)
|
|
|
|
// get created comment by id as admin
|
|
res, code := getWithAdminAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah1", ts.URL, id))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
comment := store.Comment{}
|
|
err = json.Unmarshal([]byte(res), &comment)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "<p><strong>test</strong> <em>123</em></p>\n\n<p><a href=\"http://radio-t.com\" rel=\"nofollow\">http://radio-t.com</a></p>\n", comment.Text)
|
|
assert.Equal(t, "**test** *123*\n\n http://radio-t.com", comment.Orig)
|
|
assert.Equal(t, store.User{Name: "admin", ID: "admin", Admin: true, Blocked: false,
|
|
IP: "dbc7c999343f003f189f70aaf52cc04443f90790"},
|
|
comment.User)
|
|
|
|
// get created comment by id as non-admin
|
|
res, code = getWithDevAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah1", ts.URL, id))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
comment = store.Comment{}
|
|
err = json.Unmarshal([]byte(res), &comment)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "admin", ID: "admin", Admin: true, Blocked: false, IP: ""}, comment.User, "no ip")
|
|
}
|
|
|
|
func TestRest_CreateWithQuotes(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
// create comment with quotes with smartypants
|
|
resp, err := post(t, ts.URL+"/api/v1/comment?site=remark42",
|
|
`{"text": "smartpants \"quoted\" text", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
id := c["id"].(string)
|
|
|
|
// get created comment by id as non-admin
|
|
res, code := getWithDevAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah1", ts.URL, id))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
comment := store.Comment{}
|
|
err = json.Unmarshal([]byte(res), &comment)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "<p>smartpants «quoted» text</p>\n", comment.Text)
|
|
assert.Equal(t, "smartpants \"quoted\" text", comment.Orig)
|
|
|
|
// create comment with quotes without smartypants
|
|
srv.privRest.disableFancyTextFormatting = true
|
|
resp, err = post(t, ts.URL+"/api/v1/comment?site=remark42",
|
|
`{"text": "no_smartpants \"quoted\" text", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
b, err = io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c = R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
id = c["id"].(string)
|
|
|
|
// get created comment by id as non-admin
|
|
res, code = getWithDevAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah1", ts.URL, id))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
comment = store.Comment{}
|
|
err = json.Unmarshal([]byte(res), &comment)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "<p>no_smartpants "quoted" text</p>\n", comment.Text)
|
|
assert.Equal(t, "no_smartpants \"quoted\" text", comment.Orig)
|
|
}
|
|
|
|
func TestRest_Update(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "test test #1", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
id := addComment(t, c1, ts)
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+id+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"text":"updated text", "summary":"my edit"}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
beforeUpdate := time.Now()
|
|
b, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err := io.ReadAll(b.Body)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, b.StatusCode, string(body))
|
|
assert.NoError(t, b.Body.Close())
|
|
|
|
// comments returned by update
|
|
c2 := store.Comment{}
|
|
err = json.Unmarshal(body, &c2)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, id, c2.ID)
|
|
assert.Equal(t, "<p>updated text</p>\n", c2.Text)
|
|
assert.Equal(t, "updated text", c2.Orig)
|
|
assert.Equal(t, "my edit", c2.Edit.Summary)
|
|
assert.WithinRange(t, c2.Edit.Timestamp, beforeUpdate, time.Now(), "edit stamped during the update")
|
|
|
|
// read updated comment
|
|
res, code := getWithAdminAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah1", ts.URL, id))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
c3 := store.Comment{}
|
|
err = json.Unmarshal([]byte(res), &c3)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, c2, c3, "same as response from update")
|
|
}
|
|
|
|
func TestRest_UpdateDelete(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "test test #1", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
id := addComment(t, c1, ts)
|
|
|
|
// check multi count updated
|
|
resp, err := post(t, ts.URL+"/api/v1/counts?site=remark42", `["https://radio-t.com/blah1","https://radio-t.com/blah2"]`)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
bb, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
j := []store.PostInfo{}
|
|
err = json.Unmarshal(bb, &j)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []store.PostInfo{{URL: "https://radio-t.com/blah1", Count: 1},
|
|
{URL: "https://radio-t.com/blah2", Count: 0}}, j)
|
|
|
|
// delete a comment
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+id+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"delete": true, "summary":"removed by user"}`))
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err := io.ReadAll(b.Body)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, b.StatusCode, string(body))
|
|
assert.NoError(t, b.Body.Close())
|
|
|
|
// comments returned by update
|
|
c2 := store.Comment{}
|
|
err = json.Unmarshal(body, &c2)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, id, c2.ID)
|
|
assert.True(t, c2.Deleted)
|
|
|
|
// read updated comment
|
|
res, code := getWithDevAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah1", ts.URL, id))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
c3 := store.Comment{}
|
|
err = json.Unmarshal([]byte(res), &c3)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "", c3.Text)
|
|
assert.Equal(t, "", c3.Orig)
|
|
assert.True(t, c3.Deleted)
|
|
|
|
// check multi count updated
|
|
resp, err = post(t, ts.URL+"/api/v1/counts?site=remark42", `["https://radio-t.com/blah1","https://radio-t.com/blah2"]`)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
bb, err = io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
j = []store.PostInfo{}
|
|
err = json.Unmarshal(bb, &j)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, []store.PostInfo{{URL: "https://radio-t.com/blah1", Count: 0},
|
|
{URL: "https://radio-t.com/blah2", Count: 0}}, j)
|
|
}
|
|
|
|
func TestRest_DeleteChildThenParent(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
p := store.Comment{Text: "test test #1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
idP := addComment(t, p, ts)
|
|
|
|
c1 := store.Comment{Text: "test test #1", ParentID: idP,
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
idC1 := addComment(t, c1, ts)
|
|
|
|
c2 := store.Comment{Text: "test test #1", ParentID: idP,
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
idC2 := addComment(t, c2, ts)
|
|
|
|
// check multi count equals two
|
|
resp, err := post(t, ts.URL+"/api/v1/counts?site=remark42", `["https://radio-t.com/blah1"]`)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
bb, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
j := []store.PostInfo{}
|
|
err = json.Unmarshal(bb, &j)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []store.PostInfo{{URL: "https://radio-t.com/blah1", Count: 3}}, j)
|
|
|
|
// update a parent comment fails after child is created
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+idP+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"text": "updated text", "summary":"updated by user"}`))
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err := io.ReadAll(b.Body)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, b.StatusCode, string(body))
|
|
assert.NoError(t, b.Body.Close())
|
|
|
|
// delete first child comment
|
|
req, err = http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+idC1+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"delete": true, "summary":"removed by user"}`))
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(b.Body)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, b.StatusCode, string(body))
|
|
assert.NoError(t, b.Body.Close())
|
|
|
|
// delete a parent comment, fails as one comment child still present
|
|
defer client.CloseIdleConnections()
|
|
req, err = http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+idP+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"delete": true, "summary":"removed by user"}`))
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(b.Body)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, b.StatusCode, string(body))
|
|
assert.NoError(t, b.Body.Close())
|
|
|
|
// delete second child comment, as an admin to check both deletion methods
|
|
req, err = http.NewRequest(http.MethodDelete,
|
|
fmt.Sprintf("%s/api/v1/admin/comment/%s?site=remark42&url=https://radio-t.com/blah1", ts.URL, idC2), http.NoBody)
|
|
require.NoError(t, err)
|
|
requireAdminOnly(t, req)
|
|
resp, err = sendReq(req, adminUmputunToken)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
|
|
// delete a parent comment, shouldn't fail after children are deleted
|
|
defer client.CloseIdleConnections()
|
|
req, err = http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+idP+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"delete": true, "summary":"removed by user"}`))
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(b.Body)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, b.StatusCode, string(body))
|
|
assert.NoError(t, b.Body.Close())
|
|
|
|
// check multi count decremented to zero
|
|
resp, err = post(t, ts.URL+"/api/v1/counts?site=remark42", `["https://radio-t.com/blah1"]`)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
bb, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
j = []store.PostInfo{}
|
|
err = json.Unmarshal(bb, &j)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []store.PostInfo{{URL: "https://radio-t.com/blah1", Count: 0}}, j)
|
|
}
|
|
|
|
func TestRest_UpdateNotOwner(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "test test #1", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}, User: store.User{ID: "xyz"}}
|
|
id1, err := srv.DataService.Create(c1)
|
|
assert.NoError(t, err)
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+id1+
|
|
"?site=remark42&url=https://radio-t.com/blah1", strings.NewReader(`{"text":"updated text", "summary":"my edit"}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err := io.ReadAll(b.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, b.Body.Close())
|
|
assert.Equal(t, http.StatusForbidden, b.StatusCode, string(body), "update from non-owner")
|
|
assert.Equal(t, `{"code":3,"details":"can not edit comments for other users","error":"rejected"}`+"\n", string(body))
|
|
|
|
req, err = http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+id1+
|
|
"?site=remark42&url=https://radio-t.com/blah1", strings.NewReader(`ERRR "text":"updated text", "summary":"my"}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, b.Body.Close())
|
|
assert.Equal(t, http.StatusBadRequest, b.StatusCode, string(body), "update is not json")
|
|
}
|
|
|
|
func TestRest_UpdateWrongAud(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "test test #1", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
id := addComment(t, c1, ts)
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+id+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"text":"updated text", "summary":"my edit"}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devTokenBadAud)
|
|
b, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, b.Body.Close())
|
|
assert.Equal(t, http.StatusForbidden, b.StatusCode, "reject update with wrong aut in jwt")
|
|
}
|
|
|
|
func TestRest_UpdateWithRestrictedWords(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "What the quack is that?", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
id := addComment(t, c1, ts)
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+id+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"text":"What the duck is that?", "summary":"my edit"}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err := io.ReadAll(b.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, b.Body.Close())
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(body, &c)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, b.StatusCode, string(body))
|
|
assert.Equal(t, "comment contains restricted words", c["error"])
|
|
assert.Equal(t, "invalid comment", c["details"])
|
|
}
|
|
|
|
func TestRest_Vote(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "test test #1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah"}}
|
|
c2 := store.Comment{Text: "test test #2", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah"}}
|
|
|
|
id1 := addComment(t, c1, ts)
|
|
addComment(t, c2, ts)
|
|
|
|
vote := func(val int) int {
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut,
|
|
fmt.Sprintf("%s/api/v1/vote/%s?site=remark42&url=https://radio-t.com/blah&vote=%d", ts.URL, id1, val), http.NoBody)
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", dev2Token)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
return resp.StatusCode
|
|
}
|
|
|
|
assert.Equal(t, http.StatusOK, vote(1), "first vote allowed")
|
|
assert.Equal(t, http.StatusBadRequest, vote(1), "second vote rejected")
|
|
body, code := getWithDev2Auth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
cr := store.Comment{}
|
|
err := json.Unmarshal([]byte(body), &cr)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 1, cr.Score)
|
|
assert.Equal(t, 1, cr.Vote)
|
|
assert.Equal(t, map[string]bool(nil), cr.Votes, "hidden")
|
|
assert.Equal(t, map[string]store.VotedIPInfo(nil), cr.VotedIPs, "hidden")
|
|
|
|
assert.Equal(t, http.StatusOK, vote(-1), "opposite vote allowed")
|
|
body, code = getWithDev2Auth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
cr = store.Comment{}
|
|
err = json.Unmarshal([]byte(body), &cr)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 0, cr.Score)
|
|
assert.Equal(t, 0, cr.Vote)
|
|
|
|
assert.Equal(t, http.StatusOK, vote(-1), "opposite vote allowed one more time")
|
|
body, code = getWithDev2Auth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
cr = store.Comment{}
|
|
err = json.Unmarshal([]byte(body), &cr)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, -1, cr.Score)
|
|
assert.Equal(t, -1, cr.Vote)
|
|
|
|
assert.Equal(t, http.StatusBadRequest, vote(-1), "dbl vote not allowed")
|
|
body, code = getWithDev2Auth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
cr = store.Comment{}
|
|
err = json.Unmarshal([]byte(body), &cr)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, -1, cr.Score)
|
|
assert.Equal(t, -1, cr.Vote)
|
|
|
|
body, code = get(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
cr = store.Comment{}
|
|
err = json.Unmarshal([]byte(body), &cr)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, -1, cr.Score)
|
|
assert.Equal(t, 0, cr.Vote, "no vote info for not authed user")
|
|
assert.Equal(t, map[string]bool(nil), cr.Votes, "hidden")
|
|
assert.Equal(t, map[string]store.VotedIPInfo(nil), cr.VotedIPs, "hidden")
|
|
|
|
req, err := http.NewRequest("GET",
|
|
fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1), http.NoBody)
|
|
assert.NoError(t, err)
|
|
resp, err := sendReq(req, adminUmputunToken)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
cr = store.Comment{}
|
|
err = json.NewDecoder(resp.Body).Decode(&cr)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, -1, cr.Score)
|
|
assert.Equal(t, 0, cr.Vote, "no vote info for different user")
|
|
assert.Equal(t, map[string]bool(nil), cr.Votes, "hidden")
|
|
assert.Equal(t, map[string]store.VotedIPInfo(nil), cr.VotedIPs, "hidden")
|
|
}
|
|
|
|
func TestRest_AnonVote(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "test test #1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah"}}
|
|
c2 := store.Comment{Text: "test test #2", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah"}}
|
|
|
|
id1 := addComment(t, c1, ts)
|
|
addComment(t, c2, ts)
|
|
|
|
vote := func(val int) int {
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut,
|
|
fmt.Sprintf("%s/api/v1/vote/%s?site=remark42&url=https://radio-t.com/blah&vote=%d", ts.URL, id1, val), http.NoBody)
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", anonToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
return resp.StatusCode
|
|
}
|
|
|
|
getWithAnonAuth := func(url string) (body string, code int) {
|
|
client := &http.Client{Timeout: 5 * time.Second}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest("GET", url, http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", anonToken)
|
|
r, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
defer r.Body.Close()
|
|
b, err := io.ReadAll(r.Body)
|
|
assert.NoError(t, err)
|
|
return string(b), r.StatusCode
|
|
}
|
|
|
|
assert.Equal(t, http.StatusForbidden, vote(1), "vote is disallowed with anonVote false")
|
|
srv.privRest.anonVote = true
|
|
assert.Equal(t, http.StatusOK, vote(1), "first vote allowed")
|
|
assert.Equal(t, http.StatusBadRequest, vote(1), "second vote rejected")
|
|
body, code := getWithAnonAuth(fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1))
|
|
|
|
assert.Equal(t, http.StatusOK, code)
|
|
cr := store.Comment{}
|
|
err := json.Unmarshal([]byte(body), &cr)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 1, cr.Score)
|
|
assert.Equal(t, 1, cr.Vote)
|
|
assert.Equal(t, map[string]bool(nil), cr.Votes)
|
|
assert.Equal(t, map[string]store.VotedIPInfo(nil), cr.VotedIPs)
|
|
}
|
|
|
|
func TestRest_EmailAndTelegram(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
srv.privRest.telegramService = &mockTelegram{site: "remark42"}
|
|
|
|
// issue good token
|
|
claims := token.Claims{
|
|
Handshake: &token.Handshake{ID: "provider1_dev::good@example.com"},
|
|
RegisteredClaims: jwt.RegisteredClaims{
|
|
Audience: jwt.ClaimStrings{"remark42"},
|
|
ExpiresAt: jwt.NewNumericDate(time.Now().Add(10 * time.Minute)),
|
|
NotBefore: jwt.NewNumericDate(time.Now().Add(-1 * time.Minute)),
|
|
Issuer: "remark42",
|
|
},
|
|
}
|
|
tkn, err := srv.Authenticator.TokenService().Token(claims)
|
|
require.NoError(t, err)
|
|
goodToken := tkn
|
|
|
|
var testData = []struct {
|
|
description string
|
|
url string
|
|
method string
|
|
responseCode int
|
|
noAuth bool
|
|
cookieEmail string
|
|
body string
|
|
}{
|
|
{description: "issue delete request without auth", url: "/api/v1/email", method: http.MethodDelete, responseCode: http.StatusUnauthorized, noAuth: true},
|
|
{description: "issue delete request without site_id", url: "/api/v1/email", method: http.MethodDelete, responseCode: http.StatusForbidden},
|
|
{description: "delete non-existent user email", url: "/api/v1/email?site=remark42", method: http.MethodDelete, responseCode: http.StatusOK},
|
|
{description: "set user email, token not set", url: "/api/v1/email/confirm?site=remark42", method: http.MethodPost, responseCode: http.StatusBadRequest, body: `{"site":"remark42"}`},
|
|
{description: "set user email, token not set, old query param", url: "/api/v1/email/confirm?site=remark42", method: http.MethodPost, responseCode: http.StatusBadRequest},
|
|
{description: "send email confirmation without address", url: "/api/v1/email/subscribe?site=remark42", method: http.MethodPost, responseCode: http.StatusBadRequest, body: `{"site":"remark42"}`},
|
|
{description: "send email confirmation without address, old query param", url: "/api/v1/email/subscribe?site=remark42", method: http.MethodPost, responseCode: http.StatusBadRequest},
|
|
{description: "send email confirmation", url: "/api/v1/email/subscribe?site=remark42", method: http.MethodPost, responseCode: http.StatusOK, body: `{"site":"remark42","address":"good@example.com"}`},
|
|
{description: "send email confirmation, old query param", url: "/api/v1/email/subscribe?site=remark42&address=good@example.com", method: http.MethodPost, responseCode: http.StatusOK},
|
|
{description: "set user email, token is good", url: "/api/v1/email/confirm?site=remark42", method: http.MethodPost, responseCode: http.StatusOK, cookieEmail: "good@example.com", body: fmt.Sprintf(`{"site":"remark42","token":%q}`, goodToken)},
|
|
{description: "set user email, token is good, old query param", url: fmt.Sprintf("/api/v1/email/confirm?site=remark42&tkn=%s", goodToken), method: http.MethodPost, responseCode: http.StatusOK, cookieEmail: "good@example.com"},
|
|
{description: "send confirmation with same address", url: "/api/v1/email/subscribe?site=remark42&address=good@example.com", method: http.MethodPost, responseCode: http.StatusConflict},
|
|
{description: "get user email", url: "/api/v1/email?site=remark42", method: http.MethodGet, responseCode: http.StatusOK},
|
|
{description: "delete user email", url: "/api/v1/email?site=remark42", method: http.MethodDelete, responseCode: http.StatusOK},
|
|
{description: "send another confirmation", url: "/api/v1/email/subscribe?site=remark42&address=good@example.com", method: http.MethodPost, responseCode: http.StatusOK},
|
|
{description: "set user email, token is good", url: "/api/v1/email/confirm?site=remark42", method: http.MethodPost, responseCode: http.StatusOK, cookieEmail: "good@example.com", body: fmt.Sprintf(`{"site":"remark42","token":%q}`, goodToken)},
|
|
{description: "set user email, token is good, old query param", url: fmt.Sprintf("/api/v1/email/confirm?site=remark42&tkn=%s", goodToken), method: http.MethodPost, responseCode: http.StatusOK, cookieEmail: "good@example.com"},
|
|
{description: "unsubscribe user, no token", url: "/email/unsubscribe.html?site=remark42", method: http.MethodPost, responseCode: http.StatusBadRequest},
|
|
{description: "unsubscribe user, wrong token", url: "/email/unsubscribe.html?site=remark42&tkn=jwt", method: http.MethodGet, responseCode: http.StatusForbidden},
|
|
{description: "unsubscribe user, good token", url: fmt.Sprintf("/email/unsubscribe.html?site=remark42&tkn=%s", goodToken), method: http.MethodPost, responseCode: http.StatusOK},
|
|
{description: "unsubscribe user second time, good token", url: fmt.Sprintf("/email/unsubscribe.html?site=remark42&tkn=%s", goodToken), method: http.MethodPost, responseCode: http.StatusConflict},
|
|
{description: "issue delete request without auth", url: "/api/v1/telegram", method: http.MethodDelete, responseCode: http.StatusUnauthorized, noAuth: true},
|
|
{description: "issue delete request without site_id", url: "/api/v1/telegram", method: http.MethodDelete, responseCode: http.StatusForbidden},
|
|
{description: "delete non-existent user telegram", url: "/api/v1/telegram?site=remark42", method: http.MethodDelete, responseCode: http.StatusOK},
|
|
{description: "send telegram confirmation, no siteID", url: "/api/v1/telegram/subscribe", method: http.MethodGet, responseCode: http.StatusForbidden},
|
|
{description: "send telegram confirmation", url: "/api/v1/telegram/subscribe?site=remark42", method: http.MethodGet, responseCode: http.StatusOK},
|
|
{description: "set user telegram, token is good", url: "/api/v1/telegram/subscribe?site=remark42&tkn=good_token", method: http.MethodGet, responseCode: http.StatusOK},
|
|
{description: "send confirmation with same address", url: "/api/v1/telegram/subscribe?site=remark42", method: http.MethodGet, responseCode: http.StatusConflict},
|
|
{description: "delete user telegram", url: "/api/v1/telegram?site=remark42", method: http.MethodDelete, responseCode: http.StatusOK},
|
|
{description: "send another confirmation", url: "/api/v1/telegram/subscribe?site=remark42", method: http.MethodGet, responseCode: http.StatusOK},
|
|
{description: "set user telegram, token is good", url: "/api/v1/telegram/subscribe?site=remark42&tkn=good_token", method: http.MethodGet, responseCode: http.StatusOK},
|
|
// telegramSubscribeCtrl mutates state, so HEAD (which stdlib ServeMux would route to the
|
|
// GET handler) must be rejected by rejectHead before it runs
|
|
{description: "HEAD is rejected on telegram subscribe", url: "/api/v1/telegram/subscribe?site=remark42", method: http.MethodHead, responseCode: http.StatusMethodNotAllowed},
|
|
}
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
for _, x := range testData {
|
|
t.Run(x.description, func(t *testing.T) {
|
|
reqBody := io.NopCloser(strings.NewReader(x.body))
|
|
if x.body == "" {
|
|
reqBody = http.NoBody
|
|
}
|
|
req, err := http.NewRequest(x.method, ts.URL+x.url, reqBody)
|
|
require.NoError(t, err)
|
|
if !x.noAuth {
|
|
req.Header.Add("X-JWT", devToken)
|
|
}
|
|
resp, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
// read User.Email from the token in the cookie
|
|
for _, c := range resp.Cookies() {
|
|
if c.Name == "JWT" {
|
|
claims, err := srv.Authenticator.TokenService().Parse(c.Value)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, x.cookieEmail, claims.User.Email, "cookie email check failed")
|
|
}
|
|
}
|
|
assert.Equal(t, x.responseCode, resp.StatusCode, string(body))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRest_EmailNotification(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
mockDestination := ¬ify.MockDest{}
|
|
srv.privRest.notifyService = notify.NewService(srv.DataService, 1, mockDestination)
|
|
defer srv.privRest.notifyService.Close()
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
|
|
// create new comment from dev user
|
|
req, err := http.NewRequest("POST", ts.URL+"/api/v1/comment?site=remark42", strings.NewReader(
|
|
`{"text": "test 123",
|
|
"user": {"name": "provider1_dev::good@example.com"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
parentComment := store.Comment{}
|
|
require.NoError(t, json.Unmarshal(body, &parentComment))
|
|
waitForCount(t, 1, func() int { return len(mockDestination.Get()) })
|
|
assert.Empty(t, mockDestination.Get()[0].Emails)
|
|
|
|
// create child comment from another user, email notification only to admin expected
|
|
req, err = http.NewRequest("POST", ts.URL+"/api/v1/comment?site=remark42", strings.NewReader(fmt.Sprintf(
|
|
`{"text": "test 456",
|
|
"pid": %q,
|
|
"user": {"name": "other_user"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`, parentComment.ID)))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", anonToken)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
waitForCount(t, 2, func() int { return len(mockDestination.Get()) })
|
|
assert.Empty(t, mockDestination.Get()[1].Emails)
|
|
|
|
// send confirmation token for email
|
|
req, err = http.NewRequest(
|
|
http.MethodPost,
|
|
ts.URL+"/api/v1/email/subscribe?site=remark42",
|
|
io.NopCloser(strings.NewReader(`{"site": "remark42", "address": "good@example.com"}`)),
|
|
)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
waitForCount(t, 1, func() int { return len(mockDestination.GetVerify()) })
|
|
assert.Equal(t, "good@example.com", mockDestination.GetVerify()[0].Email)
|
|
verificationToken := mockDestination.GetVerify()[0].Token
|
|
|
|
// get user information to verify lack of the subscription
|
|
req, err = http.NewRequest(
|
|
http.MethodGet,
|
|
ts.URL+"/api/v1/user?site=remark42",
|
|
http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var clearUser store.User
|
|
err = json.Unmarshal(body, &clearUser)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "developer one", ID: "provider1_dev", EmailSubscription: false,
|
|
Picture: "http://example.com/pic.png", IP: "127.0.0.1", SiteID: "remark42"}, clearUser)
|
|
|
|
// verify email
|
|
req, err = http.NewRequest(
|
|
http.MethodPost,
|
|
ts.URL+"/api/v1/email/confirm?site=remark42",
|
|
io.NopCloser(strings.NewReader(fmt.Sprintf(`{"site": "remark42", "token": %q}`, verificationToken))),
|
|
)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
|
|
// get user information to verify the subscription
|
|
req, err = http.NewRequest(
|
|
http.MethodGet,
|
|
ts.URL+"/api/v1/user?site=remark42",
|
|
http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var subscribedUser store.User
|
|
err = json.Unmarshal(body, &subscribedUser)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "developer one", ID: "provider1_dev", EmailSubscription: true,
|
|
Picture: "http://example.com/pic.png", IP: "127.0.0.1", SiteID: "remark42"}, subscribedUser)
|
|
|
|
// create child comment from another user, email notification expected
|
|
req, err = http.NewRequest("POST", ts.URL+"/api/v1/comment?site=remark42", strings.NewReader(fmt.Sprintf(
|
|
`{"text": "test 789",
|
|
"pid": %q,
|
|
"user": {"name": "other_user"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`, parentComment.ID)))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", anonToken)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
waitForCount(t, 3, func() int { return len(mockDestination.Get()) })
|
|
assert.Equal(t, []string{"good@example.com"}, mockDestination.Get()[2].Emails)
|
|
|
|
// delete user's email
|
|
req, err = http.NewRequest(http.MethodDelete, ts.URL+"/api/v1/email?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
|
|
// create child comment from another user, no email notification
|
|
req, err = http.NewRequest("POST", ts.URL+"/api/v1/comment?site=remark42", strings.NewReader(
|
|
`{"text": "test 321",
|
|
"user": {"name": "other_user"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
waitForCountSettled(t, 4, func() int { return len(mockDestination.Get()) })
|
|
assert.Empty(t, mockDestination.Get()[3].Emails)
|
|
|
|
// confirm email via subscribe call with query params, old behavior, email notification is expected
|
|
req, err = http.NewRequest(
|
|
http.MethodPost,
|
|
ts.URL+"/api/v1/email/subscribe?site=remark42&address=good@example.com",
|
|
http.NoBody,
|
|
)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", emailUserToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
waitForCount(t, 2, func() int { return len(mockDestination.GetVerify()) }, "verification email was sent")
|
|
|
|
// get email user information to verify there is no subscription yet
|
|
req, err = http.NewRequest(
|
|
http.MethodGet,
|
|
ts.URL+"/api/v1/user?site=remark42",
|
|
http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", emailUserToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var unsubscribedEmailUser store.User
|
|
err = json.Unmarshal(body, &unsubscribedEmailUser)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "good@example.com test user", ID: "email_f5dfe9d2e6bd75fc74ea5fabf273b45b5baeb195", EmailSubscription: false,
|
|
Picture: "http://example.com/pic.png", IP: "127.0.0.1", SiteID: "remark42"}, unsubscribedEmailUser)
|
|
|
|
// confirm email via subscribe call, no email notification is expected
|
|
req, err = http.NewRequest(
|
|
http.MethodPost,
|
|
ts.URL+"/api/v1/email/subscribe?site=remark42",
|
|
io.NopCloser(strings.NewReader(`{"site": "remark42", "address": "good@example.com"}`)),
|
|
)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", emailUserToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
waitForCountSettled(t, 2, func() int { return len(mockDestination.GetVerify()) }, "no new verification email was sent")
|
|
|
|
// get email user information to verify the subscription happened without the confirmation call
|
|
req, err = http.NewRequest(
|
|
http.MethodGet,
|
|
ts.URL+"/api/v1/user?site=remark42",
|
|
http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", emailUserToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var subscribedEmailUser store.User
|
|
err = json.Unmarshal(body, &subscribedEmailUser)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "good@example.com test user", ID: "email_f5dfe9d2e6bd75fc74ea5fabf273b45b5baeb195", EmailSubscription: true,
|
|
Picture: "http://example.com/pic.png", IP: "127.0.0.1", SiteID: "remark42"}, subscribedEmailUser)
|
|
}
|
|
|
|
func TestRest_TelegramNotification(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
mockDestination := ¬ify.MockDest{}
|
|
srv.privRest.notifyService = notify.NewService(srv.DataService, 1, mockDestination)
|
|
defer srv.privRest.notifyService.Close()
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
|
|
// create new comment from dev user
|
|
req, err := http.NewRequest("POST", ts.URL+"/api/v1/comment?site=remark42", strings.NewReader(
|
|
`{"text": "test 123",
|
|
"user": {"name": "provider1_dev::good@example.com"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
parentComment := store.Comment{}
|
|
require.NoError(t, json.Unmarshal(body, &parentComment))
|
|
waitForCount(t, 1, func() int { return len(mockDestination.Get()) })
|
|
assert.Empty(t, mockDestination.Get()[0].Telegrams)
|
|
|
|
// create child comment from another user, telegram notification only to admin expected
|
|
req, err = http.NewRequest("POST", ts.URL+"/api/v1/comment?site=remark42", strings.NewReader(fmt.Sprintf(
|
|
`{"text": "test 456",
|
|
"pid": %q,
|
|
"user": {"name": "other_user"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`, parentComment.ID)))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", anonToken)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
waitForCount(t, 2, func() int { return len(mockDestination.Get()) })
|
|
assert.Empty(t, mockDestination.Get()[1].Telegrams)
|
|
|
|
// subscribe to telegram while the telegram destination is absent
|
|
req, err = http.NewRequest(http.MethodGet, ts.URL+"/api/v1/telegram/subscribe?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusInternalServerError, resp.StatusCode, string(body))
|
|
assert.Equal(t, `{"code":17,"details":"telegram notifications are not enabled","error":"not enabled"}`+"\n", string(body))
|
|
|
|
mockTlgrm := &mockTelegram{notVerified: true, site: "unknown_site"}
|
|
srv.privRest.telegramService = mockTlgrm
|
|
// send confirmation token for telegram
|
|
req, err = http.NewRequest(http.MethodGet, ts.URL+"/api/v1/telegram/subscribe?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var subscribeRequest struct {
|
|
Bot string `json:"bot"`
|
|
Token string `json:"token"`
|
|
}
|
|
err = json.Unmarshal(body, &subscribeRequest)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "botUsername", subscribeRequest.Bot)
|
|
|
|
// verify telegram, unsuccessfully because of not verified
|
|
req, err = http.NewRequest(http.MethodGet, ts.URL+fmt.Sprintf("/api/v1/telegram/subscribe?site=remark42&tkn=%s", subscribeRequest.Token), http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusNotFound, resp.StatusCode, string(body))
|
|
require.Equal(t, `{"code":0,"details":"request is not verified yet","error":"not verified"}`+"\n", string(body))
|
|
|
|
mockTlgrm.notVerified = false
|
|
|
|
// verify telegram, unsuccessfully because of unknown site
|
|
req, err = http.NewRequest(http.MethodGet, ts.URL+fmt.Sprintf("/api/v1/telegram/subscribe?site=remark42&tkn=%s", subscribeRequest.Token), http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusBadRequest, resp.StatusCode, string(body))
|
|
require.Equal(t, `{"code":0,"details":"can't set telegram for user","error":"site \"unknown_site\" not found"}`+"\n", string(body))
|
|
|
|
mockTlgrm.site = "remark42"
|
|
// verify telegram, successfully
|
|
req, err = http.NewRequest(http.MethodGet, ts.URL+fmt.Sprintf("/api/v1/telegram/subscribe?site=remark42&tkn=%s", subscribeRequest.Token), http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var subscribeResult struct {
|
|
Address string `json:"address"`
|
|
Updated bool `json:"updated"`
|
|
}
|
|
err = json.Unmarshal(body, &subscribeResult)
|
|
assert.NoError(t, err)
|
|
assert.True(t, subscribeResult.Updated)
|
|
|
|
// get user information to verify the subscription
|
|
req, err = http.NewRequest(http.MethodGet, ts.URL+"/api/v1/user?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var user store.User
|
|
err = json.Unmarshal(body, &user)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "developer one", ID: "provider1_dev",
|
|
Picture: "http://example.com/pic.png", IP: "127.0.0.1", SiteID: "remark42"}, user)
|
|
|
|
// create child comment from another user, telegram notification expected
|
|
req, err = http.NewRequest("POST", ts.URL+"/api/v1/comment?site=remark42", strings.NewReader(fmt.Sprintf(
|
|
`{"text": "test 789",
|
|
"pid": %q,
|
|
"user": {"name": "other_user"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`, parentComment.ID)))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", anonToken)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
waitForCount(t, 3, func() int { return len(mockDestination.Get()) })
|
|
assert.Equal(t, []string{"good_telegram"}, mockDestination.Get()[2].Telegrams)
|
|
|
|
// delete user's telegram
|
|
req, err = http.NewRequest(http.MethodDelete, ts.URL+"/api/v1/telegram?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
|
|
// create child comment from another user, no telegram notification
|
|
req, err = http.NewRequest("POST", ts.URL+"/api/v1/comment?site=remark42", strings.NewReader(
|
|
`{"text": "test 321",
|
|
"user": {"name": "other_user"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
waitForCountSettled(t, 4, func() int { return len(mockDestination.Get()) })
|
|
assert.Empty(t, mockDestination.Get()[3].Telegrams)
|
|
}
|
|
|
|
func TestRest_UserAllData(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
// write 3 comments
|
|
user := store.User{ID: "provider1_dev", Name: "user name 1"}
|
|
c1 := store.Comment{User: user, Text: "test test #1", Locator: store.Locator{SiteID: "remark42",
|
|
URL: "https://radio-t.com/blah1"}, Timestamp: time.Date(2018, 5, 27, 1, 14, 10, 0, time.Local)}
|
|
c2 := store.Comment{User: user, Text: "test test #2", ParentID: "p1", Locator: store.Locator{SiteID: "remark42",
|
|
URL: "https://radio-t.com/blah1"}, Timestamp: time.Date(2018, 5, 27, 1, 14, 20, 0, time.Local)}
|
|
c3 := store.Comment{User: user, Text: "test test #3", ParentID: "p1", Locator: store.Locator{SiteID: "remark42",
|
|
URL: "https://radio-t.com/blah1"}, Timestamp: time.Date(2018, 5, 27, 1, 14, 25, 0, time.Local)}
|
|
_, err := srv.DataService.Create(c1)
|
|
require.NoError(t, err, "%+v", err)
|
|
_, err = srv.DataService.Create(c2)
|
|
require.NoError(t, err)
|
|
_, err = srv.DataService.Create(c3)
|
|
require.NoError(t, err)
|
|
|
|
client := &http.Client{Timeout: waitTimeout}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest("GET", ts.URL+"/api/v1/userdata?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
require.Equal(t, "application/gzip", resp.Header.Get("Content-Type"))
|
|
|
|
ungzReader, err := gzip.NewReader(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
ungzBody, err := io.ReadAll(ungzReader)
|
|
require.NoError(t, err)
|
|
strUungzBody := string(ungzBody)
|
|
assert.True(t, strings.HasPrefix(strUungzBody,
|
|
`{"info": {"name":"developer one","id":"provider1_dev","picture":"http://example.com/pic.png","ip":"127.0.0.1","admin":false,"site_id":"remark42"}, "comments":[{`))
|
|
assert.Equal(t, 3, strings.Count(strUungzBody, `"text":`), "3 comments inside")
|
|
|
|
parsed := struct {
|
|
Info store.User `json:"info"`
|
|
Comments []store.Comment `json:"comments"`
|
|
}{}
|
|
|
|
err = json.Unmarshal(ungzBody, &parsed)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "developer one", ID: "provider1_dev",
|
|
Picture: "http://example.com/pic.png", IP: "127.0.0.1", SiteID: "remark42"}, parsed.Info)
|
|
assert.Equal(t, 3, len(parsed.Comments))
|
|
|
|
req, err = http.NewRequest("GET", ts.URL+"/api/v1/userdata?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusUnauthorized, resp.StatusCode)
|
|
}
|
|
|
|
func TestRest_UserAllDataManyComments(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
user := store.User{ID: "provider1_dev", Name: "user name 1"}
|
|
c := store.Comment{User: user, Text: "test test #1", Locator: store.Locator{SiteID: "remark42",
|
|
URL: "https://radio-t.com/blah1"}, Timestamp: time.Date(2018, 5, 27, 1, 14, 10, 0, time.Local)}
|
|
|
|
for i := range 51 {
|
|
c.ID = fmt.Sprintf("id-%03d", i)
|
|
c.Timestamp = c.Timestamp.Add(time.Second)
|
|
_, err := srv.DataService.Create(c)
|
|
require.NoError(t, err)
|
|
}
|
|
client := &http.Client{Timeout: waitTimeout}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest("GET", ts.URL+"/api/v1/userdata?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
require.Equal(t, "application/gzip", resp.Header.Get("Content-Type"))
|
|
|
|
ungzReader, err := gzip.NewReader(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
ungzBody, err := io.ReadAll(ungzReader)
|
|
assert.NoError(t, err)
|
|
strUngzBody := string(ungzBody)
|
|
assert.True(t, strings.HasPrefix(strUngzBody,
|
|
`{"info": {"name":"developer one","id":"provider1_dev","picture":"http://example.com/pic.png","ip":"127.0.0.1","admin":false,"site_id":"remark42"}, "comments":[{`))
|
|
assert.Equal(t, 51, strings.Count(strUngzBody, `"text":`), "51 comments inside")
|
|
}
|
|
|
|
func TestRest_DeleteMe(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPost, fmt.Sprintf("%s/api/v1/deleteme?site=remark42", ts.URL), http.NoBody)
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
body, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, resp.Body.Close())
|
|
assert.NoError(t, err)
|
|
|
|
m := map[string]string{}
|
|
err = json.Unmarshal(body, &m)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "remark42", m["site"])
|
|
assert.Equal(t, "provider1_dev", m["user_id"])
|
|
|
|
tkn := m["token"]
|
|
claims, err := srv.Authenticator.TokenService().Parse(tkn)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "provider1_dev", claims.User.ID)
|
|
assert.Equal(t, "http://example.com/pic.png", claims.User.Picture,
|
|
"delete_me token must carry the user's picture so the avatar can be removed when the request is processed")
|
|
assert.Equal(t, "https://demo.remark42.com/web/deleteme.html?token="+tkn, m["link"])
|
|
|
|
req, err = http.NewRequest(http.MethodPost, fmt.Sprintf("%s/api/v1/deleteme?site=remark42", ts.URL), http.NoBody)
|
|
assert.NoError(t, err)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusUnauthorized, resp.StatusCode)
|
|
assert.NoError(t, resp.Body.Close())
|
|
}
|
|
|
|
func TestRest_SavePictureCtrl(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
// save picture
|
|
savePic := func(name string) (id string) {
|
|
bodyBuf := &bytes.Buffer{}
|
|
bodyWriter := multipart.NewWriter(bodyBuf)
|
|
fileWriter, err := bodyWriter.CreateFormFile("file", name)
|
|
require.NoError(t, err)
|
|
_, err = io.Copy(fileWriter, gopherPNG())
|
|
require.NoError(t, err)
|
|
contentType := bodyWriter.FormDataContentType()
|
|
require.NoError(t, bodyWriter.Close())
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPost, fmt.Sprintf("%s/api/v1/picture?site=remark42", ts.URL), bodyBuf)
|
|
require.NoError(t, err)
|
|
req.Header.Add("Content-Type", contentType)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
body, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
|
|
m := map[string]string{}
|
|
err = json.Unmarshal(body, &m)
|
|
assert.NoError(t, err)
|
|
assert.True(t, m["id"] != "")
|
|
return m["id"]
|
|
}
|
|
|
|
id := savePic("picture.png")
|
|
resp, err := http.Get(fmt.Sprintf("%s/api/v1/picture/%s", ts.URL, id))
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
body, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, 1462, len(body))
|
|
assert.Equal(t, "image/png", resp.Header.Get("Content-Type"))
|
|
|
|
id = savePic("picture.gif")
|
|
resp, err = http.Get(fmt.Sprintf("%s/api/v1/picture/%s", ts.URL, id))
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
assert.Equal(t, "image/png", resp.Header.Get("Content-Type"))
|
|
|
|
id = savePic("picture.jpg")
|
|
resp, err = http.Get(fmt.Sprintf("%s/api/v1/picture/%s", ts.URL, id))
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
assert.Equal(t, "image/png", resp.Header.Get("Content-Type"))
|
|
|
|
id = savePic("picture.blah")
|
|
resp, err = http.Get(fmt.Sprintf("%s/api/v1/picture/%s", ts.URL, id))
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
assert.Equal(t, "image/png", resp.Header.Get("Content-Type"))
|
|
|
|
resp, err = http.Get(fmt.Sprintf("%s/api/v1/picture/blah/pic.blah", ts.URL))
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
|
|
}
|
|
|
|
func TestRest_CreateWithPictures(t *testing.T) {
|
|
ts, svc, teardown := startupT(t)
|
|
defer func() {
|
|
teardown()
|
|
assert.NoError(t, os.RemoveAll("/tmp/remark42"))
|
|
}()
|
|
lgr.Setup(lgr.Debug, lgr.CallerFile, lgr.CallerFunc)
|
|
|
|
imageService := image.NewService(&image.FileSystem{
|
|
Staging: "/tmp/remark42/images.staging",
|
|
Location: "/tmp/remark42/images",
|
|
}, image.ServiceParams{
|
|
// the "not moved yet" checks below run right after the comment POST returns, so the
|
|
// commit window has to be wide enough that a stalled runner cannot close it first
|
|
EditDuration: 3 * time.Second,
|
|
MaxSize: 2000,
|
|
ImageAPI: svc.RemarkURL + "/api/v1/picture/",
|
|
ProxyAPI: svc.RemarkURL + "/api/v1/img",
|
|
})
|
|
defer imageService.Close(context.Background())
|
|
|
|
svc.privRest.imageService = imageService
|
|
svc.ImageService = imageService
|
|
|
|
dataService := svc.DataService
|
|
dataService.ImageService = svc.ImageService
|
|
svc.privRest.dataService = dataService
|
|
|
|
uploadPicture := func(file string) (id string) {
|
|
bodyBuf := &bytes.Buffer{}
|
|
bodyWriter := multipart.NewWriter(bodyBuf)
|
|
fileWriter, err := bodyWriter.CreateFormFile("file", file)
|
|
require.NoError(t, err)
|
|
_, err = io.Copy(fileWriter, gopherPNG())
|
|
require.NoError(t, err)
|
|
contentType := bodyWriter.FormDataContentType()
|
|
require.NoError(t, bodyWriter.Close())
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPost, fmt.Sprintf("%s/api/v1/picture?site=remark42", ts.URL), bodyBuf)
|
|
require.NoError(t, err)
|
|
req.Header.Add("Content-Type", contentType)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
|
|
body, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
m := map[string]string{}
|
|
err = json.Unmarshal(body, &m)
|
|
assert.NoError(t, err)
|
|
return m["id"]
|
|
}
|
|
|
|
var ids [3]string
|
|
|
|
for i := range ids {
|
|
ids[i] = uploadPicture(fmt.Sprintf("pic%d.png", i))
|
|
}
|
|
|
|
text := fmt.Sprintf(`text 123  *xxx*  `, svc.RemarkURL, ids[0], svc.RemarkURL, ids[1], svc.RemarkURL, ids[2])
|
|
body := fmt.Sprintf(`{"text": %q, "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`, text)
|
|
|
|
resp, err := post(t, ts.URL+"/api/v1/comment?site=remark42", body)
|
|
assert.NoError(t, err)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(b))
|
|
|
|
for i := range ids {
|
|
_, err = os.Stat("/tmp/remark42/images/" + ids[i])
|
|
assert.Error(t, err, "picture %d not moved from staging yet", i)
|
|
}
|
|
|
|
// the commit runs once EditDuration expires
|
|
for i := range ids {
|
|
require.Eventually(t, func() bool {
|
|
_, e := os.Stat("/tmp/remark42/images/" + ids[i])
|
|
return e == nil
|
|
}, waitTimeout, pollInterval, "picture %d moved from staging and available in permanent location", i)
|
|
}
|
|
}
|
|
|
|
type mockTelegram struct {
|
|
notVerified bool
|
|
site string
|
|
}
|
|
|
|
func (m *mockTelegram) AddToken(string, string, string, time.Time) {}
|
|
|
|
func (m *mockTelegram) GetBotUsername() string {
|
|
return "botUsername"
|
|
}
|
|
|
|
func (m *mockTelegram) CheckToken(string, string) (telegram, site string, err error) {
|
|
if m.notVerified {
|
|
return "", "", fmt.Errorf("not verified")
|
|
}
|
|
return "good_telegram", m.site, nil
|
|
}
|
|
|
|
func TestExtractIP(t *testing.T) {
|
|
tbl := []struct {
|
|
addr string
|
|
exp string
|
|
}{
|
|
{"127.0.0.1:8080", "127.0.0.1"},
|
|
{"127.0.0.1", "127.0.0.1"},
|
|
{"192.168.1.1:443", "192.168.1.1"},
|
|
{"[::1]:8080", "::1"},
|
|
{"::1", "::1"},
|
|
{"[2001:db8::1]:8080", "2001:db8::1"},
|
|
{"2001:db8::1", "2001:db8::1"},
|
|
{"[fe80::1%25eth0]:80", "fe80::1%25eth0"},
|
|
{"", ""},
|
|
}
|
|
|
|
for _, tt := range tbl {
|
|
t.Run(tt.addr, func(t *testing.T) {
|
|
assert.Equal(t, tt.exp, extractIP(tt.addr))
|
|
})
|
|
}
|
|
}
|